From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752514AbaDDWs4 (ORCPT ); Fri, 4 Apr 2014 18:48:56 -0400 Received: from mail-vc0-f182.google.com ([209.85.220.182]:52421 "EHLO mail-vc0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199AbaDDWsy (ORCPT ); Fri, 4 Apr 2014 18:48:54 -0400 MIME-Version: 1.0 In-Reply-To: References: <20140403104308.GP13491@8bytes.org> <20140403170541.GA19010@thunk.org> <533EF832.1030902@mit.edu> <20140404115139.3ea3d53126094f41bc0579a0@linux-foundation.org> <20140404154426.6f099f7d@gandalf.local.home> <20140404201750.GA10275@thunk.org> Date: Fri, 4 Apr 2014 15:48:53 -0700 X-Google-Sender-Auth: D-Q1T-d7LI4gQp6g8kQw-zQMYGo Message-ID: Subject: Re: [RFC PATCH] cmdline: Hide "debug" from /proc/cmdline From: Linus Torvalds To: Alexei Starovoitov Cc: "Theodore Ts'o" , Steven Rostedt , Andrew Morton , Andy Lutomirski , Joerg Roedel , Jiri Kosina , Mateusz Guzik , Greg Kroah-Hartman , LKML , Thomas Gleixner , "H. Peter Anvin" , Borislav Petkov , Ingo Molnar , Mel Gorman , Kay Sievers Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 4, 2014 at 3:45 PM, Alexei Starovoitov wrote: > > can there be two bulletproof buffers: one for in kernel printk > and another ratelimited one for writes into /dev/kmsg. > On the read from /dev/kmsg they're combined by time. Or, you know, people could just stop spamming /dev/kmsg. Let's not overdesign this. No sane use will be impacted by rate limiting, and insane uses aren't something we should design for. Even the systemd spam was a *bug*, for chrissake. Linus