From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752810AbbF1TwU (ORCPT <rfc822;w@1wt.eu>);
	Sun, 28 Jun 2015 15:52:20 -0400
Received: from mail-ig0-f177.google.com ([209.85.213.177]:34438 "EHLO
	mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752209AbbF1TwL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 28 Jun 2015 15:52:11 -0400
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.00.1506281506450.29365@leontynka>
References: <alpine.DEB.2.00.1506281506450.29365@leontynka>
Date: Sun, 28 Jun 2015 12:52:11 -0700
X-Google-Sender-Auth: AVcaDgk9YwVvcdBlk46s2XD1cNE
Message-ID: <CA+55aFzY9Y8tgrv=HW6Sia_CmgLvn6_pC4MnLQYbmC8Urfbh+Q@mail.gmail.com>
Subject: Re: [PATCH] hpfs: add fstrim support
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Mikulas Patocka <mikulas@twibright.com>, Al Viro <viro@zeniv.linux.org.uk>,
        "Ted Ts'o" <tytso@google.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jun 28, 2015 at 6:16 AM, Mikulas Patocka <mikulas@twibright.com> wrote:
> This patch adds support for fstrim to the HPFS filesystem.
...
> +#ifdef CONFIG_COMPAT
> +       .compat_ioctl   = hpfs_compat_ioctl,
> +#endif
...
> +#ifdef CONFIG_COMPAT
> +       .compat_ioctl   = hpfs_compat_ioctl,
> +#endif
...
> +#ifdef CONFIG_COMPAT
> +long hpfs_compat_ioctl(struct file *file, unsigned cmd, unsigned long arg)
> +{
> +       return hpfs_ioctl(file, cmd, (unsigned long)compat_ptr(arg));
> +}
> +#endif

Hmm. You've clearly copied this pattern from other filesystems, and so
I can't really blame you, but this thing annoys me a lot.

Why isn't FITRIM just marked as a COMPATIBLE_IOCTL(), at which point
the generic ioctl layer will do exactly the above translation for us?

Am I missing something?

                     Linus