From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933017Ab1KBSBB (ORCPT ); Wed, 2 Nov 2011 14:01:01 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:65372 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932240Ab1KBSA7 (ORCPT ); Wed, 2 Nov 2011 14:00:59 -0400 MIME-Version: 1.0 In-Reply-To: <1320256412.2292.17.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> References: <1318874090.4172.84.camel@twins> <1318879396.4172.92.camel@twins> <1318928713.21167.4.camel@twins> <20111018182046.GF1309@hostway.ca> <20111024190203.GA24410@hostway.ca> <20111025202049.GB25043@hostway.ca> <20111031173246.GA10614@hostway.ca> <1320254854.2292.14.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <1320256412.2292.17.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> From: Linus Torvalds Date: Wed, 2 Nov 2011 11:00:35 -0700 X-Google-Sender-Auth: oX3i7og6CRUEJlh1QVwqykTr5zg Message-ID: Subject: Re: Linux 3.1-rc9 To: Eric Dumazet Cc: Thomas Gleixner , Simon Kirby , David Miller , Peter Zijlstra , Linux Kernel Mailing List , Dave Jones , Martin Schwidefsky , Ingo Molnar , Network Development Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 2, 2011 at 10:53 AM, Eric Dumazet wrote: > > tcp_v4_syn_recv_sock() > { > newsk = tcp_create_openreq_child(sk, req, skb); > > newsk is locked at this point. Umm, if that is the case, then the bug predates the commit you point to. There were exit paths before that too. Linus