All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Vince Weaver <vincent.weaver@maine.edu>,
	LKML <linux-kernel@vger.kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] scripts: add script for translating stack dump function offsets
Date: Fri, 16 Sep 2016 12:26:31 -0700	[thread overview]
Message-ID: <CA+55aFz_=-WQMZ3exuSEzNUzdB_ica8VZtCbf3wsj1XGFOTS+w@mail.gmail.com> (raw)
In-Reply-To: <20160916191738.v3kq3c44zmdsvlgb@treble>

On Fri, Sep 16, 2016 at 12:17 PM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> I think that issue is solved by addr2line's '--inline' option, which the
> script uses:

Oh, well, even better. I clearly don't know addr2line well enough, and
having a script that does this correctly automatically is clearly what
*I* need too.

>>                 So both the function offset
>> filtering and the type filtering could definitely make a difference.
>
> Yeah, good ideas.  That would help reduce some of the false duplicates,
> though they are quite rare.  I'll see what I can do.

Yeah, in practice the false duplicates almost never happen. We do have
duplicate function names, but they tend to be for simple things.

And the call trace often makes it obvious which particular function it
is for the human that is reading the output, but since it should be
easy to cut down on the potential duplicates, I think it's a good
thing to do.

           Linus

  reply	other threads:[~2016-09-16 19:26 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15  2:43 perf: perf_fuzzer lockup in perf_cgroup_attach Vince Weaver
2016-09-15  5:35 ` Stephane Eranian
2016-09-15  7:24   ` Peter Zijlstra
2016-09-15 12:10     ` Josh Poimboeuf
2016-09-16 14:48       ` [PATCH] scripts: add script for translating stack dump function offsets Josh Poimboeuf
2016-09-16 18:12         ` Linus Torvalds
2016-09-16 19:17           ` Josh Poimboeuf
2016-09-16 19:26             ` Linus Torvalds [this message]
2016-09-16 21:26               ` [PATCH v2] " Josh Poimboeuf
2016-09-17  0:09                 ` Linus Torvalds
2016-09-17  0:42                   ` Josh Poimboeuf
2016-09-17  1:59                     ` Linus Torvalds
2016-09-17  2:31                       ` Linus Torvalds
2016-09-17 18:45                       ` Josh Poimboeuf
2016-09-19 15:52                       ` [PATCH v3] scripts: add script for translating stack dump function Josh Poimboeuf
2016-09-19 18:56                         ` Linus Torvalds
2016-09-19 19:15                           ` Linus Torvalds
2016-09-19 19:28                             ` Josh Poimboeuf
2016-09-19 20:00                             ` Rabin Vincent
2016-09-19 20:24                               ` Linus Torvalds
2016-09-19 20:56                                 ` Josh Poimboeuf
2016-09-19 21:02                                   ` Linus Torvalds
2016-09-19 21:07                                     ` Josh Poimboeuf
2016-09-17  1:25                 ` [PATCH v2] scripts: add script for translating stack dump function offsets Peter Zijlstra
2016-09-17  8:15                 ` Rabin Vincent
2016-09-17 18:48                   ` Josh Poimboeuf
2016-09-17  9:11             ` [PATCH] " Vegard Nossum
2016-09-17 18:54               ` Josh Poimboeuf
2016-09-15 12:47   ` perf: perf_fuzzer lockup in perf_cgroup_attach Vince Weaver
2016-09-15  7:15 ` Peter Zijlstra
2016-09-15 12:41   ` Vince Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+55aFz_=-WQMZ3exuSEzNUzdB_ica8VZtCbf3wsj1XGFOTS+w@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.