From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754512AbcJERH6 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 5 Oct 2016 13:07:58 -0400
Received: from mail-oi0-f44.google.com ([209.85.218.44]:33004 "EHLO
        mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752145AbcJERH4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 5 Oct 2016 13:07:56 -0400
MIME-Version: 1.0
In-Reply-To: <1475686858.6105.7.camel@perches.com>
References: <CA+55aFwyNTLuZgOWMTRuabWobF27ygskuxvFd-P0n-3UNT=0Og@mail.gmail.com>
 <20161004093216.GA21170@cmpxchg.org> <CA+55aFzyXEwKAaX6zo-9DdXRjzAVP0Lwnr7gsAEm6Q8CGT+EFg@mail.gmail.com>
 <20161005092534.GA20174@cmpxchg.org> <CA+55aFy2Kwud6N315zEK=0Jrh4GXc+ALZdqRONgOGcuy9feH9w@mail.gmail.com>
 <1475686858.6105.7.camel@perches.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed, 5 Oct 2016 10:07:55 -0700
X-Google-Sender-Auth: dOGf-1m3QTgZSCSEPIKtvCP-nPg
Message-ID: <CA+55aFz_i6c=eV9ff0qxg4QccZ986JAedp9u72YZ7DqJM8EGLw@mail.gmail.com>
Subject: Re: [PATCH] checkpatch: extend BUG warning
To: Joe Perches <joe@perches.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
        Andy Whitcroft <apw@canonical.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Antonio SJ Musumeci <trapexit@spawn.link>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Dave Jones <davej@codemonkey.org.uk>, Oleg Nesterov <oleg@redhat.com>,
        Dave Chinner <david@fromorbit.com>, Michal Hocko <mhocko@kernel.org>,
        Jan Kara <jack@suse.cz>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        stable <stable@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 5, 2016 at 10:00 AM, Joe Perches <joe@perches.com> wrote:
>    1838 BUILD_BUG_ON
>     632 snd_BUG_ON

At least snd_BUG_ON() is actually fine. The sound system does
something sane with their bugs: they just turn into WARN_ON()'s (and
then !CONFIG_SND_DEBUG will disable them entirely).

I haven't checked the other ones, but it was actually nice to see that
one: considering that it's the most widely used one (ignoring the
obviously great BUILD_BUG_ON), the fact that it just spews a warning
indicates that that model works fine.

                    Linus