From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751375AbcFISz2 (ORCPT ); Thu, 9 Jun 2016 14:55:28 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:36537 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbcFISzZ (ORCPT ); Thu, 9 Jun 2016 14:55:25 -0400 MIME-Version: 1.0 In-Reply-To: References: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> <1465448705-25055-3-git-send-email-deepa.kernel@gmail.com> From: Linus Torvalds Date: Thu, 9 Jun 2016 11:55:24 -0700 X-Google-Sender-Auth: 636ndmdAVolUojrD1-yU2yID6oY Message-ID: Subject: Re: [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps To: Deepa Dinamani Cc: linux-fsdevel , Linux Kernel Mailing List , Arnd Bergmann , Thomas Gleixner , Al Viro , y2038@lists.linaro.org, "Theodore Ts'o" , Andreas Dilger , "linux-ext4@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 9, 2016 at 11:45 AM, Linus Torvalds wrote: > > All existing users and all the ones in this patch (and the others too, > although I didn't go through them very carefully) really would prefer > just passing in the inode directly, rather than the superblock. Actually, there seems to be one exception to that "all existing users", and that one exception (btrfs transacation time) really seems to be broken. Exactly because it's *not* setting an inode time, it shouldn't have used current_fs_time() to begin with, because it is just setting an internal filesystem timestamp. So not making the argument inode-related seems to actually encourage people to misuse this function. Linus