From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751302AbdH2RUF (ORCPT <rfc822;w@1wt.eu>);
        Tue, 29 Aug 2017 13:20:05 -0400
Received: from mail-io0-f180.google.com ([209.85.223.180]:36557 "EHLO
        mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751215AbdH2RUE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 29 Aug 2017 13:20:04 -0400
MIME-Version: 1.0
In-Reply-To: <1504026634.2040.27.camel@perches.com>
References: <20170815025625.1977-1-sergey.senozhatsky@gmail.com>
 <20170828090521.GA25025@amd> <CA+55aFx_o_FfCO+c62zMWH8H8rLJsnKZ1TWvMqyUs2A90QJgGg@mail.gmail.com>
 <1504026634.2040.27.camel@perches.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 29 Aug 2017 10:20:02 -0700
X-Google-Sender-Auth: wywjvNGyRsTsO8ymbux_AINiq1w
Message-ID: <CA+55aFzi_Rt6g8aS1RSvszcH6e+=HCDi1g2SDKtEY0BA+cL5VQ@mail.gmail.com>
Subject: Re: printk: what is going on with additional newlines?
To: Joe Perches <joe@perches.com>
Cc: Pavel Machek <pavel@ucw.cz>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Petr Mladek <pmladek@suse.com>, Steven Rostedt <rostedt@goodmis.org>,
        Jan Kara <jack@suse.cz>, Andrew Morton <akpm@linux-foundation.org>,
        Jiri Slaby <jslaby@suse.com>, Andreas Mohr <andi@lisas.de>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 29, 2017 at 10:10 AM, Joe Perches <joe@perches.com> wrote:
> That's simply false.
>
> It was never true until you made it a requirement.
> (it's not a bad requirement, but it did change behavior)

Oh, it changed behavior, yes (and for kernel code we do that, and
require people to change).

But even before it was technically required, it was very much supposed
to be there as a marker. KERN_CONT has existed for about a decade.

It was added in commit 474925277671 ("printk: add KERN_CONT
annotation") back in 2007, with a comment that said - at that time:

  /*
   * Annotation for a "continued" line of log printout (only done after a
   * line that had no enclosing \n). Only to be used by core/arch code
   * during early bootup (a continued line is not SMP-safe otherwise).
   */

so basically for the last ten years, it's very much been policy that

 (a) you shouldn't do this except for during early bootiup

 (b) you should have that KERN_CONT marker to show that you're doing it

So this is *not* new.

What is new is the enforcement, because people didn't follow the rules
without it.

So yes, we're enforcing it now, and we're not going back to the
unenforced times, because a decade of shit has shown that people
didn't do it without being forced to.

                  Linus