From: Linus Torvalds <torvalds@linux-foundation.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Matteo Franchin <Matteo.Franchin@arm.com>,
Darren Hart <dvhart@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Mike Galbraith <umgwanakikbuti@gmail.com>
Subject: Re: [PATCH] futex: Ensure get_futex_key_refs() always implies a barrier
Date: Sat, 18 Oct 2014 13:50:18 -0700 [thread overview]
Message-ID: <CA+55aFzmsF4F-SOO4OzZDbreaQ4X4RUCQksv_ONu59BbyZ8Ocg@mail.gmail.com> (raw)
In-Reply-To: <1413662314.17869.11.camel@linux-t7sj.site>
On Sat, Oct 18, 2014 at 12:58 PM, Davidlohr Bueso <dave@stgolabs.net> wrote:
>
> And [get/put]_futex_keys() shouldn't even be called for private futexes.
> The following patch had some very minor testing on a 60 core box last
> night, but passes both Darren's and perf's tests. So I *think* this is
> right, but lack of sleep and I overall just don't trust them futexes!
Hmm. I don't see the advantage of making the code more complex in
order to avoid the functions that are no-ops for the !fshared case?
IOW, as far as I can tell, this patch doesn't actually really *change*
anything. Am I missing something?
Linus
next prev parent reply other threads:[~2014-10-18 20:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 16:38 [PATCH] futex: Ensure get_futex_key_refs() always implies a barrier Catalin Marinas
2014-10-18 6:54 ` Mike Galbraith
2014-10-18 7:09 ` Mike Galbraith
2014-10-18 15:28 ` Linus Torvalds
2014-10-18 16:15 ` Mike Galbraith
2014-10-18 7:33 ` Davidlohr Bueso
2014-10-18 19:58 ` Davidlohr Bueso
2014-10-18 20:50 ` Linus Torvalds [this message]
2014-10-19 2:16 ` Davidlohr Bueso
2014-10-20 9:11 ` Thomas Gleixner
2014-10-20 10:49 ` Catalin Marinas
2014-10-20 15:32 ` Linus Torvalds
2014-10-20 16:00 ` Catalin Marinas
2014-10-18 19:32 ` Darren Hart
2014-10-18 20:19 ` Davidlohr Bueso
2014-10-18 20:25 ` Darren Hart
2014-10-20 10:15 ` Catalin Marinas
2014-10-24 3:27 ` [PATCH] futex: Mention key referencing differences between shared and private futexes Davidlohr Bueso
2014-10-24 9:11 ` Catalin Marinas
2014-10-26 15:22 ` [tip:locking/urgent] " tip-bot for Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFzmsF4F-SOO4OzZDbreaQ4X4RUCQksv_ONu59BbyZ8Ocg@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=Matteo.Franchin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dave@stgolabs.net \
--cc=dvhart@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.