From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756732Ab2EYQzP (ORCPT ); Fri, 25 May 2012 12:55:15 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:39979 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752645Ab2EYQzL convert rfc822-to-8bit (ORCPT ); Fri, 25 May 2012 12:55:11 -0400 MIME-Version: 1.0 In-Reply-To: <201202172159.15396.rjw@sisk.pl> References: <201201281445.49377.rjw@sisk.pl> <201202172159.15396.rjw@sisk.pl> Date: Fri, 25 May 2012 12:55:10 -0400 Message-ID: Subject: Re: [RFC][PATCH] PM / Sleep: Freeze filesystems during system suspend/hibernation From: Josh Boyer To: "Rafael J. Wysocki" Cc: Linux PM list , LKML , Jan Kara , linux-fsdevel@vger.kernel.org, Dave Chinner , Nigel Cunningham , Pavel Machek , "Srivatsa S. Bhat" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2012 at 3:59 PM, Rafael J. Wysocki wrote: >> commit b94887bbc0621e1e8402e7f0ec4bc3adf46c9a6e >> Author: Rafael J. Wysocki >> Date:   Fri Feb 17 12:42:08 2012 -0500 >> >>     Freeze all filesystems during system suspend and (kernel-driven) >>     hibernation by calling freeze_supers() for all superblocks and thaw >>     them during the subsequent resume with the help of thaw_supers(). >> >>     This makes filesystems stay in a consistent state in case something >>     goes wrong between system suspend (or hibernation) and the subsequent >>     resume (e.g. journal replays won't be necessary in those cases).  In >>     particular, this should help to solve a long-standing issue that, in >>     some cases, during resume from hibernation the boot loader causes the >>     journal to be replied for the filesystem containing the kernel image >>     and/or initrd causing it to become inconsistent with the information >>     stored in the hibernation image. >> >>     The user-space-driven hibernation (s2disk) is not covered by this >>     change, because the freezing of filesystems prevents s2disk from >>     accessing device special files it needs to do its job. >> >>     This change is based on earlier work by Nigel Cunningham. >> >>     Signed-off-by: Rafael J. Wysocki >> >>     Rebased to 3.3-rc3 by Josh Boyer Did this patch ever wind up going anywhere? Fedora has it sitting in our tree with a comment that says "rebase" and I don't see it in the linux-next tree at all. Did if fall through the cracks or was it NAKed somewhere? josh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Boyer Subject: Re: [RFC][PATCH] PM / Sleep: Freeze filesystems during system suspend/hibernation Date: Fri, 25 May 2012 12:55:10 -0400 Message-ID: References: <201201281445.49377.rjw@sisk.pl> <201202172159.15396.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Linux PM list , LKML , Jan Kara , linux-fsdevel@vger.kernel.org, Dave Chinner , Nigel Cunningham , Pavel Machek , "Srivatsa S. Bhat" To: "Rafael J. Wysocki" Return-path: Received: from mail-qc0-f174.google.com ([209.85.216.174]:39979 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752645Ab2EYQzL convert rfc822-to-8bit (ORCPT ); Fri, 25 May 2012 12:55:11 -0400 In-Reply-To: <201202172159.15396.rjw@sisk.pl> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Feb 17, 2012 at 3:59 PM, Rafael J. Wysocki wrote: >> commit b94887bbc0621e1e8402e7f0ec4bc3adf46c9a6e >> Author: Rafael J. Wysocki >> Date: =A0 Fri Feb 17 12:42:08 2012 -0500 >> >> =A0 =A0 Freeze all filesystems during system suspend and (kernel-dri= ven) >> =A0 =A0 hibernation by calling freeze_supers() for all superblocks a= nd thaw >> =A0 =A0 them during the subsequent resume with the help of thaw_supe= rs(). >> >> =A0 =A0 This makes filesystems stay in a consistent state in case so= mething >> =A0 =A0 goes wrong between system suspend (or hibernation) and the s= ubsequent >> =A0 =A0 resume (e.g. journal replays won't be necessary in those cas= es). =A0In >> =A0 =A0 particular, this should help to solve a long-standing issue = that, in >> =A0 =A0 some cases, during resume from hibernation the boot loader c= auses the >> =A0 =A0 journal to be replied for the filesystem containing the kern= el image >> =A0 =A0 and/or initrd causing it to become inconsistent with the inf= ormation >> =A0 =A0 stored in the hibernation image. >> >> =A0 =A0 The user-space-driven hibernation (s2disk) is not covered by= this >> =A0 =A0 change, because the freezing of filesystems prevents s2disk = from >> =A0 =A0 accessing device special files it needs to do its job. >> >> =A0 =A0 This change is based on earlier work by Nigel Cunningham. >> >> =A0 =A0 Signed-off-by: Rafael J. Wysocki >> >> =A0 =A0 Rebased to 3.3-rc3 by Josh Boyer Did this patch ever wind up going anywhere? Fedora has it sitting in our tree with a comment that says "rebase" and I don't see it in the linux-next tree at all. Did if fall through the cracks or was it NAKed somewhere? josh -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html