From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932966AbbBBNen (ORCPT ); Mon, 2 Feb 2015 08:34:43 -0500 Received: from mail-ob0-f179.google.com ([209.85.214.179]:36178 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754233AbbBBNem (ORCPT ); Mon, 2 Feb 2015 08:34:42 -0500 MIME-Version: 1.0 Date: Mon, 2 Feb 2015 08:34:41 -0500 X-Google-Sender-Auth: dNmWUxlWZpzDzLvMPtHih-Fh3Uc Message-ID: Subject: adjtimex EINVALs in 3.18.5 (and 3.19) From: Josh Boyer To: Sasha Levin , John Stultz Cc: "Linux-Kernel@Vger. Kernel. Org" , "stable@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sasha and John, As we rolled out 3.18.5 in Fedora, we've had a number of people complain about chrony no longer working when they reboot. It seems the calls to adjtimex chrony is making are failing, and then it fails to start. Looking at the changelog, I see "time: adjtimex: Validate the ADJ_FREQUENCY values" is in 3.18.5. Here is the log from one of the bugs[1]: Jan 31 08:33:17 elissa.gathman.org chronyd[722]: Frequency -35.554 +/- 1.838 ppm read from /var/lib/chrony/drift Jan 31 08:33:17 elissa.gathman.org chronyd[722]: Fatal error : adjtimex failed for set_frequency, freq_ppm=-3.5554e+01 required_freq=3.5554e+01 required_tick=10000 Jan 31 08:33:17 elissa.gathman.org chronyd[718]: adjtimex failed for set_frequency, freq_ppm=-3.5554e+01 required_freq=3.5554e+01 required_tick=10000 I have no idea if what it's trying to do is valid or not, but it definitely isn't happy. And that is kind of the crux of the issue. If those values are invalid now, what should these users do? Should they delete the drift file? All they know is that something that worked before doesn't. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1188074 josh