From: Josh Boyer <jwboyer@kernel.org>
To: ben@demerara.io
Cc: Jerome Pouiller <Jerome.Pouiller@silabs.com>,
Linux Wireless <linux-wireless@vger.kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
Linux Firmware <linux-firmware@kernel.org>,
devel@driverdev.osuosl.org, netdev <netdev@vger.kernel.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
jerome.pouiller@gmail.com
Subject: Re: [PATCH 2/3] wfx: add antenna configuration files
Date: Thu, 7 Jul 2022 13:40:27 -0400 [thread overview]
Message-ID: <CA+5PVA7F7-5GY=YE9rSL0ZYkAtiG+mi-gGyq6=65fpvBiqpe6Q@mail.gmail.com> (raw)
In-Reply-To: <cb49da01-584a-bb71-eecb-c54e40bce062@demerara.io>
On Thu, Jul 7, 2022 at 1:04 PM Ben Brown <ben@demerara.io> wrote:
>
> On 21/02/2022 16:37, Jerome Pouiller wrote:
> > From: Jérôme Pouiller <jerome.pouiller@silabs.com>
> <snip>
> > diff --git a/WHENCE b/WHENCE
> > index 0a6cb15..96f67f7 100644
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -5845,8 +5845,18 @@ Driver: wfx - Silicon Labs Wi-Fi Transceiver
> > File: wfx/wfm_wf200_C0.sec
> > Version: 3.12.1
> >
> > +File: wfx/brd4001a.pds not listed in WHENCE
> > +File: wfx/brd8022a.pds not listed in WHENCE
> > +File: wfx/brd8023a.pds not listed in WHENCE
>
> This format does not appear to be correct. While this will seemingly
> pass the `check_whence.py` check, it will be completely ignored by
> `copy-firmware.sh`, as that takes the full line after 'File: ' (e.g.
> 'wfx/brd4001a.pds not listed in WHENCE', which of course does not exist).
Oh, indeed.
> I'm assuming the trailing ' not listed in WHENCE' needs to be removed
> from each of these lines. Otherwise these are likely not being picked up
> by distros (they are missing from Arch, for example). This may have been
> the intention, but that seems odd (and unclear if so).
I doubt that was the intention. I'll correct WHENCE in a separate
commit. Thank you for reporting the issue.
josh
next prev parent reply other threads:[~2022-07-07 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 16:37 [PATCH 0/3] linux-firmware: update wfx Jerome Pouiller
2022-02-21 16:37 ` [PATCH 1/3] wfx: rename silabs/ into wfx/ Jerome Pouiller
2022-02-21 16:37 ` [PATCH 2/3] wfx: add antenna configuration files Jerome Pouiller
2022-07-07 17:04 ` Ben Brown
2022-07-07 17:40 ` Josh Boyer [this message]
2022-07-08 7:27 ` Jérôme Pouiller
2022-02-21 16:37 ` [PATCH 3/3] wfx: update to firmware 3.14 Jerome Pouiller
2022-02-24 20:20 ` [PATCH 0/3] linux-firmware: update wfx Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+5PVA7F7-5GY=YE9rSL0ZYkAtiG+mi-gGyq6=65fpvBiqpe6Q@mail.gmail.com' \
--to=jwboyer@kernel.org \
--cc=Jerome.Pouiller@silabs.com \
--cc=ben@demerara.io \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jerome.pouiller@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-firmware@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.