From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF9FAC43387 for ; Thu, 3 Jan 2019 17:35:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7EE20208E3 for ; Thu, 3 Jan 2019 17:35:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SDcqMCQR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732614AbfACRfW (ORCPT ); Thu, 3 Jan 2019 12:35:22 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:37445 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731831AbfACRfW (ORCPT ); Thu, 3 Jan 2019 12:35:22 -0500 Received: by mail-qt1-f196.google.com with SMTP id t33so37690754qtt.4; Thu, 03 Jan 2019 09:35:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=m0Kdi7xBjgPQg1KD4ifF0vqMDBe5DwAExOchMlsKCrU=; b=SDcqMCQRNX1PTTYu4g+6kWJInLw3cZ6KGstUtioosQ8sIZ0LT5i1uina6WB3asRReK F9+izMdXdlL4ppxbYfoaoMdZ2KQqhGV8wh4NuyNkgwt3RqgF1ZwsUsD1EWrLAqo+ScbB kk0dDX0CVHZQV5/Ghryuw89vKWSnJyvsasBYXHyapc6fqvB1UEn2ETFHT2gwplOoOswF 1P5dwtOiDv1nR8YV5/BNEL4yCIUKvGnx1KiIYqHNCpDM1l4DQEjjTSoMs84mQPcACOAe L7RV0Ui3qSigDY++Zs4tEIKhlM7cx4V4bvO2WeyFTgVcnxDIp/xGUdTEpDhN0uw6rLtk UJ9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=m0Kdi7xBjgPQg1KD4ifF0vqMDBe5DwAExOchMlsKCrU=; b=MT6NzIYkw+t6I5j6VvZ52jWLcBgDKsiAeIpvUx8fJN4l7rqgUCbxszz+17S53Zekr5 S0vAfmnAmbR5/5vgHTKb2MKpXOf22ylR7YInaDaaldrihdcXatV1Wg0a2w0O2Odxzyct 7rjcAC1GnjRXSemJ15b19/TB5btihCGN6GEL3bcbzPgRDzSwZ5DuO/cEIl9iC0llkbjq 0iwtMAJOj4Lnf+YbQx+xdUmTDJq1PN72e9LGVvE1p5aPkX6SJYyBHFDgQg5iQbRRZkHy oINxnzuwrQJeSxtYMElLUy05WjOIDk4UgxWk0DlIqPdF9L6l1UI8aM/dW0/PoK4VUC5U KywQ== X-Gm-Message-State: AJcUukeXOWmoXq6uwUBf1zDabgQIeFkiP851DRKlcyQEK+94w31DtUra H2NmFlRS8KQ+r7phS/6uUzgXUsf+lbaV6lytGSo= X-Google-Smtp-Source: AFSGD/XnJxO4NlcralXln8fOwuDG3rBEcH+iCSOoRmt35AbwvTII1lcqTDMKnV5oji7UfDuBkhvI32phyph+FXu+ub8= X-Received: by 2002:ac8:164a:: with SMTP id x10mr47624276qtk.67.1546536920554; Thu, 03 Jan 2019 09:35:20 -0800 (PST) MIME-Version: 1.0 References: <20181207190720.18517-1-hch@lst.de> <20181207190720.18517-3-hch@lst.de> <20190103072356.GA24163@lst.de> In-Reply-To: <20190103072356.GA24163@lst.de> From: Tony Luck Date: Thu, 3 Jan 2019 09:35:08 -0800 Message-ID: Subject: Re: [PATCH 02/15] swiotlb: remove dma_mark_clean To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, Linus Torvalds , Jesper Dangaard Brouer , Tariq Toukan , Ilias Apalodimas , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Robin Murphy , Konrad Rzeszutek Wilk , Fenghua Yu , Marek Szyprowski , Keith Busch , Jonathan Derrick , linux-pci@vger.kernel.org, "linux-ia64@vger.kernel.org" , X86-ML , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 2, 2019 at 11:23 PM Christoph Hellwig wrote: > I think something like the patch below should fix it: > > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > index ccd56f5df8cd..8d7396bd1790 100644 > --- a/arch/ia64/Kconfig > +++ b/arch/ia64/Kconfig > @@ -31,7 +31,7 @@ config IA64 > select HAVE_MEMBLOCK_NODE_MAP > select HAVE_VIRT_CPU_ACCOUNTING > select ARCH_HAS_DMA_COHERENT_TO_PFN if SWIOTLB > - select ARCH_HAS_SYNC_DMA_FOR_CPU > + select ARCH_HAS_SYNC_DMA_FOR_CPU if SWIOTLB Close. But no cigar. Now I get: CC arch/ia64/mm/init.o arch/ia64/mm/init.c:75:6: error: redefinition of =E2=80=98arch_sync_dma_for= _cpu=E2=80=99 ./include/linux/dma-noncoherent.h:61:20: note: previous definition of =E2=80=98arch_sync_dma_for_cpu=E2=80=99 was here make[1]: *** [arch/ia64/mm/init.o] Error 1 make: *** [arch/ia64/mm/init.o] Error 2 -Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Luck Subject: Re: [PATCH 02/15] swiotlb: remove dma_mark_clean Date: Thu, 3 Jan 2019 09:35:08 -0800 Message-ID: References: <20181207190720.18517-1-hch@lst.de> <20181207190720.18517-3-hch@lst.de> <20190103072356.GA24163@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190103072356.GA24163-jcswGhMUV9g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Christoph Hellwig Cc: Fenghua Yu , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , "linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Konrad Rzeszutek Wilk , Robin Murphy , Ilias Apalodimas , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, X86-ML , Linux Kernel Mailing List , Keith Busch , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Jesper Dangaard Brouer , Linus Torvalds , Jonathan Derrick , Tariq Toukan List-Id: iommu@lists.linux-foundation.org T24gV2VkLCBKYW4gMiwgMjAxOSBhdCAxMToyMyBQTSBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxz dC5kZT4gd3JvdGU6Cj4gSSB0aGluayBzb21ldGhpbmcgbGlrZSB0aGUgcGF0Y2ggYmVsb3cgc2hv dWxkIGZpeCBpdDoKPgo+IGRpZmYgLS1naXQgYS9hcmNoL2lhNjQvS2NvbmZpZyBiL2FyY2gvaWE2 NC9LY29uZmlnCj4gaW5kZXggY2NkNTZmNWRmOGNkLi44ZDczOTZiZDE3OTAgMTAwNjQ0Cj4gLS0t IGEvYXJjaC9pYTY0L0tjb25maWcKPiArKysgYi9hcmNoL2lhNjQvS2NvbmZpZwo+IEBAIC0zMSw3 ICszMSw3IEBAIGNvbmZpZyBJQTY0Cj4gICAgICAgICBzZWxlY3QgSEFWRV9NRU1CTE9DS19OT0RF X01BUAo+ICAgICAgICAgc2VsZWN0IEhBVkVfVklSVF9DUFVfQUNDT1VOVElORwo+ICAgICAgICAg c2VsZWN0IEFSQ0hfSEFTX0RNQV9DT0hFUkVOVF9UT19QRk4gaWYgU1dJT1RMQgo+IC0gICAgICAg c2VsZWN0IEFSQ0hfSEFTX1NZTkNfRE1BX0ZPUl9DUFUKPiArICAgICAgIHNlbGVjdCBBUkNIX0hB U19TWU5DX0RNQV9GT1JfQ1BVIGlmIFNXSU9UTEIKCkNsb3NlLiBCdXQgbm8gY2lnYXIuIE5vdyBJ IGdldDoKCiAgQ0MgICAgICBhcmNoL2lhNjQvbW0vaW5pdC5vCmFyY2gvaWE2NC9tbS9pbml0LmM6 NzU6NjogZXJyb3I6IHJlZGVmaW5pdGlvbiBvZiDigJhhcmNoX3N5bmNfZG1hX2Zvcl9jcHXigJkK Li9pbmNsdWRlL2xpbnV4L2RtYS1ub25jb2hlcmVudC5oOjYxOjIwOiBub3RlOiBwcmV2aW91cyBk ZWZpbml0aW9uIG9mCuKAmGFyY2hfc3luY19kbWFfZm9yX2NwdeKAmSB3YXMgaGVyZQptYWtlWzFd OiAqKiogW2FyY2gvaWE2NC9tbS9pbml0Lm9dIEVycm9yIDEKbWFrZTogKioqIFthcmNoL2lhNjQv bW0vaW5pdC5vXSBFcnJvciAyCgoKLVRvbnkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZv dW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Luck Date: Thu, 03 Jan 2019 17:35:08 +0000 Subject: Re: [PATCH 02/15] swiotlb: remove dma_mark_clean Message-Id: List-Id: References: <20181207190720.18517-1-hch@lst.de> <20181207190720.18517-3-hch@lst.de> <20190103072356.GA24163@lst.de> In-Reply-To: <20190103072356.GA24163@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, Linus Torvalds , Jesper Dangaard Brouer , Tariq Toukan , Ilias Apalodimas , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Robin Murphy , Konrad Rzeszutek Wilk , Fenghua Yu , Marek Szyprowski , Keith Busch , Jonathan Derrick , linux-pci@vger.kernel.org, "linux-ia64@vger.kernel.org" , X86-ML , Linux Kernel Mailing List On Wed, Jan 2, 2019 at 11:23 PM Christoph Hellwig wrote: > I think something like the patch below should fix it: > > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > index ccd56f5df8cd..8d7396bd1790 100644 > --- a/arch/ia64/Kconfig > +++ b/arch/ia64/Kconfig > @@ -31,7 +31,7 @@ config IA64 > select HAVE_MEMBLOCK_NODE_MAP > select HAVE_VIRT_CPU_ACCOUNTING > select ARCH_HAS_DMA_COHERENT_TO_PFN if SWIOTLB > - select ARCH_HAS_SYNC_DMA_FOR_CPU > + select ARCH_HAS_SYNC_DMA_FOR_CPU if SWIOTLB Close. But no cigar. Now I get: CC arch/ia64/mm/init.o arch/ia64/mm/init.c:75:6: error: redefinition of ‘arch_sync_dma_for_cpu’ ./include/linux/dma-noncoherent.h:61:20: note: previous definition of ‘arch_sync_dma_for_cpu’ was here make[1]: *** [arch/ia64/mm/init.o] Error 1 make: *** [arch/ia64/mm/init.o] Error 2 -Tony