From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.yoctoproject.org (mail.yoctoproject.org [198.145.29.25]) by mx.groups.io with SMTP id smtpd.web10.10766.1616754930998553777 for ; Fri, 26 Mar 2021 03:35:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@mvista-com.20150623.gappssmtp.com header.s=20150623 header.b=AlKnXRjt; spf=permerror, err=parse error for token &{10 18 _spf.google.com}: limit exceeded (domain: mvista.com, ip: 198.145.29.25, mailfrom: mshah@mvista.com) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by mail.yoctoproject.org (Postfix) with ESMTPS id D0BA138C06B9 for ; Fri, 26 Mar 2021 10:35:29 +0000 (UTC) Received: by mail-ej1-f49.google.com with SMTP id l4so7621265ejc.10 for ; Fri, 26 Mar 2021 03:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ki/NH6k+i5ZjmX6SvKr2Qz/7l1BBTkWP8OfI+eDPPss=; b=AlKnXRjtP5dKsj8mNz0NVifiymuc+ywNcOuQxzmh47IriIKZZeJZy3DyvitkzMO8yy HvxYipe+tvPAgKa5SMJZ7l3zaYcPSs/UP2htYvpmSV+dkpxjR1VM+Ibp5L/PZU0ybJQ5 byWEKPNUnjlZBG2hnOgCS96gTtxxjEfa02PgAIYh03qNJZyVL47U8LFehpKNa3gxpsNd BEj6ni8hNTQ0lTpIrNyKygjGcO5edAyQJuC4HKwUqUawUe4uwZQxaw2GFCkiHC982/Nc Oqa7xkDKVeMPdhU1CJCJ44QUbj7Ph4m7YIov3yFt1Fzt14InM1vuYnJDse1wI66wr6y/ p8fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ki/NH6k+i5ZjmX6SvKr2Qz/7l1BBTkWP8OfI+eDPPss=; b=ubsjhxN5Z/cWFxWcXHTYiJb1+YZCmo8Y6wOFUijQ67A3UY/gz+j3pgeUo7+oLtQCKu 6pfqnEFa1WCAztHEf1mW3xHST0Llkmv2AAFGGiWlrPxtdv/ytwEA52zaAIHpY88gRCG0 WNb/1il3CGFNyp8FHeAmLBk3WfV4y79vPXM5qwrZ9LDliYZ6QOBjZiJiVy1pmb5I3qc6 yvzk9wgbvTOsSSCzqDQcNYzp4PBMW7ibHLmEXpVyGiQ2geMk9ksjBUG7aswOlP4E/tOp 2f+KVM96kolxDm5g3BB4yB5eXG1dFHlGTr8gHC+wY17bN9t67ehK98DsuGpKvTfNuvXD qF9Q== X-Gm-Message-State: AOAM533j/jV3rJgoOQlOI4WnXK05nQwYNb0JOtdE7fB7VzQWqn5D/pGn pRgz8VXlQZ4RcAGc9Qstt2k6Ocv/kusIJSA/zw31G6JNbP/cm10p X-Google-Smtp-Source: ABdhPJygS230uoxyIgH9hUPln4Q2QoPH6AJogm11SQE6J344IbTHLhWvyQmIvrGqmKNXhLCqlL5y/CpT+qmZf9QTMTc= X-Received: by 2002:a17:906:81c9:: with SMTP id e9mr14307788ejx.456.1616754927957; Fri, 26 Mar 2021 03:35:27 -0700 (PDT) MIME-Version: 1.0 References: <1609940317-21943-1-git-send-email-mshah@mvista.com> In-Reply-To: From: "Milan Shah" Date: Fri, 26 Mar 2021 16:04:51 +0530 Message-ID: Subject: Re: [error-report-web][PATCH] report-error.bbclass: Add layer and bitbake version info to error report To: yocto@yoctoproject.org Cc: Richard Purdie , Paul Barker , Armin Kuster Content-Type: multipart/alternative; boundary="0000000000002b8a0d05be6e1726" --0000000000002b8a0d05be6e1726 Content-Type: text/plain; charset="UTF-8" Hi Richard, It seems like patches sent for *error-report-web* are not much important to the community as this patch has *not been reviewed/commented on* by anyone *since 6th January 2021* (*more than 2.5 months*). Still, I'm sending a reminder one last time for [*YOCTO #9700*]. https://lists.yoctoproject.org/g/yocto/message/51891 Please review/comment on it so that things can move further. Thanks & Regards, Milan Shah *Milan Shah* * | Software Engineer* *a: * MontaVista Software, LLC | Bangalore, India *e:* info@mvista.com | *w:* www.mvista.com/ *p:* +91-80-4939-5000 On Mon, Mar 15, 2021 at 4:36 PM Milan Shah wrote: > Hi, > > Review reminder for [YOCTO #9700]. > > https://lists.yoctoproject.org/g/yocto/message/51891 > > Thanks & Regards, > Milan Shah > > > *Milan Shah* * | Software Engineer* > *a: * MontaVista Software, LLC | Bangalore, India > *e:* info@mvista.com | *w:* www.mvista.com/ > *p:* +91-80-4939-5000 > > > On Tue, Feb 23, 2021 at 3:21 PM Milan Shah wrote: > >> Hi All, >> >> This has not been reviewed yet and it is given since January 6th. >> Please review it and provide review comments if any as soon as possible >> to resolve this issue. >> >> Thanks & Regards, >> Milan Shah >> >> >> *Milan Shah* * | Software Engineer* >> *a: * MontaVista Software, LLC | Bangalore, India >> *e:* info@mvista.com | *w:* www.mvista.com/ >> *p:* +91-80-4939-5000 >> >> >> On Mon, Feb 1, 2021 at 10:06 AM Milan Shah wrote: >> >>> Hi All, >>> >>> A gentle reminder to review this patch. >>> >>> ----------------------- >>> Thanks & Regards, >>> *Milan Shah* >>> MontaVista Software, Bangalore, India >>> >>> >>> On Mon, Jan 11, 2021 at 6:45 PM Milan Shah wrote: >>> >>>> Hi All, >>>> >>>> This is a Gentle Reminder to review this Patch. >>>> >>>> ----------------------- >>>> Thanks & Regards, >>>> *Milan Shah* >>>> MontaVista Software, Bangalore, India >>>> >>>> >>>> On Wed, Jan 6, 2021 at 7:09 PM Milan Shah wrote: >>>> >>>>> Instead of just providing local.conf info, add layer names and their >>>>> revisions with bitbake version information into error report >>>>> makes it easier to understand and reproduce failed build. >>>>> >>>>> [YOCTO #9700] >>>>> >>>>> Signed-off-by: Milan Shah >>>>> --- >>>>> meta/classes/report-error.bbclass | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/meta/classes/report-error.bbclass >>>>> b/meta/classes/report-error.bbclass >>>>> index 1a12db1..9cb6b0b 100644 >>>>> --- a/meta/classes/report-error.bbclass >>>>> +++ b/meta/classes/report-error.bbclass >>>>> @@ -6,6 +6,8 @@ >>>>> # >>>>> # Licensed under the MIT license, see COPYING.MIT for details >>>>> >>>>> +inherit base >>>>> + >>>>> ERR_REPORT_DIR ?= "${LOG_DIR}/error-report" >>>>> >>>>> def errorreport_getdata(e): >>>>> @@ -64,6 +66,8 @@ python errorreport_handler () { >>>>> data['failures'] = [] >>>>> data['component'] = " ".join(e.getPkgs()) >>>>> data['branch_commit'] = str(base_detect_branch(e.data)) + >>>>> ": " + str(base_detect_revision(e.data)) >>>>> + data['bitbake_version'] = e.data.getVar("BB_VERSION") >>>>> + data['layer_version'] = get_layers_branch_rev(e.data) >>>>> data['local_conf'] = get_conf_data(e, 'local.conf') >>>>> data['auto_conf'] = get_conf_data(e, 'auto.conf') >>>>> lock = bb.utils.lockfile(datafile + '.lock') >>>>> -- >>>>> 2.7.4 >>>>> >>>>> --0000000000002b8a0d05be6e1726 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Richard,

It seems like patches sent for error-report-we= b are not much important to the community as this patch has not been= reviewed/commented on by anyone since 6th January 2021 (more= than 2.5 months).

Still, I'm sending a reminder one last time f= or [YOCTO #9700].

Please review/comment on it so that things can move further.
=

Thanks & Regards,
Milan Shah

=20 =20
=20 =20 =20 =20
Milan Shah | Software Engineer
=20 a: MontaVista Software, LLC =20 | Bangalore, India =09 =09
e: info@mvista.com | w: www.mvista.com/ =20
=09 p: +91-80-4939-500= 0 =20



=
Hi All,
This is a Gentle Reminder to review this Patch.
=

-----------------------
Thanks & Regards,
<= font face=3D"times new roman, serif">Milan Shah
MontaVista Software, = Bangalore, India


=
On Wed, Jan 6, 2021 at 7:09 PM Milan = Shah <mshah@mvista= .com> wrote:
Instead of just providing local.conf info, add layer names and their revisions with bitbake version information into error report
makes it easier to understand and reproduce failed build.

[YOCTO #9700]

Signed-off-by: Milan Shah <mshah@mvista.com>
---
=C2=A0meta/classes/report-error.bbclass | 4 ++++
=C2=A01 file changed, 4 insertions(+)

diff --git a/meta/classes/report-error.bbclass b/meta/classes/report-error.= bbclass
index 1a12db1..9cb6b0b 100644
--- a/meta/classes/report-error.bbclass
+++ b/meta/classes/report-error.bbclass
@@ -6,6 +6,8 @@
=C2=A0#
=C2=A0# Licensed under the MIT license, see COPYING.MIT for details

+inherit base
+
=C2=A0ERR_REPORT_DIR ?=3D "${LOG_DIR}/error-report"

=C2=A0def errorreport_getdata(e):
@@ -64,6 +66,8 @@ python errorreport_handler () {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0data['failures'] = =3D []
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0data['component'] = =3D " ".join(e.getPkgs())
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0data['branch_commit'= ;] =3D str(base_detect_branch(e.data)) + ": " + str(base_detect_r= evision(e.data))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 data['bitbake_version'] = =3D e.data.getVar("BB_VERSION")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 data['layer_version'] = =3D get_layers_branch_rev(e.data)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0data['local_conf'] = =3D get_conf_data(e, 'local.conf')
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0data['auto_conf'] = =3D get_conf_data(e, 'auto.conf')
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lock =3D bb.utils.lockfile(= datafile + '.lock')
--
2.7.4

--0000000000002b8a0d05be6e1726--