All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Yakimov <root@livid.pp.ru>
To: "Gopal, Saranya" <saranya.gopal@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB: Fix configuration selection issues introduced in v4.20.0
Date: Wed, 6 Feb 2019 15:01:45 +0300	[thread overview]
Message-ID: <CA+A=rXE_4q1ioEFTD2iXcS3PLvErXVepZ+uQgj9UW6vKfozxqw@mail.gmail.com> (raw)
In-Reply-To: <C672AA6DAAC36042A98BAD0B0B25BDA94CB2885A@BGSMSX104.gar.corp.intel.com>

Hey there.

Sorry to nag, but it seems we came to the conclusion that there's
indeed a problem with the current code, and then collectively decided
that we're done. Can I do something to expedite this? Are there any
issues with my proposed patch? If there are, what can I do to fix
those? Alternatively, perhaps it would be easier/faster if a bona fide
kernel developer could fix problems described in this thread (well,
actually, I believe we're down to one somewhat pressing problem, which
could be fixed just by moving some code around)


On Thu, 17 Jan 2019 at 06:53, Gopal, Saranya <saranya.gopal@intel.com> wrote:
>
> > The result is this:
> > Before f13912d3f014a, if an RNDIS device has non-vendor-specific
> > configurations after the first one, that one would be selected.
> > After ff2a8c532c14, the first configuration would always be selected
> > for RNDIS devices. Besides, there are several redundant checks in this
> > case, which is, if nothing else, confusing.
> >
> > Hopefully I've explained my point clearly enough.
>
> Agreed. Thanks for pointing it out. I somehow missed this :(
>
> Thanks,
> Saranya

WARNING: multiple messages have this Message-ID (diff)
From: Nikolay Yakimov <root@livid.pp.ru>
To: "Gopal, Saranya" <saranya.gopal@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: USB: Fix configuration selection issues introduced in v4.20.0
Date: Wed, 6 Feb 2019 15:01:45 +0300	[thread overview]
Message-ID: <CA+A=rXE_4q1ioEFTD2iXcS3PLvErXVepZ+uQgj9UW6vKfozxqw@mail.gmail.com> (raw)

Hey there.

Sorry to nag, but it seems we came to the conclusion that there's
indeed a problem with the current code, and then collectively decided
that we're done. Can I do something to expedite this? Are there any
issues with my proposed patch? If there are, what can I do to fix
those? Alternatively, perhaps it would be easier/faster if a bona fide
kernel developer could fix problems described in this thread (well,
actually, I believe we're down to one somewhat pressing problem, which
could be fixed just by moving some code around)


On Thu, 17 Jan 2019 at 06:53, Gopal, Saranya <saranya.gopal@intel.com> wrote:
>
> > The result is this:
> > Before f13912d3f014a, if an RNDIS device has non-vendor-specific
> > configurations after the first one, that one would be selected.
> > After ff2a8c532c14, the first configuration would always be selected
> > for RNDIS devices. Besides, there are several redundant checks in this
> > case, which is, if nothing else, confusing.
> >
> > Hopefully I've explained my point clearly enough.
>
> Agreed. Thanks for pointing it out. I somehow missed this :(
>
> Thanks,
> Saranya

  reply	other threads:[~2019-02-06 12:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 16:13 [PATCH] USB: Fix configuration selection issues introduced in v4.20.0 Nikolay Yakimov
2019-01-15 16:13 ` Nikolay Yakimov
2019-01-15 16:40 ` [PATCH] " Greg Kroah-Hartman
2019-01-15 16:40   ` Greg Kroah-Hartman
2019-01-15 18:12   ` [PATCH] " Nikolay Yakimov
2019-01-15 18:12     ` Nikolay Yakimov
2019-01-16  4:24 ` [PATCH] " Gopal, Saranya
2019-01-16  4:24   ` saranya.gopal
2019-01-16 19:13   ` [PATCH] " Nikolay Yakimov
2019-01-16 19:13     ` Nikolay Yakimov
2019-01-17  3:53     ` [PATCH] " Gopal, Saranya
2019-01-17  3:53       ` saranya.gopal
2019-02-06 12:01       ` Nikolay Yakimov [this message]
2019-02-06 12:01         ` Nikolay Yakimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+A=rXE_4q1ioEFTD2iXcS3PLvErXVepZ+uQgj9UW6vKfozxqw@mail.gmail.com' \
    --to=root@livid.pp.ru \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=saranya.gopal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.