From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CFF4C43387 for ; Tue, 15 Jan 2019 18:13:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2109B20656 for ; Tue, 15 Jan 2019 18:13:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=livid.pp.ru header.i=@livid.pp.ru header.b="K2hrTzuW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388717AbfAOSNC (ORCPT ); Tue, 15 Jan 2019 13:13:02 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:32998 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729915AbfAOSNB (ORCPT ); Tue, 15 Jan 2019 13:13:01 -0500 Received: by mail-qt1-f196.google.com with SMTP id l11so4093316qtp.0 for ; Tue, 15 Jan 2019 10:13:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=livid.pp.ru; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7fh3j9YTLp5zq/6RCMt05XuE8kd5C9ljjnTVv39l0UY=; b=K2hrTzuWiiw9/GsKZPDctC/Ily+c6cHowNXs5HUTK3scENBL5yE+E7WbJHuRFuCJvD iuaMduOc7TITwFPCnG70ZDrnaIkSVcG9lhMFiyBUHxoer13wK0IuRjnkk4zd/2Xpz7u1 2g9L7dkMEUrBek1dydbihB0Q5rqyOhpITD2fk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7fh3j9YTLp5zq/6RCMt05XuE8kd5C9ljjnTVv39l0UY=; b=HdYfrJGALoVCgKuWXLwYteC9CV2oyhhnVHlY5DRHtvRweydPu7NxsuF4nzZKegXF/x 66sOyTbP+w53SXC5Pj7q7Re5IhTzMeNYZwJfHv0HRF/r6ecgdc4vuedDjS7uB6oWu2XZ AXD0FQikUXHg6IhBcj+iVDGHoOjRB3vYoVTgZ7u4kUDQhibewqnEOSGzBJGT0yXReaR9 hhxML36yXwpYltGRqMtUJEtT3yffuHqv2SdGjGJCibvizmtdjDokgJFPsUJX74wgA2I1 EP3ToL6nF2mD2N0nLF1rR8Kaj9H1F5etkI+BceObyugPTz9R1Nxl9WPgJZlzWkQxpkk3 HDhQ== X-Gm-Message-State: AJcUukeI5VlsUlfwZYZLC/fbNH9xlirVyM+gACanDHrNX3KDebiKf86K 4diPpIjylZimjvm3UerphU0XEuzfnHV9uxN9vIQzRQ== X-Google-Smtp-Source: ALg8bN7wT3YGy/oW9RyyRwlmpA9kVHM9pSG3n6XMfE3Ieymp7Vb7kQiCzYDKGjWWMhL/HAKQ72g1JarltOIFrQ97yR0= X-Received: by 2002:ac8:29b7:: with SMTP id 52mr3886420qts.266.1547575980547; Tue, 15 Jan 2019 10:13:00 -0800 (PST) MIME-Version: 1.0 References: <20190115161354.6806-1-root@livid.pp.ru> <20190115164016.GA25341@kroah.com> In-Reply-To: <20190115164016.GA25341@kroah.com> From: Nikolay Yakimov Date: Tue, 15 Jan 2019 21:12:49 +0300 Message-ID: Subject: Re: [PATCH] USB: Fix configuration selection issues introduced in v4.20.0 To: Greg Kroah-Hartman Cc: Saranya Gopal , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tue, 15 jan. 2019 at 19:53, Greg Kroah-Hartman : > Were you able to test this on one of the devices that ff2a8c532c14 > ("usbcore: Select only first configuration for non-UAC3 compliant > devices") was created to fix? Yes, owning such a device (non-UAC3 with multiple configurations) was the motivation for investigating in the first place (since it was broken on v4.20.0 and v4.20.1). So the proposed patch is tested against it. In fact, I only discovered ff2a8c532c14 ("usbcore: Select only first configuration for non-UAC3 compliant devices") when preparing to send in the patch (it's not in any released kernel yet) > > thanks, > > greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: Fix configuration selection issues introduced in v4.20.0 From: Nikolay Yakimov Message-Id: Date: Tue, 15 Jan 2019 21:12:49 +0300 To: Greg Kroah-Hartman Cc: Saranya Gopal , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: dHVlLCAxNSBqYW4uIDIwMTkgYXQgMTk6NTMsIEdyZWcgS3JvYWgtSGFydG1hbiA8Z3JlZ2toQGxp bnV4Zm91bmRhdGlvbi5vcmc+Ogo+IFdlcmUgeW91IGFibGUgdG8gdGVzdCB0aGlzIG9uIG9uZSBv ZiB0aGUgZGV2aWNlcyB0aGF0IGZmMmE4YzUzMmMxNAo+ICgidXNiY29yZTogU2VsZWN0IG9ubHkg Zmlyc3QgY29uZmlndXJhdGlvbiBmb3Igbm9uLVVBQzMgY29tcGxpYW50Cj4gZGV2aWNlcyIpIHdh cyBjcmVhdGVkIHRvIGZpeD8KClllcywgb3duaW5nIHN1Y2ggYSBkZXZpY2UgKG5vbi1VQUMzIHdp dGggbXVsdGlwbGUgY29uZmlndXJhdGlvbnMpIHdhcwp0aGUgbW90aXZhdGlvbiBmb3IgaW52ZXN0 aWdhdGluZyBpbiB0aGUgZmlyc3QgcGxhY2UgKHNpbmNlIGl0IHdhcwpicm9rZW4gb24gdjQuMjAu MCBhbmQgdjQuMjAuMSkuIFNvIHRoZSBwcm9wb3NlZCBwYXRjaCBpcyB0ZXN0ZWQKYWdhaW5zdCBp dC4KCkluIGZhY3QsIEkgb25seSBkaXNjb3ZlcmVkIGZmMmE4YzUzMmMxNCAoInVzYmNvcmU6IFNl bGVjdCBvbmx5IGZpcnN0CmNvbmZpZ3VyYXRpb24gZm9yIG5vbi1VQUMzIGNvbXBsaWFudCBkZXZp Y2VzIikgd2hlbiBwcmVwYXJpbmcgdG8gc2VuZAppbiB0aGUgcGF0Y2ggKGl0J3Mgbm90IGluIGFu eSByZWxlYXNlZCBrZXJuZWwgeWV0KQoKPgo+IHRoYW5rcywKPgo+IGdyZWcgay1oCg==