From: Brian Norris <briannorris@chromium.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Sandy Huang <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Vicente Bergas <vicencb@gmail.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Robin Murphy <robin.murphy@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Doug Anderson <dianders@chromium.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2] drm/rockchip: shutdown drm subsystem on shutdown
Date: Thu, 11 Apr 2019 18:54:04 -0700 [thread overview]
Message-ID: <CA+ASDXMRU_krasnMi3Z7ctwu3Pvza9hbLyOg6qNP7YJ5zRLVbw@mail.gmail.com> (raw)
In-Reply-To: <20190402113753.10118-1-heiko@sntech.de>
On Tue, Apr 2, 2019 at 4:38 AM Heiko Stuebner <heiko@sntech.de> wrote:
>
> From: Vicente Bergas <vicencb@gmail.com>
>
> As explained by Robin Murphy:
> > the IOMMU shutdown disables paging, so if the VOP is still
> > scanning out then that will result in whatever IOVAs it was using now going
> > straight out onto the bus as physical addresses.
>
> We had a more radical approach before in commit
> 7f3ef5dedb14 ("drm/rockchip: Allow driver to be shutdown on reboot/kexec")
> but that resulted in new warnings and oopses on shutdown on rk3399
> chromeos devices.
>
> So second try is resurrecting Vicentes shutdown change which should
> achieve the same result but in a less drastic way.
Works without complaints on RK3399 Scarlet devices:
Tested-by: Brian Norris <briannorris@chromium.org>
Can't vouch for kexec.
next prev parent reply other threads:[~2019-04-12 1:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 11:37 [PATCH v2] drm/rockchip: shutdown drm subsystem on shutdown Heiko Stuebner
2019-04-02 11:37 ` Heiko Stuebner
2019-04-12 1:54 ` Brian Norris [this message]
2019-04-12 17:43 ` Doug Anderson
2019-04-17 10:05 ` Marc Zyngier
2019-04-18 8:32 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+ASDXMRU_krasnMi3Z7ctwu3Pvza9hbLyOg6qNP7YJ5zRLVbw@mail.gmail.com \
--to=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.