From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BE71C43381 for ; Tue, 26 Mar 2019 00:49:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 382DB2075D for ; Tue, 26 Mar 2019 00:49:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="erHndOcm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731118AbfCZAt1 (ORCPT ); Mon, 25 Mar 2019 20:49:27 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:41794 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730837AbfCZAtY (ORCPT ); Mon, 25 Mar 2019 20:49:24 -0400 Received: by mail-lf1-f66.google.com with SMTP id 10so7368626lfr.8 for ; Mon, 25 Mar 2019 17:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OFP2jZU8cYxTAE12oUDWp0lSFiuDMdFVz8HpXQukEdA=; b=erHndOcm/9WDEIMAly50XEVIigCRogpN9KLIR+Nzbm/kXgpqJM/Wcr8p5b6IdZQgB9 oOHmjXBakMM8yUOeobBFKjBiTGkrDe9KgT6KuEihJN34ObiUnM4+F27uubFIp92Xj9tL IUP43vt9WHQ/gYFvjcYFwcFiU5DHNwc9Axv4c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OFP2jZU8cYxTAE12oUDWp0lSFiuDMdFVz8HpXQukEdA=; b=DZp2Yf4Me0NYoNryKlhbJR0+EWMBGQTz63PdruSQ9YwFQCuX/JmL1B8YdF8OdBsUDc M4+ed/R4BfQ/EKSqUnU/TmxPEZ/Gxy3K6eQ7cpfoMRxTvmjkxnREk4SK/VI1kZbzUKxa uH81lKGBv6QaET9bBSCmmMSXvgWXY34U+0OgN3nGe14vtxQ8gnrKJBa3gHvxmpXIN9oP ccBVnQ076mNR1magyRA+T+DQjG/sPnmf6yii1CpFQJwV5xFLqvh5joNOfovwiFItADxa 3Qh/yixUeRrPCUE9R48icwkLwY3Vycj1mCeCe+xeZroSqE07yu6E9ScOBBdeoP+NMYfO 2nTw== X-Gm-Message-State: APjAAAUEbEEQy4kIwYDOmk9TiW9FRMhNHeMGQzsvMZ1KFVPqL+mw7/ap aNITQJKvplKB2RyLZA2cpss35QziFUs= X-Google-Smtp-Source: APXvYqwTij+/5/kNj83sEC4qQHRRlzDf8yqwhlfz5/kwSJKCVH+q7psRCMNl3DufB1IFNUPfaDCfYQ== X-Received: by 2002:a19:9101:: with SMTP id t1mr774853lfd.165.1553561361189; Mon, 25 Mar 2019 17:49:21 -0700 (PDT) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com. [209.85.167.47]) by smtp.gmail.com with ESMTPSA id m19sm3674613lfb.78.2019.03.25.17.49.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 17:49:20 -0700 (PDT) Received: by mail-lf1-f47.google.com with SMTP id r25so7359147lfn.13 for ; Mon, 25 Mar 2019 17:49:19 -0700 (PDT) X-Received: by 2002:a19:4b14:: with SMTP id y20mr13438544lfa.36.1553561359526; Mon, 25 Mar 2019 17:49:19 -0700 (PDT) MIME-Version: 1.0 References: <20190306214730.6545-1-valleau@chromium.org> <44e151af-b6c4-d0af-3ef1-a5632d079915@kernel.org> <23918a77-2694-fdae-4300-0882c7c940cf@kernel.org> <20190326001353.GA4315@kroah.com> In-Reply-To: <20190326001353.GA4315@kroah.com> From: Brian Norris Date: Mon, 25 Mar 2019 17:49:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] tools: usb: usbip: adding support for older kernel versions To: Greg Kroah-Hartman Cc: shuah , David Valleau , LKML , Linux USB Mailing List , Michael Grzeschik , Valentina Manea , Sasha Levin Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On Mon, Mar 25, 2019 at 5:35 PM Greg Kroah-Hartman wrote: > 3.18 was released at the end of 2014, and as the tool that came with > that kernel still works just fine, you are just pushing the boundry here > really hard :) For some reason, we're focusing on 3.18, when the last breakage we're currently aware of was as recent as 4.13. So we (Chrom{ium,e} OS) also dealing with 4.4, which is still getting active LTS releases (thanks!) and is in heavy use. > Why do you want to update your userspace tool and not update your > kernel? What is forcing your userspace tool to be updated? I tried to downplay that part: we're primarily interested in finding some way to utilize the *same* tool on all kernels in question. It doesn't have to be the latest. But it's currently impossible, mostly due to commit 1c9de5bf4286 ("usbip: vhci-hcd: Add USB3 SuperSpeed support"). We also certainly have flexibility to hack things on our own and don't need upstream to care about everything we care about (e.g., sufficiently old kernels), but I did want to have this conversation at least, so that people are aware of the breakages they are making, and so we can understand what to expect. > Not to say that this shouldn't be fixed if at all possible, but realize > that this is not the "normal" case of "we do not break userspace" here, > given the tool involved, and the apis being used. I think I sort of understand what you're going for here, but can you elaborate so I don't have to assume? Thanks, Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: tools: usb: usbip: adding support for older kernel versions From: Brian Norris Message-Id: Date: Mon, 25 Mar 2019 17:49:07 -0700 To: Greg Kroah-Hartman Cc: shuah , David Valleau , LKML , Linux USB Mailing List , Michael Grzeschik , Valentina Manea , Sasha Levin List-ID: SGkgR3JlZywKCk9uIE1vbiwgTWFyIDI1LCAyMDE5IGF0IDU6MzUgUE0gR3JlZyBLcm9haC1IYXJ0 bWFuCjxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4gd3JvdGU6Cj4gMy4xOCB3YXMgcmVsZWFz ZWQgYXQgdGhlIGVuZCBvZiAyMDE0LCBhbmQgYXMgdGhlIHRvb2wgdGhhdCBjYW1lIHdpdGgKPiB0 aGF0IGtlcm5lbCBzdGlsbCB3b3JrcyBqdXN0IGZpbmUsIHlvdSBhcmUganVzdCBwdXNoaW5nIHRo ZSBib3VuZHJ5IGhlcmUKPiByZWFsbHkgaGFyZCA6KQoKRm9yIHNvbWUgcmVhc29uLCB3ZSdyZSBm b2N1c2luZyBvbiAzLjE4LCB3aGVuIHRoZSBsYXN0IGJyZWFrYWdlIHdlJ3JlCmN1cnJlbnRseSBh d2FyZSBvZiB3YXMgYXMgcmVjZW50IGFzIDQuMTMuIFNvIHdlIChDaHJvbXtpdW0sZX0gT1MpIGFs c28KZGVhbGluZyB3aXRoIDQuNCwgd2hpY2ggaXMgc3RpbGwgZ2V0dGluZyBhY3RpdmUgTFRTIHJl bGVhc2VzICh0aGFua3MhKQphbmQgaXMgaW4gaGVhdnkgdXNlLgoKPiBXaHkgZG8geW91IHdhbnQg dG8gdXBkYXRlIHlvdXIgdXNlcnNwYWNlIHRvb2wgYW5kIG5vdCB1cGRhdGUgeW91cgo+IGtlcm5l bD8gIFdoYXQgaXMgZm9yY2luZyB5b3VyIHVzZXJzcGFjZSB0b29sIHRvIGJlIHVwZGF0ZWQ/CgpJ IHRyaWVkIHRvIGRvd25wbGF5IHRoYXQgcGFydDogd2UncmUgcHJpbWFyaWx5IGludGVyZXN0ZWQg aW4gZmluZGluZwpzb21lIHdheSB0byB1dGlsaXplIHRoZSAqc2FtZSogdG9vbCBvbiBhbGwga2Vy bmVscyBpbiBxdWVzdGlvbi4gSXQKZG9lc24ndCBoYXZlIHRvIGJlIHRoZSBsYXRlc3QuIEJ1dCBp dCdzIGN1cnJlbnRseSBpbXBvc3NpYmxlLCBtb3N0bHkKZHVlIHRvIGNvbW1pdCAxYzlkZTViZjQy ODYgKCJ1c2JpcDogdmhjaS1oY2Q6IEFkZCBVU0IzIFN1cGVyU3BlZWQKc3VwcG9ydCIpLgoKV2Ug YWxzbyBjZXJ0YWlubHkgaGF2ZSBmbGV4aWJpbGl0eSB0byBoYWNrIHRoaW5ncyBvbiBvdXIgb3du IGFuZCBkb24ndApuZWVkIHVwc3RyZWFtIHRvIGNhcmUgYWJvdXQgZXZlcnl0aGluZyB3ZSBjYXJl IGFib3V0IChlLmcuLApzdWZmaWNpZW50bHkgb2xkIGtlcm5lbHMpLCBidXQgSSBkaWQgd2FudCB0 byBoYXZlIHRoaXMgY29udmVyc2F0aW9uIGF0CmxlYXN0LCBzbyB0aGF0IHBlb3BsZSBhcmUgYXdh cmUgb2YgdGhlIGJyZWFrYWdlcyB0aGV5IGFyZSBtYWtpbmcsIGFuZApzbyB3ZSBjYW4gdW5kZXJz dGFuZCB3aGF0IHRvIGV4cGVjdC4KCj4gTm90IHRvIHNheSB0aGF0IHRoaXMgc2hvdWxkbid0IGJl IGZpeGVkIGlmIGF0IGFsbCBwb3NzaWJsZSwgYnV0IHJlYWxpemUKPiB0aGF0IHRoaXMgaXMgbm90 IHRoZSAibm9ybWFsIiBjYXNlIG9mICJ3ZSBkbyBub3QgYnJlYWsgdXNlcnNwYWNlIiBoZXJlLAo+ IGdpdmVuIHRoZSB0b29sIGludm9sdmVkLCBhbmQgdGhlIGFwaXMgYmVpbmcgdXNlZC4KCkkgdGhp bmsgSSBzb3J0IG9mIHVuZGVyc3RhbmQgd2hhdCB5b3UncmUgZ29pbmcgZm9yIGhlcmUsIGJ1dCBj YW4geW91CmVsYWJvcmF0ZSBzbyBJIGRvbid0IGhhdmUgdG8gYXNzdW1lPwoKVGhhbmtzLApCcmlh bgo=