From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6682FC2D0F7 for ; Tue, 12 May 2020 16:57:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4668B206B9 for ; Tue, 12 May 2020 16:57:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="crUTI9DB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727882AbgELQ5G (ORCPT ); Tue, 12 May 2020 12:57:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbgELQ5F (ORCPT ); Tue, 12 May 2020 12:57:05 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 056C3C05BD09 for ; Tue, 12 May 2020 09:57:05 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id g1so8582684ljk.7 for ; Tue, 12 May 2020 09:57:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=soB2T7jMfJPtP5H3MNhiTe8IwYHJSi7NbmavIdokrOw=; b=crUTI9DBwo1cPu+KhFehaihTnypYtCw55ruTD7lVh8znQdy9XZk/8FGzr8uT3FK2iV hRIiPsNa753rxUMiEk5p3b5zJ6y4SQ9lMrHEh4BNB0f0LNwzwPRwYUux8eaG4K48fgZE QLAuHslKPqD8iz0uGuPmhKPpNIIpnqwyweDz4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=soB2T7jMfJPtP5H3MNhiTe8IwYHJSi7NbmavIdokrOw=; b=MWxVyfyTFKIJVE0PenmeY3aTFgdQ2+IRxjHvm243YkxK/7zaknj57fzdP+TMx8aPrO +MJPs7Ovy75F0eDJVyHNc45QsCzz3exDPya2znaYg3mVli6bVxYmajEOnu1zGaJhvvA8 1OHmozPykRc+YO8QwiT0+nQrljU4g7JBSqnsGoF0vL414NXbCS/Ah3ybUpRFrOPMAdwr o5nTD4Ux6aN25Puz1OPINkgnFt26DtYdA9FpWsEzxLoeV/9gSkRldL7hQfsRgOwLdnQO /8GIr78TvWL1TDBPrsyTiBHMqLUNCysaBOr3+Sa7lr10HefLlbfO0Q9/byvbM284A8Kk 1qtQ== X-Gm-Message-State: AOAM530wX2oR+S9aFKdDgOJBLicj9bi6hPbqnhVJC9UhHv2aMX27KvOB HwX6rEVlfBXQZIOwNqAtczKWWTNoEzY= X-Google-Smtp-Source: ABdhPJxjMPKMEoEeOkc76aMdTCkJRBiTRtsZm3lgTRQRVk13JaDceGvYGYEJ2n6PG4LvhMu8Jug2Uw== X-Received: by 2002:a05:651c:1131:: with SMTP id e17mr14987730ljo.79.1589302623060; Tue, 12 May 2020 09:57:03 -0700 (PDT) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id u12sm12985336ljo.102.2020.05.12.09.56.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2020 09:57:01 -0700 (PDT) Received: by mail-lf1-f41.google.com with SMTP id u4so11165423lfm.7 for ; Tue, 12 May 2020 09:56:59 -0700 (PDT) X-Received: by 2002:a19:5518:: with SMTP id n24mr15139341lfe.61.1589302618801; Tue, 12 May 2020 09:56:58 -0700 (PDT) MIME-Version: 1.0 References: <20190906185931.19288-1-navid.emamdoost@gmail.com> In-Reply-To: <20190906185931.19288-1-navid.emamdoost@gmail.com> From: Brian Norris Date: Tue, 12 May 2020 09:56:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ath9k: release allocated buffer if timed out To: Navid Emamdoost Cc: emamd001@umn.edu, smccaman@umn.edu, Kangjie Lu , QCA ath9k Development , Kalle Valo , "David S. Miller" , linux-wireless , "" , Linux Kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, Sep 6, 2019 at 11:59 AM Navid Emamdoost wrote: > > In ath9k_wmi_cmd, the allocated network buffer needs to be released > if timeout happens. Otherwise memory will be leaked. > > Signed-off-by: Navid Emamdoost I wonder, did you actually test your patches? I ask, because it seems that all your patches are of the same mechanical variety (produced by some sort of research project?), and if I look around a bit, I see several mistakes and regressions noted on your other patches. And recently, I see someone reporting a 5.4 kernel regression, which looks a lot like it was caused by this patch: https://bugzilla.kernel.org/show_bug.cgi?id=207703#c1 I'll propose a revert, if there's no evidence this was actually tested or otherwise confirmed to fix a real bug. Brian