From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25988C4361B for ; Wed, 9 Dec 2020 02:25:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF54D23A53 for ; Wed, 9 Dec 2020 02:25:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726636AbgLICYz (ORCPT ); Tue, 8 Dec 2020 21:24:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726603AbgLICYw (ORCPT ); Tue, 8 Dec 2020 21:24:52 -0500 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1D45C061793 for ; Tue, 8 Dec 2020 18:24:12 -0800 (PST) Received: by mail-ot1-x32d.google.com with SMTP id f16so748405otl.11 for ; Tue, 08 Dec 2020 18:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IVhVAzVlHgf5EMTYAVFmdMVuP6gKcxWiSjMj/6sCke8=; b=cbl78jlbGfxrmwvvVR4XsCQW2VJ7oTVc/EkwDAfq6YbJLJzep2vJLX6wSDa29R6UI0 cj6AEf4dUXmMTjFIkTgzvNihfdaHG0QKyTNW/BFR4ir7kFrH0Uspox+Z8FuiMWMpVWu0 gI4TPdsf7TfHSx4hfHM6I6Z26Z7jdWE5lFtL4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IVhVAzVlHgf5EMTYAVFmdMVuP6gKcxWiSjMj/6sCke8=; b=drGCTQGSKSUNDAxCdlisyUDoij94zGY8IMcL/NDxuvkklHcEiTG2SzxaN17jDKQYnM CLgpONdZUCPLk+79k7cO7lLp9fv1kSUK68PQ41h99s3e/ec1qlSaXSgF+zNkIaOfy+XZ 6omLz32y7EYQYAKtw/pgLU4ZZ94osZuzBs1oab7pM/zm2HR+XophCq1AerDzmyz1IdwD 8L6u//qkDP/imPEM/kLV59dqznB+cVmJ65DVEJDPaB0l7MiNVS6WUJgZYG67Z7dn84gk T8SK7IEnv0opsE68tj8ACalpQ9SWVXWe4Ppd/V3vRSZrPthRlsqkwu4QnAoWh35+5mvZ 6VLA== X-Gm-Message-State: AOAM533bPYWeM6P64R5s2SlPA4eI+65mKoVop3bldtFYmH33ESIuBtxb d462g6SKEJPNmGt26xrzmfKlVpzr8W065A== X-Google-Smtp-Source: ABdhPJxnkivwrnfaf5wZmYifgtcRpfT4rWocMeSFhA7gjF6+fz1TF3g/e3xz4vrpz4nAesmxccwRzA== X-Received: by 2002:a05:6830:1c3d:: with SMTP id f29mr40265ote.47.1607480651646; Tue, 08 Dec 2020 18:24:11 -0800 (PST) Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com. [209.85.167.178]) by smtp.gmail.com with ESMTPSA id p3sm85414otf.3.2020.12.08.18.24.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Dec 2020 18:24:10 -0800 (PST) Received: by mail-oi1-f178.google.com with SMTP id o25so158602oie.5 for ; Tue, 08 Dec 2020 18:24:09 -0800 (PST) X-Received: by 2002:aca:6502:: with SMTP id m2mr267037oim.105.1607480649316; Tue, 08 Dec 2020 18:24:09 -0800 (PST) MIME-Version: 1.0 References: <20201203185732.9CFA5C433ED@smtp.codeaurora.org> <20201204111715.04d5b198@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> <87tusxgar5.fsf@codeaurora.org> <20201207121029.77d48f2c@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: From: Brian Norris Date: Tue, 8 Dec 2020 18:23:57 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: pull-request: wireless-drivers-next-2020-12-03 To: Edward Cree Cc: Jakub Kicinski , Kalle Valo , "" , linux-wireless Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Dec 8, 2020 at 7:01 AM Edward Cree wrote: > My understanding is that it's because users can have them in their > modprobe.conf, which causes breakage if an update removes the param. > I think the module insert fails if there are unrecognised parameters > there. That's a nice understanding, but I believe it's an incorrect one: # echo 'options rtw88_pci doesnotexist=helloworld' >> /etc/modprobe.d/rtw.conf # modprobe rtw88_pci; echo $? 0 In fact, while I was already quite aware about the removal Jakub is highlighting (in the rtw88 driver), I was a user of the parameter, and was quite happy to see it die (because now the driver does the Right Thing automatically). I still left the option in my modprobe.conf, while I finished staging upgrades of all my systems. I ran into no problems, and now that the migration is done, I killed the modprobe.conf entry. Brian