From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E209C433F5 for ; Thu, 10 Mar 2022 23:50:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344933AbiCJXv0 (ORCPT ); Thu, 10 Mar 2022 18:51:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344975AbiCJXvW (ORCPT ); Thu, 10 Mar 2022 18:51:22 -0500 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7344A1A06CD for ; Thu, 10 Mar 2022 15:50:15 -0800 (PST) Received: by mail-oi1-x22e.google.com with SMTP id w127so7653158oig.10 for ; Thu, 10 Mar 2022 15:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qSs+OWs1rd3swR36O2vNgKkkBCsIMZuIXdZ0u3m8Xik=; b=ms4RRU4ZyttsdToiIH3Sv1ehttlkGOuaHMYlv/yrwCG7GfF7G7ADyQ3pLWcdiSPTLg /4ZHSGavGVyd5cosnBfTPmshSYtXWjyiVV/xQKK2e9sj3fJDlRx4IJ1FsJWQA/Kyuq76 pddpVo6STWfBplBRrZyUbSlTYnT84S1d69lbI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qSs+OWs1rd3swR36O2vNgKkkBCsIMZuIXdZ0u3m8Xik=; b=2Of1KdPPWIwOsDMp88wWGMojoGxugqOW0oT5Iq8TRqWogj5J5UXbiH68P8Z8IbjvKS JVyl+K6lG6UtYlwPLfIhseLfLm9jqU/fnE+J4aZzObs4h3PEsv1xKIBGvMI/2EgKOegr Z2LJKW0psC4e0mZRVS8T7vAZorF5V9c86Sm2Kwy2uO9stRgFjA3ft/kPBIXBJzy4o6iX WKFAk7PCdZW1E9bc0MO8t6uwPyD6ZCNQrs+IA+winm7S50Gb+W+S9AudW/b86h+xG4t9 2uwvCY/jrOQY2eyRKWkSJolslnQq2tXRlKYztkOSdegQ4yvQM0gt5cGP/lqUx50xwzcH ZXfg== X-Gm-Message-State: AOAM5326Mgaw/oslxc3Kt299GspH3JGrqeHFNGLRTs7Nggpo1W/dWxUE 43aTFi26yN8GtQbi52HAtR1x/McWJWizYQ== X-Google-Smtp-Source: ABdhPJwKYhe3mmNREo9RGWmpQ2m8OD5QfHadf2sdpdiJthhYbU4a17pT4iyQfTRhEqfE2LGVFEhidw== X-Received: by 2002:a05:6808:13cc:b0:2da:7639:aec8 with SMTP id d12-20020a05680813cc00b002da7639aec8mr2485506oiw.13.1646956214110; Thu, 10 Mar 2022 15:50:14 -0800 (PST) Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com. [209.85.161.54]) by smtp.gmail.com with ESMTPSA id t15-20020a056808158f00b002e331356c87sm211867oiw.39.2022.03.10.15.50.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Mar 2022 15:50:12 -0800 (PST) Received: by mail-oo1-f54.google.com with SMTP id l24-20020a4a8558000000b00320d5a1f938so8729762ooh.8 for ; Thu, 10 Mar 2022 15:50:11 -0800 (PST) X-Received: by 2002:a05:6870:b52c:b0:da:b3f:3273 with SMTP id v44-20020a056870b52c00b000da0b3f3273mr4139015oap.291.1646956211126; Thu, 10 Mar 2022 15:50:11 -0800 (PST) MIME-Version: 1.0 References: <20220228202532.869740-1-briannorris@chromium.org> In-Reply-To: <20220228202532.869740-1-briannorris@chromium.org> From: Brian Norris Date: Thu, 10 Mar 2022 15:50:00 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/2] drm/bridge: analogix_dp: Self-refresh state machine fixes To: Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Sean Paul Cc: dri-devel , Sean Paul , Jernej Skrabec , Laurent Pinchart , Jonas Karlman , Heiko Stuebner , Linux Kernel , Liu Ying , Doug Anderson Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 28, 2022 at 12:25 PM Brian Norris wrote: > > Hi, > > I've been investigating several eDP issues on a Rockchip RK3399 system > and have two proposed bugfixes. RK3399 has two CRTCs, either of which > can be used for eDP output. For both fixes, we have bugs due to the > relationship between the generalized "self refresh helpers" and the > analogix-dp bridge driver which controls much of the PSR mechanics. > These bugs are most visible when switching between CRTCs. > > I'm not a DRM expert, but I've been poking at a lot of Rockchip display > drivers recently. I'd love some skeptical eyes, so feel free to ask > questions if I haven't explained issues well, or the proposals look > fishy. > > Regards, > Brian Ping for review? Sean, perhaps? (You already reviewed this on the Chromium tracker.) Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E716CC433F5 for ; Thu, 10 Mar 2022 23:50:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 370E510E1E8; Thu, 10 Mar 2022 23:50:15 +0000 (UTC) Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0722210E1E8 for ; Thu, 10 Mar 2022 23:50:14 +0000 (UTC) Received: by mail-oo1-xc30.google.com with SMTP id 6-20020a4a0906000000b0031d7eb98d31so8712528ooa.10 for ; Thu, 10 Mar 2022 15:50:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qSs+OWs1rd3swR36O2vNgKkkBCsIMZuIXdZ0u3m8Xik=; b=ms4RRU4ZyttsdToiIH3Sv1ehttlkGOuaHMYlv/yrwCG7GfF7G7ADyQ3pLWcdiSPTLg /4ZHSGavGVyd5cosnBfTPmshSYtXWjyiVV/xQKK2e9sj3fJDlRx4IJ1FsJWQA/Kyuq76 pddpVo6STWfBplBRrZyUbSlTYnT84S1d69lbI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qSs+OWs1rd3swR36O2vNgKkkBCsIMZuIXdZ0u3m8Xik=; b=PTOthk3PvYYq/077kfffVLUyrW8OLA1Nk1TAHduWaN2uwbMWVxkNuFzUOy5ofQPlO3 1phkp8P30eC602ursniPC7gchBB658KhimdaU3W9bv2NnlWIgyRsdfXNJgR0OGpiL7ih r3V4EBIrpG8R1kb2x5yi02mpqCb5V0g51QyduYAJh3EBHlkBeQgbKUQjS9Jmw6CRD5XS YRZjg7HX0r4a9fHFXF9mQkcZnHJPD/XnpAzScXNF3voSoHU4rfNvyX3acFKRw2KkWdwN rbq69qOnciLw4ekcGnmgfiz2MyUTJaltPpj2FL0g6W8RSIqBsu2RQxrkugZo/WVZ54M0 SZlg== X-Gm-Message-State: AOAM531nQFCG1Xk/pDa7z6we+bG2pbOmNoPtxmWj+hqma9xeF403GTHa Vi9PrpiSQuOpYzB6F+z5jXCxynCI8vbl+g== X-Google-Smtp-Source: ABdhPJxZKwprkNDTy3755jnwhK/doR7WK1hKWi3JlPPWjqbz5WI4ABfiXLzXGec35kzmUz2o7EaxGQ== X-Received: by 2002:a05:6870:524f:b0:da:b3f:2b5e with SMTP id o15-20020a056870524f00b000da0b3f2b5emr9765973oai.253.1646956212833; Thu, 10 Mar 2022 15:50:12 -0800 (PST) Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com. [209.85.161.41]) by smtp.gmail.com with ESMTPSA id f17-20020a05680814d100b002da74126fc4sm1009644oiw.30.2022.03.10.15.50.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Mar 2022 15:50:11 -0800 (PST) Received: by mail-oo1-f41.google.com with SMTP id 6-20020a4a0906000000b0031d7eb98d31so8712432ooa.10 for ; Thu, 10 Mar 2022 15:50:11 -0800 (PST) X-Received: by 2002:a05:6870:b52c:b0:da:b3f:3273 with SMTP id v44-20020a056870b52c00b000da0b3f3273mr4139015oap.291.1646956211126; Thu, 10 Mar 2022 15:50:11 -0800 (PST) MIME-Version: 1.0 References: <20220228202532.869740-1-briannorris@chromium.org> In-Reply-To: <20220228202532.869740-1-briannorris@chromium.org> From: Brian Norris Date: Thu, 10 Mar 2022 15:50:00 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/2] drm/bridge: analogix_dp: Self-refresh state machine fixes To: Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Sean Paul Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Doug Anderson , Jonas Karlman , Linux Kernel , Jernej Skrabec , Liu Ying , Sean Paul , dri-devel , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 28, 2022 at 12:25 PM Brian Norris wrote: > > Hi, > > I've been investigating several eDP issues on a Rockchip RK3399 system > and have two proposed bugfixes. RK3399 has two CRTCs, either of which > can be used for eDP output. For both fixes, we have bugs due to the > relationship between the generalized "self refresh helpers" and the > analogix-dp bridge driver which controls much of the PSR mechanics. > These bugs are most visible when switching between CRTCs. > > I'm not a DRM expert, but I've been poking at a lot of Rockchip display > drivers recently. I'd love some skeptical eyes, so feel free to ask > questions if I haven't explained issues well, or the proposals look > fishy. > > Regards, > Brian Ping for review? Sean, perhaps? (You already reviewed this on the Chromium tracker.) Brian