From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B22C433E1 for ; Tue, 2 Jun 2020 18:36:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 550E920734 for ; Tue, 2 Jun 2020 18:36:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ErEmBwVZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726267AbgFBSgF (ORCPT ); Tue, 2 Jun 2020 14:36:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727863AbgFBSgC (ORCPT ); Tue, 2 Jun 2020 14:36:02 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B845EC08C5C1 for ; Tue, 2 Jun 2020 11:36:00 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id z18so13786288lji.12 for ; Tue, 02 Jun 2020 11:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ijFpZRjwoX99ihI6aAs0JBxKZ+/9IGA5AcjqDRRxjVE=; b=ErEmBwVZMzkC+6G17Sf/f4on+HIvZSZ8AKzHtw2WN/e8HA2YTsmF9nWW8KKw3DJLKe me5TqmdmNjfI5P78MUGsnW7a7Dii5HwIzqYhuYskjDyatp9sbSa71pmV8MU+CKmoKMWS kqSzc5ZAe9uDm/UNtKVFJjB4LyNBB/Ms7PbzE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ijFpZRjwoX99ihI6aAs0JBxKZ+/9IGA5AcjqDRRxjVE=; b=Rztzk3IHUG3mU5cnKZdU/07tIl/38X8jMR1nnn3VRfZPlKJCfEviyuufHBuC2l7fst +ldPc+i8tpwprEHeLEQ3Alco3THhmh7GrXBKDbyNZLceDURhQBirO/7T58p+2YC3Acfx EcECfORNXnbZEpCjMBQNwkHUai4DdSXKbKN/gDgtHTpDTz6QBSGJ8Kq5nqzgCTnqrFhy FxI6bCGsjFciSyArcYadD+6czdt2wN+yJDXgYT9hq7qeW1tTueaI1LSTnmIA/ls0Dynh +oGkqdhaSKkRUgfn92ZhOUaS7hPugiWIqWGMGyt/OLiydLmOsx2qU26IqL4iKrh5qbNV 0QDA== X-Gm-Message-State: AOAM530EDzd2RO2cFw8pqnh7/N9L8eumAR7bctHtm5KhGebuablRUilX KqtUzDgSn6huWCmdP3fYoLX/0xUaksc= X-Google-Smtp-Source: ABdhPJza250aaolGEI+UHWpPDVsaiDakUzRwGY7ZQp257vszX/18KYQ9DyAyCUbbPadYMsGhwAwWkg== X-Received: by 2002:a2e:968a:: with SMTP id q10mr211275lji.192.1591122958029; Tue, 02 Jun 2020 11:35:58 -0700 (PDT) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id u2sm690212lji.120.2020.06.02.11.35.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2020 11:35:56 -0700 (PDT) Received: by mail-lf1-f54.google.com with SMTP id c21so6794384lfb.3 for ; Tue, 02 Jun 2020 11:35:56 -0700 (PDT) X-Received: by 2002:a19:4acf:: with SMTP id x198mr353040lfa.129.1591122955826; Tue, 02 Jun 2020 11:35:55 -0700 (PDT) MIME-Version: 1.0 References: <20200527165718.129307-1-briannorris@chromium.org> In-Reply-To: From: Brian Norris Date: Tue, 2 Jun 2020 11:35:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Revert "ath: add support for special 0x0 regulatory domain" To: Adrian Chadd Cc: Julian Calaby , ath10k , linux-wireless , LKML , stable , Wen Gong Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, May 28, 2020 at 8:42 AM Adrian Chadd wrote: > On Thu, 28 May 2020 at 05:02, Julian Calaby wrote: > > On Thu, May 28, 2020 at 5:18 AM Brian Norris wrote: > > > > > > This reverts commit 2dc016599cfa9672a147528ca26d70c3654a5423. > > > > > > Users are reporting regressions in regulatory domain detection and > > > channel availability. > > > > > > The problem this was trying to resolve was fixed in firmware anyway: > > > > Should we tell the user their firmware needs to be upgraded if it > > reports this regulatory domain instead of completely dropping support > > for it? I'm not really sure how to do that properly in general, and I don't plan to do so. I'm simply reverting a change that caused people problems, and noting at the same time that the original problem was resolved differently. I don't really have a stake in this patch, because everything I care about works correctly either way. (And AFAICT, any hardware that is affected by this patch is somewhat broken.) I'm only posting the revert as a community service, because Wen couldn't be bothered to do it himself. > Also that commit mentioned a 6174 firmware, but what about all the other older chips with a regulatory domain of 0x0 ? My understanding was that no QCA modules *should* be shipped with a value of 0 in this field. The instance I'm aware of was more or less a manufacturing error I think, and we got Qualcomm to patch it over in software. I don't think people expected anybody else to have shipped modules with a 0 value, but apparently they did. I don't know what to do with those, other than just leave well enough alone (i.e., $subject revert). > As a side note, I'd /really appreciate/ if ath10k changes were tested on a variety of ath10k hardware and firmware revisions, rather than just either the Rome or embedded radios, rather than also including peregrine, cascade, besra, etc. Wouldn't we all love it if everybody else tested appropriately. But Qualcomm folks can't be coordinated (trust me, I've tried), and apart from things like KernelCI (which so far has no WiFi tests, IIUC), there's no community testing efforts that don't involve "${RANDOM_PERSON} boots ${PERSONAL_BOX} and see if it blows up." This also might not be the best place to admit it, but I'll be up front: I have no idea what peregrine, cascade, or besra are. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgBlY-0006xI-Oy for ath10k@lists.infradead.org; Tue, 02 Jun 2020 18:36:02 +0000 Received: by mail-lf1-x144.google.com with SMTP id z206so6791373lfc.6 for ; Tue, 02 Jun 2020 11:36:00 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id y9sm691293ljc.62.2020.06.02.11.35.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2020 11:35:56 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id w15so6764346lfe.11 for ; Tue, 02 Jun 2020 11:35:56 -0700 (PDT) MIME-Version: 1.0 References: <20200527165718.129307-1-briannorris@chromium.org> In-Reply-To: From: Brian Norris Date: Tue, 2 Jun 2020 11:35:43 -0700 Message-ID: Subject: Re: [PATCH] Revert "ath: add support for special 0x0 regulatory domain" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Adrian Chadd Cc: Julian Calaby , linux-wireless , LKML , stable , ath10k , Wen Gong On Thu, May 28, 2020 at 8:42 AM Adrian Chadd wrote: > On Thu, 28 May 2020 at 05:02, Julian Calaby wrote: > > On Thu, May 28, 2020 at 5:18 AM Brian Norris wrote: > > > > > > This reverts commit 2dc016599cfa9672a147528ca26d70c3654a5423. > > > > > > Users are reporting regressions in regulatory domain detection and > > > channel availability. > > > > > > The problem this was trying to resolve was fixed in firmware anyway: > > > > Should we tell the user their firmware needs to be upgraded if it > > reports this regulatory domain instead of completely dropping support > > for it? I'm not really sure how to do that properly in general, and I don't plan to do so. I'm simply reverting a change that caused people problems, and noting at the same time that the original problem was resolved differently. I don't really have a stake in this patch, because everything I care about works correctly either way. (And AFAICT, any hardware that is affected by this patch is somewhat broken.) I'm only posting the revert as a community service, because Wen couldn't be bothered to do it himself. > Also that commit mentioned a 6174 firmware, but what about all the other older chips with a regulatory domain of 0x0 ? My understanding was that no QCA modules *should* be shipped with a value of 0 in this field. The instance I'm aware of was more or less a manufacturing error I think, and we got Qualcomm to patch it over in software. I don't think people expected anybody else to have shipped modules with a 0 value, but apparently they did. I don't know what to do with those, other than just leave well enough alone (i.e., $subject revert). > As a side note, I'd /really appreciate/ if ath10k changes were tested on a variety of ath10k hardware and firmware revisions, rather than just either the Rome or embedded radios, rather than also including peregrine, cascade, besra, etc. Wouldn't we all love it if everybody else tested appropriately. But Qualcomm folks can't be coordinated (trust me, I've tried), and apart from things like KernelCI (which so far has no WiFi tests, IIUC), there's no community testing efforts that don't involve "${RANDOM_PERSON} boots ${PERSONAL_BOX} and see if it blows up." This also might not be the best place to admit it, but I'll be up front: I have no idea what peregrine, cascade, or besra are. Brian _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k