From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F23C4320A for ; Fri, 20 Aug 2021 21:16:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 852FB61102 for ; Fri, 20 Aug 2021 21:16:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240624AbhHTVRP (ORCPT ); Fri, 20 Aug 2021 17:17:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231200AbhHTVRO (ORCPT ); Fri, 20 Aug 2021 17:17:14 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DE74C061575 for ; Fri, 20 Aug 2021 14:16:36 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id i3-20020a056830210300b0051af5666070so7283943otc.4 for ; Fri, 20 Aug 2021 14:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JK5qp9aGPwlk30xRI3qcWwl4gv4KOP1fwY03JpC1sQc=; b=JybGeEAWGaaSntO3R2lT7WUj35AygFj+itlN16mJYpO0OvjZL4KqEBkfiQp4PGz5Mh IrMNHPoa3RsBgJOm5bzBRMyg06657LdqdM3qiOSs3QY6vOx/NvESZuyoce2FByz4HnNL 1gZiAXesklldc7Jy2N/XS7I1aWhbJKnHGm2DE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JK5qp9aGPwlk30xRI3qcWwl4gv4KOP1fwY03JpC1sQc=; b=DM2Qa84PnT2pXRNazZw+uwR/bnIJMCpnG4CCamA3hsuo0ul4uOqaLQfPMe8lvhysdd OEvoZGRO8oEI6wimgwaN+CexLin46HUGxaz+iPTvJT3mmpjy/yjdRYlc7Een3RB4PVld shf2fO8r2zqiL3KXDaxG0lK8UmdFyWSO6EqPSw/FxSI1mzSqUyWqqe0/W1wgQzf64GSw pB/p43iXFRJ9dT/i+ExjBbxUR7Mhpr0TbjDM8/nvD6lQx1k84crON+DbV6v38UGLjPII He9HRZQ8zc/85QiJw0xTRmmJCr9SaIN0ZzbkpGWtSIGWUP4idcKcqS0Fglnl+Tpy+kAZ AYCQ== X-Gm-Message-State: AOAM531IcH6L7bH+9VfgrxM2VCwbZzEihW0ha28G3e9VP74RN1RPhL7U j6CEnMIwLjVtIJXV/TVt12EFmZmz4tZLVA== X-Google-Smtp-Source: ABdhPJxcjIIfBt68RCdyoLtPe3vpSkbRQcqqGGabaxJAkye1SeD0qjjY+q7i9KoyufXMgo/+baRwSw== X-Received: by 2002:a9d:309:: with SMTP id 9mr18771017otv.365.1629494195304; Fri, 20 Aug 2021 14:16:35 -0700 (PDT) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com. [209.85.210.48]) by smtp.gmail.com with ESMTPSA id z78sm1531324ooa.29.2021.08.20.14.16.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Aug 2021 14:16:34 -0700 (PDT) Received: by mail-ot1-f48.google.com with SMTP id h63-20020a9d14450000b02904ce97efee36so16974503oth.7 for ; Fri, 20 Aug 2021 14:16:34 -0700 (PDT) X-Received: by 2002:a9d:309:: with SMTP id 9mr18770960otv.365.1629494194200; Fri, 20 Aug 2021 14:16:34 -0700 (PDT) MIME-Version: 1.0 References: <20210820133829.1.Ica46f428de8c3beb600760dbcd63cf879ec24baf@changeid> In-Reply-To: From: Brian Norris Date: Fri, 20 Aug 2021 14:16:23 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: rockchip: add RK3399 Gru gpio-line-names To: Doug Anderson Cc: Heiko Stuebner , Linux ARM , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:ARM/Rockchip SoC..." Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 20, 2021 at 2:05 PM Doug Anderson wrote: > I guess one minor nit (now that I look back on the veyron patch where > I mentioned it explicitly in the commit message) is that on the veyron > ones we sorted this down at the bottom with the other pinctrl stuff > instead of sorting it alphabetically with everything else. I'll let > Heiko say which he likes better. Huh, didn't notice that semi-convention. I can sort it however Heiko prefers. > I also notice for veyron that we had a second "ABI" exception for the > recovery mode pin, but I believe that goes through a different > mechanism now so we're good there. I believe the recovery mode pin is dropped from recent designs (don't quote me in general on that), and there's a different mechanism used just to get the at-boot-time "recovery mode" state directly from the firmware. > Even though I didn't do a line-by-line review, I'll still give: > > Reviewed-by: Douglas Anderson > > ...though it's possible an "Acked-by" would be more in the spirit of > that? Not sure... Thanks! Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B1FEC4338F for ; Fri, 20 Aug 2021 21:16:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2ED761102 for ; Fri, 20 Aug 2021 21:16:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F2ED761102 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cWIhX0QDXiUKTOd8p/4EvmD5GEtHYtOR8xjwTaSdSXU=; b=zDtEfVFK6Ev+B7 UHO6gN3rwyRKZXPeOBueGbg1VGd2IwfzPWmR+pBVoXfEgg/2JJ5OO1Q5l/WhQZ5RU3FCfHPswxNjT oGj7wPKb8BTCClnp8ty54Bc6aLvFHb2gAMGzEhtrRbYjQUEU9rt5hm9kJmlHTQAZodtIubU/ssqEs bFZv7P4mb3r8yppwb3PWxaErMG9sMzX2zK/jHa2qXy+EqqDoANRVcFzqvECjVmpHOq0FMc5e78ayF 9EYMcwpaDX5T4EB1G5FPSLqqJb+pdeRPEcVWsIXZu7wVxFwgusW0fc+XT+SRlk/H8+cJc69RmX2EK gT4t0/GzJJhC/9Ta0v1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHBsZ-00C7r2-A1; Fri, 20 Aug 2021 21:16:43 +0000 Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHBsT-00C7pv-S9 for linux-rockchip@lists.infradead.org; Fri, 20 Aug 2021 21:16:41 +0000 Received: by mail-ot1-x336.google.com with SMTP id g66-20020a9d12c8000000b0051aeba607f1so8521126otg.11 for ; Fri, 20 Aug 2021 14:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JK5qp9aGPwlk30xRI3qcWwl4gv4KOP1fwY03JpC1sQc=; b=JybGeEAWGaaSntO3R2lT7WUj35AygFj+itlN16mJYpO0OvjZL4KqEBkfiQp4PGz5Mh IrMNHPoa3RsBgJOm5bzBRMyg06657LdqdM3qiOSs3QY6vOx/NvESZuyoce2FByz4HnNL 1gZiAXesklldc7Jy2N/XS7I1aWhbJKnHGm2DE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JK5qp9aGPwlk30xRI3qcWwl4gv4KOP1fwY03JpC1sQc=; b=df3LSe6f5ttY88j+0nQvKrg89nZzoLHhCisCH3V6ZrnIh9oE/kD+vlwJXPkPhS1ayY 0xLILA3G3PwtbL1OzBt7e7aZBlQndfGxD8M4jiCaveLUI8rdZ3mvqk2FRf1QuKWojEBA WNq6QvTdux9Dmf0xv4XIdDkw2xRfvQIz7egLL7LAnup4izR/rK4oKSt/EY+E5eChAE/d 84x3l+GkYDYOt34imDFqBkKu7t/scianUR49HmkER9WrW9Ou42bhcKrwG7MtNtqzthb+ zimu7BQMZtWhNSNQVCeXnDeXPaIly0H9e2u4Vd4S+kbCASLP4LtbgZE+dT/44V039bBJ TZng== X-Gm-Message-State: AOAM530G9ew9yxvJ++svhX8P0hgnC2WfYhBp+vZ5QfR4HnboPrsG+9Z8 pgNNW5Vd+48rPU82h6IzVowK7br4n6NNrw== X-Google-Smtp-Source: ABdhPJwZQZybD6+/hUy7hqdtE+4M47ySUmdZfLjT1bqQm611c/X9grjI99mY0IefW0ex1CzhR3HKxg== X-Received: by 2002:aca:1c13:: with SMTP id c19mr4233532oic.93.1629494195270; Fri, 20 Aug 2021 14:16:35 -0700 (PDT) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com. [209.85.210.50]) by smtp.gmail.com with ESMTPSA id x198sm1540475ooa.43.2021.08.20.14.16.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Aug 2021 14:16:34 -0700 (PDT) Received: by mail-ot1-f50.google.com with SMTP id r38-20020a05683044a600b0051a2c6dd421so17013754otv.3 for ; Fri, 20 Aug 2021 14:16:34 -0700 (PDT) X-Received: by 2002:a9d:309:: with SMTP id 9mr18770960otv.365.1629494194200; Fri, 20 Aug 2021 14:16:34 -0700 (PDT) MIME-Version: 1.0 References: <20210820133829.1.Ica46f428de8c3beb600760dbcd63cf879ec24baf@changeid> In-Reply-To: From: Brian Norris Date: Fri, 20 Aug 2021 14:16:23 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: rockchip: add RK3399 Gru gpio-line-names To: Doug Anderson Cc: Heiko Stuebner , Linux ARM , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:ARM/Rockchip SoC..." X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210820_141637_960665_11946BCD X-CRM114-Status: GOOD ( 14.75 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Aug 20, 2021 at 2:05 PM Doug Anderson wrote: > I guess one minor nit (now that I look back on the veyron patch where > I mentioned it explicitly in the commit message) is that on the veyron > ones we sorted this down at the bottom with the other pinctrl stuff > instead of sorting it alphabetically with everything else. I'll let > Heiko say which he likes better. Huh, didn't notice that semi-convention. I can sort it however Heiko prefers. > I also notice for veyron that we had a second "ABI" exception for the > recovery mode pin, but I believe that goes through a different > mechanism now so we're good there. I believe the recovery mode pin is dropped from recent designs (don't quote me in general on that), and there's a different mechanism used just to get the at-boot-time "recovery mode" state directly from the firmware. > Even though I didn't do a line-by-line review, I'll still give: > > Reviewed-by: Douglas Anderson > > ...though it's possible an "Acked-by" would be more in the spirit of > that? Not sure... Thanks! Brian _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E477C4338F for ; Fri, 20 Aug 2021 21:18:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BBD96108B for ; Fri, 20 Aug 2021 21:18:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1BBD96108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PDJqhG6A54Zw6h9uzxuMl4UvVbsK4w5ADwQp2zFB1h0=; b=1KcXDD7ukSEZzf FZ+JjzhzbP57gmEOewFv5n3Uks80SK7ZLYG1jSskcwNPmcklYOnrst6MsxN8mEFKGkVaKE5/hSTqe FAS1QEfjA+/n7BHZQT0pKkpHUnt9s2XJpRq8PfUop3Aid4GVBLgk+o1WbzHBFSsFI+HFxQxhx5Coc 7Om/oQ6etzupK2MZZdLr8dOA4Lo0DHpzAvFGCz3Q3oUdQm1AplkRKEx4MI6kjkacAOaJUGOn9X12N Gvu5BYqUKF/lRTBwvdxfpTG4CLJ3HCnpjd3K6Y2buAfu/qMX7TTjPn1n81cFm3cyvNVXBhOEAU7S8 O/PQNMrtpfO8rwjD/jEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHBsa-00C7r7-Qs; Fri, 20 Aug 2021 21:16:45 +0000 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHBsT-00C7pw-TD for linux-arm-kernel@lists.infradead.org; Fri, 20 Aug 2021 21:16:41 +0000 Received: by mail-ot1-x32a.google.com with SMTP id g66-20020a9d12c8000000b0051aeba607f1so8521166otg.11 for ; Fri, 20 Aug 2021 14:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JK5qp9aGPwlk30xRI3qcWwl4gv4KOP1fwY03JpC1sQc=; b=JybGeEAWGaaSntO3R2lT7WUj35AygFj+itlN16mJYpO0OvjZL4KqEBkfiQp4PGz5Mh IrMNHPoa3RsBgJOm5bzBRMyg06657LdqdM3qiOSs3QY6vOx/NvESZuyoce2FByz4HnNL 1gZiAXesklldc7Jy2N/XS7I1aWhbJKnHGm2DE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JK5qp9aGPwlk30xRI3qcWwl4gv4KOP1fwY03JpC1sQc=; b=ugooiGosoi1dyEMD+57iFNR8tHQn9D2PSp/Co+SU2zxd8DQ5QPWfN/2x1AUAMYL/9i DOfsJN2IhyEBCLPr/gseC3MOYOuih0Lr9JDz1XXQM+fbyGcgS4OnfWTnb9QsKNPNK/i8 KozIOIAH71+UzOlRgHw89aqYUXGc64FZGa22OSv4ENmBOh5oSijQdAt4asQYOwhDhL8W pk6U3+tNjS+z5sV0gxw1CAYdRWoE+LSvsC4RxSTCLREQJc7WftsdzmKkCOGuQztYe9tn iA20lcwt//Xkirty2ozD3PnZ8NtMUaQcEJPWZdyyi2t2dHBv2qUb3iuiw0Og52MbIRNo YSjg== X-Gm-Message-State: AOAM531Q9J4d5Y9ddr4Zmx69WdfVC9+Hn3bceLiu+dsCpkQOMCGSQVE+ WUDup3yDTqSyae6I8Ig2cLU99I7HNREUmw== X-Google-Smtp-Source: ABdhPJxUew1hG0kdEW/ZHNVfBjsnqza+n3nsZDtiDMDEjP4ki/9R2ByWbQ1KVFBnuoLyqMlhJEd2yg== X-Received: by 2002:a9d:5e0b:: with SMTP id d11mr19011820oti.371.1629494195399; Fri, 20 Aug 2021 14:16:35 -0700 (PDT) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com. [209.85.210.50]) by smtp.gmail.com with ESMTPSA id h19sm1734032otr.75.2021.08.20.14.16.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Aug 2021 14:16:34 -0700 (PDT) Received: by mail-ot1-f50.google.com with SMTP id o16-20020a9d2210000000b0051b1e56c98fso2184943ota.8 for ; Fri, 20 Aug 2021 14:16:34 -0700 (PDT) X-Received: by 2002:a9d:309:: with SMTP id 9mr18770960otv.365.1629494194200; Fri, 20 Aug 2021 14:16:34 -0700 (PDT) MIME-Version: 1.0 References: <20210820133829.1.Ica46f428de8c3beb600760dbcd63cf879ec24baf@changeid> In-Reply-To: From: Brian Norris Date: Fri, 20 Aug 2021 14:16:23 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: rockchip: add RK3399 Gru gpio-line-names To: Doug Anderson Cc: Heiko Stuebner , Linux ARM , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:ARM/Rockchip SoC..." X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210820_141637_986171_98954B21 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 20, 2021 at 2:05 PM Doug Anderson wrote: > I guess one minor nit (now that I look back on the veyron patch where > I mentioned it explicitly in the commit message) is that on the veyron > ones we sorted this down at the bottom with the other pinctrl stuff > instead of sorting it alphabetically with everything else. I'll let > Heiko say which he likes better. Huh, didn't notice that semi-convention. I can sort it however Heiko prefers. > I also notice for veyron that we had a second "ABI" exception for the > recovery mode pin, but I believe that goes through a different > mechanism now so we're good there. I believe the recovery mode pin is dropped from recent designs (don't quote me in general on that), and there's a different mechanism used just to get the at-boot-time "recovery mode" state directly from the firmware. > Even though I didn't do a line-by-line review, I'll still give: > > Reviewed-by: Douglas Anderson > > ...though it's possible an "Acked-by" would be more in the spirit of > that? Not sure... Thanks! Brian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel