From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E673C433DF for ; Thu, 21 May 2020 19:01:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 197B7207D3 for ; Thu, 21 May 2020 19:01:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CmUCxNDg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729676AbgEUTBc (ORCPT ); Thu, 21 May 2020 15:01:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729548AbgEUTBc (ORCPT ); Thu, 21 May 2020 15:01:32 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2B21C061A0E for ; Thu, 21 May 2020 12:01:31 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id z18so9581390lji.12 for ; Thu, 21 May 2020 12:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OsSPUhpJYq73nfHib5c1j0os+u2XY4uTeNRmqrqb5mQ=; b=CmUCxNDgIi9qt6Q51kYVv8cFYZP4VEdLcAfjYqxn2qIZvUtue5c2fyvygZREGpwI/I tJb6hl3rKHFKaoBTMP89eAd5lK/gvCB5918Ju881W2CrP4VbdppU15ZViA7z5qhRr6EA 1NvHnsGrU68uXBlLj/C1Oi49N91W+p2BZiJQU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OsSPUhpJYq73nfHib5c1j0os+u2XY4uTeNRmqrqb5mQ=; b=DOFVq6BTyrHqlraWGtJJ62RoDxWWqpAM7izCZaSter81kkd24MnVP7bBydBfDI66Oh yxGelgB9LnAhJmB+ztZNFpJ0k6aG3EXplmEX9QXvx6Pa71gigbxVhxzxYnCM3AOUnynf SomyfRUQn8IFjFtK/3qVH61EzGB2fLA2Ly+UCxCx9hzWKQCQaF7O+kNKOKsBDGf7abUZ 4MAwrjpHR+5pFSJVBfex0dQ0n4hn7vTLDV/smq/5EzMp0xFwrStRsc6iYnbJWaZVpzAP Z0IOHysJzIC9SmnrAnlMTfCRgNhv5NHro030N4ixVSFu5AyFFCr2C474VtbIyxVyBdym s4xQ== X-Gm-Message-State: AOAM532i7nOKElpyQCZ2HiVXZNDaaoNZEL9vCAnn4hgnx1Iyrv2d6j43 6sO27WhJMk4Z2nTASDx4mvwMA2uGUS4= X-Google-Smtp-Source: ABdhPJx92nMZ1PNOQIFfMQ1QYAjpjZ1HP8KszE9oSxRcnxV0w0ddIXR2ynkgRAcejS/QTwU8U87xMg== X-Received: by 2002:a2e:8090:: with SMTP id i16mr3260338ljg.421.1590087689067; Thu, 21 May 2020 12:01:29 -0700 (PDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id n26sm614788ljc.42.2020.05.21.12.01.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2020 12:01:27 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id k5so9600868lji.11 for ; Thu, 21 May 2020 12:01:27 -0700 (PDT) X-Received: by 2002:a2e:9896:: with SMTP id b22mr5475234ljj.276.1590087687179; Thu, 21 May 2020 12:01:27 -0700 (PDT) MIME-Version: 1.0 References: <20200515212846.1347-1-mcgrof@kernel.org> <20200515212846.1347-13-mcgrof@kernel.org> <2b74a35c726e451b2fab2b5d0d301e80d1f4cdc7.camel@sipsolutions.net> <7306323c35e6f44d7c569e689b48f380f80da5e5.camel@sipsolutions.net> <20200519140212.GT11244@42.do-not-panic.com> In-Reply-To: From: Brian Norris Date: Thu, 21 May 2020 12:01:14 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed() To: Emmanuel Grumbach Cc: Luis Chamberlain , Johannes Berg , linux-wireless , aquini@redhat.com, peterz@infradead.org, Daniel Vetter , mchehab+samsung@kernel.org, will@kernel.org, bhe@redhat.com, ath10k@lists.infradead.org, Takashi Iwai , mingo@redhat.com, dyoung@redhat.com, pmladek@suse.com, Kees Cook , Arnd Bergmann , gpiccoli@canonical.com, Steven Rostedt , cai@lca.pw, tglx@linutronix.de, Andy Shevchenko , Kalle Valo , "" , schlad@suse.de, Linux Kernel , jeyu@kernel.org, Andrew Morton , "David S. Miller" Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, May 19, 2020 at 10:37 PM Emmanuel Grumbach wrote: > So I believe we already have this uevent, it is the devcoredump. All > we need is to add the unique id. I think there are a few reasons that devcoredump doesn't satisfy what either Luis or I want. 1) it can be disabled entirely [1], for good reasons (e.g., think of non-${CHIP_VENDOR} folks, who can't (and don't want to) do anything with the opaque dumps provided by closed-source firmware) 2) not all drivers necessarily have a useful dump to provide when there's a crash; look at the rest of Luis's series to see the kinds of drivers-with-firmware that are crashing, some of which aren't dumping anything 3) for those that do support devcoredump, it may be used for purposes that are not "crashes" -- e.g., some provide debugfs or other knobs to initiate dumps, for diagnostic or debugging purposes Brian [1] devcd_disabled https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/devcoredump.c?h=v5.6#n22 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbqZP-0005Ui-Id for ath10k@lists.infradead.org; Thu, 21 May 2020 19:09:33 +0000 Received: by mail-ed1-x542.google.com with SMTP id g9so7434429edr.8 for ; Thu, 21 May 2020 12:09:30 -0700 (PDT) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com. [209.85.221.52]) by smtp.gmail.com with ESMTPSA id m3sm5342878ede.58.2020.05.21.12.09.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2020 12:09:29 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id l17so7764764wrr.4 for ; Thu, 21 May 2020 12:09:29 -0700 (PDT) MIME-Version: 1.0 References: <20200515212846.1347-1-mcgrof@kernel.org> <20200515212846.1347-13-mcgrof@kernel.org> <2b74a35c726e451b2fab2b5d0d301e80d1f4cdc7.camel@sipsolutions.net> <7306323c35e6f44d7c569e689b48f380f80da5e5.camel@sipsolutions.net> <20200519140212.GT11244@42.do-not-panic.com> In-Reply-To: From: Brian Norris Date: Thu, 21 May 2020 12:01:14 -0700 Message-ID: Subject: Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Emmanuel Grumbach Cc: aquini@redhat.com, peterz@infradead.org, Daniel Vetter , mchehab+samsung@kernel.org, will@kernel.org, schlad@suse.de, bhe@redhat.com, ath10k@lists.infradead.org, Takashi Iwai , mingo@redhat.com, dyoung@redhat.com, pmladek@suse.com, Kees Cook , Arnd Bergmann , gpiccoli@canonical.com, Steven Rostedt , cai@lca.pw, tglx@linutronix.de, Andy Shevchenko , Andrew Morton , Kalle Valo , "" , linux-wireless , Linux Kernel , Luis Chamberlain , jeyu@kernel.org, Johannes Berg , "David S. Miller" On Tue, May 19, 2020 at 10:37 PM Emmanuel Grumbach wrote: > So I believe we already have this uevent, it is the devcoredump. All > we need is to add the unique id. I think there are a few reasons that devcoredump doesn't satisfy what either Luis or I want. 1) it can be disabled entirely [1], for good reasons (e.g., think of non-${CHIP_VENDOR} folks, who can't (and don't want to) do anything with the opaque dumps provided by closed-source firmware) 2) not all drivers necessarily have a useful dump to provide when there's a crash; look at the rest of Luis's series to see the kinds of drivers-with-firmware that are crashing, some of which aren't dumping anything 3) for those that do support devcoredump, it may be used for purposes that are not "crashes" -- e.g., some provide debugfs or other knobs to initiate dumps, for diagnostic or debugging purposes Brian [1] devcd_disabled https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/devcoredump.c?h=v5.6#n22 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k