From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B393C433EF for ; Fri, 4 Mar 2022 20:47:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229756AbiCDUse (ORCPT ); Fri, 4 Mar 2022 15:48:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbiCDUs3 (ORCPT ); Fri, 4 Mar 2022 15:48:29 -0500 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAF9C1066F1 for ; Fri, 4 Mar 2022 12:47:39 -0800 (PST) Received: by mail-ot1-x329.google.com with SMTP id 40-20020a9d032b000000b005b02923e2e6so8373964otv.1 for ; Fri, 04 Mar 2022 12:47:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pwdmIZ1vAwSObDe/h49djMAqGoMYF/D6xcMqohXC3kE=; b=RJf3TBmp93JdSx/quLb7AdYBJ1dJjO4Y4Ur4LXOaYnhYg5IMjk6yJimLcSePe+3blZ i5tAo5PIEAC++iphSrvFL7dS6M0Ffa/2SdzGpF8ak6C7GgpMRuz0ywkeV5lFhhNf1pJy B+YSlCqiwqlwnarFHej640qLdKSfryCEGs5+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pwdmIZ1vAwSObDe/h49djMAqGoMYF/D6xcMqohXC3kE=; b=LkusdQOVuQOtsK+A3vmPzcxqqGp8dMbk+BLj3KktTyHsAEMFK5Nn67oqEjEFywubru +n4GNcn/t4Wn4jQQBmDo5xLNhVPfBETHnBXu0IpA6LH95Jt1q9SqwE+mvq/F/ZT85J5L H2X2WH2G8XY6mf+mCufZJxCNjxcU6bI3bXog1Y4Xf8tL+bDd4n3XNNC74PqwcnXEHcit Fcnmee2gRLN9DEBNlqLeo1IyrYONiu+8z35IyX8EJbmKkNfTBfaJKlvoKS1Wq0WKPfFE Wu6WiVxbot1EE+57Yrzw6j4R8nPp1ou4fDSEZ/htxC8SXfUbnCN9xCZQap2xVdr2PhF1 22fg== X-Gm-Message-State: AOAM531WjkYO9+QSvAywJGDNI3pxcJkkak3dKEJe5UNJNgNOYJ9b7Qrv b18pE5RvzmdlxESL/Ce4duQp7XShsFFn3w== X-Google-Smtp-Source: ABdhPJx+zwgZkEYhXQUNKZPGPcyumXafyBrIN9ieUNRdSkzH+fYjH3ASFz0r1bv8CG0mB4MlwvMPIw== X-Received: by 2002:a9d:2da5:0:b0:5ad:fa9:832 with SMTP id g34-20020a9d2da5000000b005ad0fa90832mr248637otb.250.1646426858838; Fri, 04 Mar 2022 12:47:38 -0800 (PST) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com. [209.85.210.51]) by smtp.gmail.com with ESMTPSA id m17-20020a0568080f1100b002d71e151e51sm3467381oiw.0.2022.03.04.12.47.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Mar 2022 12:47:37 -0800 (PST) Received: by mail-ot1-f51.google.com with SMTP id s1-20020a056830148100b005acfdcb1f4bso8375184otq.4 for ; Fri, 04 Mar 2022 12:47:36 -0800 (PST) X-Received: by 2002:a9d:7:0:b0:5b1:fe36:2d15 with SMTP id 7-20020a9d0007000000b005b1fe362d15mr249673ota.186.1646426856478; Fri, 04 Mar 2022 12:47:36 -0800 (PST) MIME-Version: 1.0 References: <20220127230727.3369358-1-briannorris@chromium.org> <20220127150615.v2.12.I3a5c7f21ecd8221b42c2dbcd618386bce7b3e9a6@changeid> In-Reply-To: From: Brian Norris Date: Fri, 4 Mar 2022 12:47:25 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 12/15] arm64: dts: rockchip: Enable dmc and dfi nodes on gru To: Peter Geis Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Rob Herring , Linux Kernel Mailing List , "open list:ARM/Rockchip SoC..." , Lin Huang , arm-mail-list , Derek Basehore , devicetree , linux-pm , Heiko Stuebner , Enric Balletbo i Serra , =?UTF-8?B?R2HDq2wgUE9SVEFZ?= , Daniel Lezcano Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On Fri, Mar 4, 2022 at 6:47 AM Peter Geis wrote: > I'm trying to bring this series over to rockpro64 (and eventually the > pinephone-pro) and am running into some snags. Dumb question: is DDR DVFS supported on these systems in the "production" (vendor kernel? I'm not really familiar with these devices) software? I partly ask, because while I didn't do some of this first-hand, I'm aware that it was a real ordeal to get things stabilized (e.g., getting all the timings right; communicating the right details from bootloader to ATF; etc.), so if no one did these things in the first place, it's probably difficult to get working now just by guessing. But if it works on a customized kernel, then that's a different story. > Essentially, anytime a transition happens, the board locks up. > I've disabled the extra power save disable flags and adjusted the OPPs > for rockpro64's power. > Transitions anywhere from the default 800mhz cause a lock. > > I'm digging deeper, but I'm hoping you can answer some questions in > the meantime: > 1. Does this require something from firmware that isn't available on > Mainline ATF? (AKA special firmware to the Chromebook line) I don't know precisely. Chromebooks track mainline ATF, but somewhere before initial product launch, each platform gets its own firmware branch. On that firmware branch, we still try to stay in sync with mainline to some extent (e.g., submit to mainline and cherry-pick to branch), but it's not guaranteed. Anyway, you can inspect our code here: https://chromium.googlesource.com/chromiumos/third_party/arm-trusted-firmware/+log/refs/heads/firmware-gru-8785.B https://chromium.googlesource.com/chromiumos/third_party/coreboot/+log/refs/heads/firmware-gru-8785.B Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF59EC433F5 for ; Fri, 4 Mar 2022 20:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z0cVndLI9ctUsfr/8KdnwUpTL8kZLWF2MQrB/szXKp0=; b=tTHkKQGT36ZBFO tzqOgmb0I60UDqNUzNIjYtFULwZ4NpIKXD/5X2CmXyF5iRGzdghmYKSJb2yKjMjPo/uNLHrSR+5TG UgyD1HJzsNO07YXqu3WME022d/6gZ4G9Kt2/0h03InSw+xui9o8LCYp9FiGkxrHP/kVWgZT8zQ2AK FxIZemIkAiaY8TP29QYeXTvGITYslElWsHUXny8U7NlTNShJcuez0puTnqHpuU+rY1VkuDZLkmPkg VB5b+jr0L2qodTRc5hUxUnTfoZnGXXiLjW9yt0+syWSEBkFY/7oqTAL23fFSUmoeqP2u8wSynw1RN vEYHVK1e2lsJiSQk1TKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQEq0-00C2QY-36; Fri, 04 Mar 2022 20:47:44 +0000 Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQEpx-00C2Pe-GA for linux-rockchip@lists.infradead.org; Fri, 04 Mar 2022 20:47:43 +0000 Received: by mail-oo1-xc2b.google.com with SMTP id o7-20020a056820040700b003205d5eae6eso10251627oou.5 for ; Fri, 04 Mar 2022 12:47:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pwdmIZ1vAwSObDe/h49djMAqGoMYF/D6xcMqohXC3kE=; b=RJf3TBmp93JdSx/quLb7AdYBJ1dJjO4Y4Ur4LXOaYnhYg5IMjk6yJimLcSePe+3blZ i5tAo5PIEAC++iphSrvFL7dS6M0Ffa/2SdzGpF8ak6C7GgpMRuz0ywkeV5lFhhNf1pJy B+YSlCqiwqlwnarFHej640qLdKSfryCEGs5+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pwdmIZ1vAwSObDe/h49djMAqGoMYF/D6xcMqohXC3kE=; b=xEdcldL6XNG9puIMcoQgLD1lchMVP+GA1LVopZvMGg3NnTjMgbzLRVBeAGSWr3JX6b 9+9ZOEnzIXOI6u6IKEradbiOi5y2DvgiiIsagO1aTXPNFW5pTliJ3L7ONb6uPOdXzHdN VGUmW+BT2Cgomu68txKC1oqGTgvh/K7Il/xa1jisstJL7YqjdjEYnxwC7MjXwTSeBVjP CpD5XBRj7dC0BkTonnT3qMVIwOSr5V/5KkDoK9HK885XGJtwIPP6QreS9G+zAhDNRp2W LmgAhsHwKgo7qinD08cAPPPFD3EgbXuEebfK1lZjOQglEeZCquXe2AfD7ekhWyAk5/82 1SaQ== X-Gm-Message-State: AOAM530emC6MTOZ27P3NdtClCDblD7GOlxWx7CA/NYEgpAvCWnac5yLd +v+Tkycq1yN2xryRotPbQSbMClDnBdVGJg== X-Google-Smtp-Source: ABdhPJzJYUzc/7EcSW+jD2WsOanvekDFwYA9Zd1uqrsgNcUbcPJk95ErK1BpNg1nFNEP4WAxh68Z6A== X-Received: by 2002:a05:6870:168b:b0:da:b3f:2b78 with SMTP id j11-20020a056870168b00b000da0b3f2b78mr594062oae.279.1646426859163; Fri, 04 Mar 2022 12:47:39 -0800 (PST) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com. [209.85.210.51]) by smtp.gmail.com with ESMTPSA id v8-20020a4ae6c8000000b0031c2e6dd492sm2699314oot.28.2022.03.04.12.47.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Mar 2022 12:47:37 -0800 (PST) Received: by mail-ot1-f51.google.com with SMTP id k22-20020a9d4b96000000b005ad5211bd5aso8353962otf.8 for ; Fri, 04 Mar 2022 12:47:36 -0800 (PST) X-Received: by 2002:a9d:7:0:b0:5b1:fe36:2d15 with SMTP id 7-20020a9d0007000000b005b1fe362d15mr249673ota.186.1646426856478; Fri, 04 Mar 2022 12:47:36 -0800 (PST) MIME-Version: 1.0 References: <20220127230727.3369358-1-briannorris@chromium.org> <20220127150615.v2.12.I3a5c7f21ecd8221b42c2dbcd618386bce7b3e9a6@changeid> In-Reply-To: From: Brian Norris Date: Fri, 4 Mar 2022 12:47:25 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 12/15] arm64: dts: rockchip: Enable dmc and dfi nodes on gru To: Peter Geis Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Rob Herring , Linux Kernel Mailing List , "open list:ARM/Rockchip SoC..." , Lin Huang , arm-mail-list , Derek Basehore , devicetree , linux-pm , Heiko Stuebner , Enric Balletbo i Serra , =?UTF-8?B?R2HDq2wgUE9SVEFZ?= , Daniel Lezcano X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220304_124741_579557_8340E764 X-CRM114-Status: GOOD ( 19.90 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Peter, On Fri, Mar 4, 2022 at 6:47 AM Peter Geis wrote: > I'm trying to bring this series over to rockpro64 (and eventually the > pinephone-pro) and am running into some snags. Dumb question: is DDR DVFS supported on these systems in the "production" (vendor kernel? I'm not really familiar with these devices) software? I partly ask, because while I didn't do some of this first-hand, I'm aware that it was a real ordeal to get things stabilized (e.g., getting all the timings right; communicating the right details from bootloader to ATF; etc.), so if no one did these things in the first place, it's probably difficult to get working now just by guessing. But if it works on a customized kernel, then that's a different story. > Essentially, anytime a transition happens, the board locks up. > I've disabled the extra power save disable flags and adjusted the OPPs > for rockpro64's power. > Transitions anywhere from the default 800mhz cause a lock. > > I'm digging deeper, but I'm hoping you can answer some questions in > the meantime: > 1. Does this require something from firmware that isn't available on > Mainline ATF? (AKA special firmware to the Chromebook line) I don't know precisely. Chromebooks track mainline ATF, but somewhere before initial product launch, each platform gets its own firmware branch. On that firmware branch, we still try to stay in sync with mainline to some extent (e.g., submit to mainline and cherry-pick to branch), but it's not guaranteed. Anyway, you can inspect our code here: https://chromium.googlesource.com/chromiumos/third_party/arm-trusted-firmware/+log/refs/heads/firmware-gru-8785.B https://chromium.googlesource.com/chromiumos/third_party/coreboot/+log/refs/heads/firmware-gru-8785.B Brian _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B857C433F5 for ; Fri, 4 Mar 2022 20:49:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sKZ550t8jot1xqL017y1lMlMRKaDO4i5bCxIcncwE0Y=; b=PDm1kiYgCrIjUu VbhP+C2tak96tjFh50Rc72GI5xW+sDixRj7aRv+ktvv/sdtQDLcC/epF9e+40RM47MyYuo1Cf7Ed+ D+kB7ygXt5AW29ARdRBnRF0pigKhGHfxMPt2ppIb5rxa7nMPqeww4es3ZxjF/wVqzZiXqmr+Ee5Gw F45d/zBDB8RlUxuxyHB7MpZk7TcJWojtIsdazDdJBv1v8CpRIYdX1lXAmau5Lg0ZX99lA+FSyZ6mv 2YPAR06VjlrDZuTSUXnouCTXPDN/Vk8arrJOTmiM8Od3mDWy6FtCrc/nVT0iWtBGw8s076CRarmBa EupUmFqw0ONArn+tmSAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQEq2-00C2R1-Hl; Fri, 04 Mar 2022 20:47:46 +0000 Received: from mail-oo1-xc31.google.com ([2607:f8b0:4864:20::c31]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQEpy-00C2Pj-4K for linux-arm-kernel@lists.infradead.org; Fri, 04 Mar 2022 20:47:43 +0000 Received: by mail-oo1-xc31.google.com with SMTP id y15-20020a4a650f000000b0031c19e9fe9dso10731010ooc.12 for ; Fri, 04 Mar 2022 12:47:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pwdmIZ1vAwSObDe/h49djMAqGoMYF/D6xcMqohXC3kE=; b=RJf3TBmp93JdSx/quLb7AdYBJ1dJjO4Y4Ur4LXOaYnhYg5IMjk6yJimLcSePe+3blZ i5tAo5PIEAC++iphSrvFL7dS6M0Ffa/2SdzGpF8ak6C7GgpMRuz0ywkeV5lFhhNf1pJy B+YSlCqiwqlwnarFHej640qLdKSfryCEGs5+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pwdmIZ1vAwSObDe/h49djMAqGoMYF/D6xcMqohXC3kE=; b=rG0t6RcwV4vViHIgeISAW1EvAKfz7xnyT2hjOpNq4tvw2mK4NctikhJVlJPobmPKPb gm3gfeDVSsVytuyhDEkUM91sBvrDu1AXSqIyaxvO46tF/f5hjL8Sw8FzdRBe5tlcqSMB oNa2gQBZDfcgBfo92NWNzQMZXQFZVsn9eHFy/EVgDHc5AQZwh2dGnTzv48O4NEiz/Usy ly012votVQfQG4Qg4FjEYaFFiUrJJ//mE2jma9nJXhLsgYzY3drFtybM18TryYDIe/Wv 6PL9CHrVxJuTs195i+9SxXHoBZAymhbEtFHO0K0jSbua0QJjoewrsFytg118tOq7+QY3 5eRA== X-Gm-Message-State: AOAM533zxUF7ThXBWeDR9YBzY+zn1sbOKS0GTxN5uDeu6gWGEWxDTVcj q62hP+H66Bu9ferAxpO1blJThwMjdGr3LA== X-Google-Smtp-Source: ABdhPJzPqbkp8C5atR4O1Y5mEzMZHEA7w8BTrZM4kJJkABkzp5RYqAl0+cwYJ46t6fSSI3QHMxCf9A== X-Received: by 2002:a05:6870:340c:b0:da:b3f:325a with SMTP id g12-20020a056870340c00b000da0b3f325amr142184oah.266.1646426859902; Fri, 04 Mar 2022 12:47:39 -0800 (PST) Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com. [209.85.210.44]) by smtp.gmail.com with ESMTPSA id z26-20020a0568301dba00b005ad0fc5abe4sm2740182oti.16.2022.03.04.12.47.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Mar 2022 12:47:37 -0800 (PST) Received: by mail-ot1-f44.google.com with SMTP id j8-20020a056830014800b005ad00ef6d5dso8407305otp.0 for ; Fri, 04 Mar 2022 12:47:36 -0800 (PST) X-Received: by 2002:a9d:7:0:b0:5b1:fe36:2d15 with SMTP id 7-20020a9d0007000000b005b1fe362d15mr249673ota.186.1646426856478; Fri, 04 Mar 2022 12:47:36 -0800 (PST) MIME-Version: 1.0 References: <20220127230727.3369358-1-briannorris@chromium.org> <20220127150615.v2.12.I3a5c7f21ecd8221b42c2dbcd618386bce7b3e9a6@changeid> In-Reply-To: From: Brian Norris Date: Fri, 4 Mar 2022 12:47:25 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 12/15] arm64: dts: rockchip: Enable dmc and dfi nodes on gru To: Peter Geis Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Rob Herring , Linux Kernel Mailing List , "open list:ARM/Rockchip SoC..." , Lin Huang , arm-mail-list , Derek Basehore , devicetree , linux-pm , Heiko Stuebner , Enric Balletbo i Serra , =?UTF-8?B?R2HDq2wgUE9SVEFZ?= , Daniel Lezcano X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220304_124742_179970_5A69550C X-CRM114-Status: GOOD ( 21.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peter, On Fri, Mar 4, 2022 at 6:47 AM Peter Geis wrote: > I'm trying to bring this series over to rockpro64 (and eventually the > pinephone-pro) and am running into some snags. Dumb question: is DDR DVFS supported on these systems in the "production" (vendor kernel? I'm not really familiar with these devices) software? I partly ask, because while I didn't do some of this first-hand, I'm aware that it was a real ordeal to get things stabilized (e.g., getting all the timings right; communicating the right details from bootloader to ATF; etc.), so if no one did these things in the first place, it's probably difficult to get working now just by guessing. But if it works on a customized kernel, then that's a different story. > Essentially, anytime a transition happens, the board locks up. > I've disabled the extra power save disable flags and adjusted the OPPs > for rockpro64's power. > Transitions anywhere from the default 800mhz cause a lock. > > I'm digging deeper, but I'm hoping you can answer some questions in > the meantime: > 1. Does this require something from firmware that isn't available on > Mainline ATF? (AKA special firmware to the Chromebook line) I don't know precisely. Chromebooks track mainline ATF, but somewhere before initial product launch, each platform gets its own firmware branch. On that firmware branch, we still try to stay in sync with mainline to some extent (e.g., submit to mainline and cherry-pick to branch), but it's not guaranteed. Anyway, you can inspect our code here: https://chromium.googlesource.com/chromiumos/third_party/arm-trusted-firmware/+log/refs/heads/firmware-gru-8785.B https://chromium.googlesource.com/chromiumos/third_party/coreboot/+log/refs/heads/firmware-gru-8785.B Brian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel