From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D81C4363A for ; Thu, 29 Oct 2020 00:13:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7478B2076C for ; Thu, 29 Oct 2020 00:13:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YRSR+UuG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729259AbgJ2ANJ (ORCPT ); Wed, 28 Oct 2020 20:13:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390749AbgJ2ANI (ORCPT ); Wed, 28 Oct 2020 20:13:08 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07837C0613CF for ; Wed, 28 Oct 2020 17:13:08 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id v6so1018971lfa.13 for ; Wed, 28 Oct 2020 17:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tjZ0C47sBFE4E/dMNMwf9DAUHIodX8mtYvgDRoLI4EA=; b=YRSR+UuG72ciMnSbkIKW71fwluhc008uXS+zCtS9AHDFnFwQEIMMgP/YxKO2Dy1307 WP7/iso+nlAS+anmA1lgk8lE/LiU6ECV1Z6zNFlM6NINwI35F0XF+CWuJQeINp59prgV jihocwVqHZpzzVYcqIAvrcvpd/gtQFCguDskE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tjZ0C47sBFE4E/dMNMwf9DAUHIodX8mtYvgDRoLI4EA=; b=aet6K+b5jUsVjETw7dgK/nb8zQ2h9R4TwNt0O3DQ9/YtnVmjg1O0zMZBZCVjOhy2lH ZFIPbUyQDYm8KT7f+UrP3SW6tIqrHkC1RNaOdlatn9tM6YptI+vq47YLSGJAFKcZs0Z4 PgOva9OsbUXZGBeUp2T4OFFSSbIbGWyXKhhZaskDtkHZu9o6d5ieHmwcU7e+qczGxnW6 1917GVwGIGu7ExjqpJzoyb9R1qym6Eoxrkt8zGBZMNNGQPYnUr9TAany5/sOUVNbPVam /o38YK2lczvIkooXQa4uDVKGsVq8+1gO2zGrUXqqLptXsW1BR64P9Kd5tBbSM7NLG+no sivg== X-Gm-Message-State: AOAM531ElZTRztTnrY7tHDdK1Ei5F8ejzciamVy4STX0MZxwm+UCI5cK O78h9DbHpofSttDWKtwEZ8B8xCE87X6/PQ== X-Google-Smtp-Source: ABdhPJzuzO7SenUGMBmQPxDLY7XOQdg4kxaP+z8YWSgp035Cn+mTCfihBzUxEp13R7DwleEsVI2Oew== X-Received: by 2002:ac2:5395:: with SMTP id g21mr523820lfh.330.1603930385227; Wed, 28 Oct 2020 17:13:05 -0700 (PDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id f10sm124382ljn.87.2020.10.28.17.13.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Oct 2020 17:13:03 -0700 (PDT) Received: by mail-lf1-f53.google.com with SMTP id l28so1043728lfp.10 for ; Wed, 28 Oct 2020 17:13:03 -0700 (PDT) X-Received: by 2002:a19:c703:: with SMTP id x3mr502126lff.105.1603930383060; Wed, 28 Oct 2020 17:13:03 -0700 (PDT) MIME-Version: 1.0 References: <20201028142625.18642-1-kitakar@gmail.com> In-Reply-To: <20201028142625.18642-1-kitakar@gmail.com> From: Brian Norris Date: Wed, 28 Oct 2020 17:12:51 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mwifiex: pcie: add enable_device_dump module parameter To: Tsuchiya Yuto Cc: Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , Kalle Valo , "David S. Miller" , Jakub Kicinski , linux-wireless , "" , Linux Kernel , Maximilian Luz , Andy Shevchenko , verdre@v0yd.nl Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Oct 28, 2020 at 3:58 PM Tsuchiya Yuto wrote: > > The devicve_dump may take a little bit long time and users may want to > disable the dump for daily usage. > > This commit adds a new module parameter enable_device_dump and disables > the device_dump by default. As with one of your other patches, please don't change the defaults and hide them under a module parameter. If you're adding a module parameter, leave the default behavior alone. This also seems like something that might be nicer as a user-space knob in generic form (similar to "/sys/class/devcoredump/disabled", except on a per-device basis, and fed back to the driver so it doesn't waste time generating such dumps), but I suppose I can see why a module parameter (so you can just stick your configuration in /etc/modprobe.d/) might be easier to deal with in some cases. Brian