All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Kazior <michal.kazior@tieto.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Janusz Dziedzic <janusz.dziedzic@tieto.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: WEP, move tailroom size check
Date: Mon, 11 May 2015 14:43:38 +0200	[thread overview]
Message-ID: <CA+BoTQ=3VBsBWVy+e-hOJZD7ZUmoemsU0g8XoFLm7SE_iypQBw@mail.gmail.com> (raw)
In-Reply-To: <1431346122.1964.26.camel@sipsolutions.net>

On 11 May 2015 at 14:08, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Mon, 2015-05-11 at 11:31 +0200, Janusz Dziedzic wrote:
>> Remove checking tailroom when adding IV, while
>> this goes to headroom. Move this check to the function
>> that will generate/put ICV for WEP.
>>
>> In other case I hit such warning and datapath don't work,
>> when testing:
>> - IBSS + WEP
>> - ath9k with hw crypt enabled
>> - IPv6 data (ping6)
>
> Is this new, perhaps due to fast-xmit, because we previously added
> tailroom for WEP always? I've certainly never seen this before.
>
> (just asking so I know where it needs to be applied)

I think this was hidden for quite some time now, possibly since
_PUT_IV_SPACE and _GENERATE_IV were split into _GENERATE_MMIC and
_RESERVE_TAILROOM counterparts. I know that `ping` didn't trigger this
problem, instead `ping6` did which leads me to think that maybe
sk_buff allocation was getting lucky most of the time.


Michał

  reply	other threads:[~2015-05-11 12:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11  9:31 [PATCH] mac80211: WEP, move tailroom size check Janusz Dziedzic
2015-05-11 12:08 ` Johannes Berg
2015-05-11 12:43   ` Michal Kazior [this message]
2015-05-11 12:46     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+BoTQ=3VBsBWVy+e-hOJZD7ZUmoemsU0g8XoFLm7SE_iypQBw@mail.gmail.com' \
    --to=michal.kazior@tieto.com \
    --cc=janusz.dziedzic@tieto.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.