From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wi0-f170.google.com ([209.85.212.170]:63617 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbaDKFrp convert rfc822-to-8bit (ORCPT ); Fri, 11 Apr 2014 01:47:45 -0400 Received: by mail-wi0-f170.google.com with SMTP id bs8so2007927wib.1 for ; Thu, 10 Apr 2014 22:47:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <8738hkh193.fsf@kamboji.qca.qualcomm.com> References: <53461A8A.4030209@candelatech.com> <1397124355-6321-1-git-send-email-michal.kazior@tieto.com> <8738hkh193.fsf@kamboji.qca.qualcomm.com> Date: Fri, 11 Apr 2014 07:47:44 +0200 Message-ID: (sfid-20140411_074750_739870_BA582697) Subject: Re: [PATCH] ath10k: double check bmi xfer pointers From: Michal Kazior To: Kalle Valo Cc: "ath10k@lists.infradead.org" , Ben Greear , linux-wireless Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11 April 2014 07:40, Kalle Valo wrote: > Michal Kazior writes: > >> If for some reason copy engine ring buffer became >> corrupt ath10k could crash the machine due to >> invalid pointer dereference. It's very unlikely >> but devices can never be fully trusted so verify >> if the bmi xfer pointer read back from copy engine >> matches the original pointer. > > The big question is why does this happen? Does this happen only with > Ben's firmware or is it a more generic problem? I'll look more into this. Michał From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wg0-x233.google.com ([2a00:1450:400c:c00::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WYUQ2-0002DJ-18 for ath10k@lists.infradead.org; Fri, 11 Apr 2014 05:54:30 +0000 Received: by mail-wg0-f51.google.com with SMTP id k14so4952174wgh.10 for ; Thu, 10 Apr 2014 22:54:07 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <8738hkh193.fsf@kamboji.qca.qualcomm.com> References: <53461A8A.4030209@candelatech.com> <1397124355-6321-1-git-send-email-michal.kazior@tieto.com> <8738hkh193.fsf@kamboji.qca.qualcomm.com> Date: Fri, 11 Apr 2014 07:47:44 +0200 Message-ID: Subject: Re: [PATCH] ath10k: double check bmi xfer pointers From: Michal Kazior List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: Ben Greear , linux-wireless , "ath10k@lists.infradead.org" T24gMTEgQXByaWwgMjAxNCAwNzo0MCwgS2FsbGUgVmFsbyA8a3ZhbG9AcWNhLnF1YWxjb21tLmNv bT4gd3JvdGU6Cj4gTWljaGFsIEthemlvciA8bWljaGFsLmthemlvckB0aWV0by5jb20+IHdyaXRl czoKPgo+PiBJZiBmb3Igc29tZSByZWFzb24gY29weSBlbmdpbmUgcmluZyBidWZmZXIgYmVjYW1l Cj4+IGNvcnJ1cHQgYXRoMTBrIGNvdWxkIGNyYXNoIHRoZSBtYWNoaW5lIGR1ZSB0bwo+PiBpbnZh bGlkIHBvaW50ZXIgZGVyZWZlcmVuY2UuIEl0J3MgdmVyeSB1bmxpa2VseQo+PiBidXQgZGV2aWNl cyBjYW4gbmV2ZXIgYmUgZnVsbHkgdHJ1c3RlZCBzbyB2ZXJpZnkKPj4gaWYgdGhlIGJtaSB4ZmVy IHBvaW50ZXIgcmVhZCBiYWNrIGZyb20gY29weSBlbmdpbmUKPj4gbWF0Y2hlcyB0aGUgb3JpZ2lu YWwgcG9pbnRlci4KPgo+IFRoZSBiaWcgcXVlc3Rpb24gaXMgd2h5IGRvZXMgdGhpcyBoYXBwZW4/ IERvZXMgdGhpcyBoYXBwZW4gb25seSB3aXRoCj4gQmVuJ3MgZmlybXdhcmUgb3IgaXMgaXQgYSBt b3JlIGdlbmVyaWMgcHJvYmxlbT8KCkknbGwgbG9vayBtb3JlIGludG8gdGhpcy4KCgpNaWNoYcWC CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphdGgxMGsg bWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg==