From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:33618 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941543AbcKOK2k (ORCPT ); Tue, 15 Nov 2016 05:28:40 -0500 Received: by mail-wm0-f42.google.com with SMTP id c184so21633319wmd.0 for ; Tue, 15 Nov 2016 02:28:39 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1479141222-8493-7-git-send-email-erik.stromdahl@gmail.com> References: <1479141222-8493-1-git-send-email-erik.stromdahl@gmail.com> <1479141222-8493-7-git-send-email-erik.stromdahl@gmail.com> From: Michal Kazior Date: Tue, 15 Nov 2016 11:28:38 +0100 Message-ID: (sfid-20161115_112844_343522_C3225E89) Subject: Re: [RFC 06/12] ath10k: bmi: Added SOC reg read/write functions To: Erik Stromdahl Cc: Kalle Valo , linux-wireless , "ath10k@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 14 November 2016 at 17:33, Erik Stromdahl wro= te: > Added functions implementing the following BMI commands: > > BMI_READ_SOC_REGISTER > BMI_WRITE_SOC_REGISTER > > Reading and writing BMI registers is sometimes needed for > SDIO chipsets. I didn't see ath10k_bmi_write_soc_reg nor ath10k_bmi_read_soc_reg being used in your Patch 12. Is this patch really necessary? [...] > diff --git a/drivers/net/wireless/ath/ath10k/bmi.c b/drivers/net/wireless= /ath/ath10k/bmi.c > index 2872d34..1c378a2 100644 > --- a/drivers/net/wireless/ath/ath10k/bmi.c > +++ b/drivers/net/wireless/ath/ath10k/bmi.c > @@ -97,7 +97,8 @@ int ath10k_bmi_read_memory(struct ath10k *ar, > u32 rxlen; > int ret; > > - ath10k_dbg(ar, ATH10K_DBG_BMI, "bmi read address 0x%x length %d\n= ", > + ath10k_dbg(ar, ATH10K_DBG_BMI, > + "bmi read memory address 0x%x length %d\n", > address, length); > > if (ar->bmi.done_sent) { > @@ -137,7 +138,8 @@ int ath10k_bmi_write_memory(struct ath10k *ar, > u32 txlen; > int ret; > > - ath10k_dbg(ar, ATH10K_DBG_BMI, "bmi write address 0x%x length %d\= n", > + ath10k_dbg(ar, ATH10K_DBG_BMI, > + "bmi write memory address 0x%x length %d\n", > address, length); > These 2 hunks shouldn't be modified in this patch. If you want to do a clean up this warrants a separate patch :) Micha=C5=82 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c6az6-0001j9-A7 for ath10k@lists.infradead.org; Tue, 15 Nov 2016 10:29:01 +0000 Received: by mail-wm0-x22b.google.com with SMTP id g23so157410070wme.1 for ; Tue, 15 Nov 2016 02:28:40 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1479141222-8493-7-git-send-email-erik.stromdahl@gmail.com> References: <1479141222-8493-1-git-send-email-erik.stromdahl@gmail.com> <1479141222-8493-7-git-send-email-erik.stromdahl@gmail.com> From: Michal Kazior Date: Tue, 15 Nov 2016 11:28:38 +0100 Message-ID: Subject: Re: [RFC 06/12] ath10k: bmi: Added SOC reg read/write functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Erik Stromdahl Cc: Kalle Valo , linux-wireless , "ath10k@lists.infradead.org" T24gMTQgTm92ZW1iZXIgMjAxNiBhdCAxNzozMywgRXJpayBTdHJvbWRhaGwgPGVyaWsuc3Ryb21k YWhsQGdtYWlsLmNvbT4gd3JvdGU6Cj4gQWRkZWQgZnVuY3Rpb25zIGltcGxlbWVudGluZyB0aGUg Zm9sbG93aW5nIEJNSSBjb21tYW5kczoKPgo+IEJNSV9SRUFEX1NPQ19SRUdJU1RFUgo+IEJNSV9X UklURV9TT0NfUkVHSVNURVIKPgo+IFJlYWRpbmcgYW5kIHdyaXRpbmcgQk1JIHJlZ2lzdGVycyBp cyBzb21ldGltZXMgbmVlZGVkIGZvcgo+IFNESU8gY2hpcHNldHMuCgpJIGRpZG4ndCBzZWUgYXRo MTBrX2JtaV93cml0ZV9zb2NfcmVnIG5vciBhdGgxMGtfYm1pX3JlYWRfc29jX3JlZwpiZWluZyB1 c2VkIGluIHlvdXIgUGF0Y2ggMTIuIElzIHRoaXMgcGF0Y2ggcmVhbGx5IG5lY2Vzc2FyeT8KCgpb Li4uXQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRoMTBrL2JtaS5j IGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9ibWkuYwo+IGluZGV4IDI4NzJkMzQu LjFjMzc4YTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9i bWkuYwo+ICsrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvYm1pLmMKPiBAQCAt OTcsNyArOTcsOCBAQCBpbnQgYXRoMTBrX2JtaV9yZWFkX21lbW9yeShzdHJ1Y3QgYXRoMTBrICph ciwKPiAgICAgICAgIHUzMiByeGxlbjsKPiAgICAgICAgIGludCByZXQ7Cj4KPiAtICAgICAgIGF0 aDEwa19kYmcoYXIsIEFUSDEwS19EQkdfQk1JLCAiYm1pIHJlYWQgYWRkcmVzcyAweCV4IGxlbmd0 aCAlZFxuIiwKPiArICAgICAgIGF0aDEwa19kYmcoYXIsIEFUSDEwS19EQkdfQk1JLAo+ICsgICAg ICAgICAgICAgICAgICAiYm1pIHJlYWQgbWVtb3J5IGFkZHJlc3MgMHgleCBsZW5ndGggJWRcbiIs Cj4gICAgICAgICAgICAgICAgICAgIGFkZHJlc3MsIGxlbmd0aCk7Cj4KPiAgICAgICAgIGlmIChh ci0+Ym1pLmRvbmVfc2VudCkgewo+IEBAIC0xMzcsNyArMTM4LDggQEAgaW50IGF0aDEwa19ibWlf d3JpdGVfbWVtb3J5KHN0cnVjdCBhdGgxMGsgKmFyLAo+ICAgICAgICAgdTMyIHR4bGVuOwo+ICAg ICAgICAgaW50IHJldDsKPgo+IC0gICAgICAgYXRoMTBrX2RiZyhhciwgQVRIMTBLX0RCR19CTUks ICJibWkgd3JpdGUgYWRkcmVzcyAweCV4IGxlbmd0aCAlZFxuIiwKPiArICAgICAgIGF0aDEwa19k YmcoYXIsIEFUSDEwS19EQkdfQk1JLAo+ICsgICAgICAgICAgICAgICAgICAiYm1pIHdyaXRlIG1l bW9yeSBhZGRyZXNzIDB4JXggbGVuZ3RoICVkXG4iLAo+ICAgICAgICAgICAgICAgICAgICBhZGRy ZXNzLCBsZW5ndGgpOwo+CgpUaGVzZSAyIGh1bmtzIHNob3VsZG4ndCBiZSBtb2RpZmllZCBpbiB0 aGlzIHBhdGNoLiBJZiB5b3Ugd2FudCB0byBkbyBhCmNsZWFuIHVwIHRoaXMgd2FycmFudHMgYSBz ZXBhcmF0ZSBwYXRjaCA6KQoKCk1pY2hhxYIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgx MGsK