From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-we0-f171.google.com ([74.125.82.171]:37255 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbaHSJiM convert rfc822-to-8bit (ORCPT ); Tue, 19 Aug 2014 05:38:12 -0400 Received: by mail-we0-f171.google.com with SMTP id p10so6155237wes.30 for ; Tue, 19 Aug 2014 02:38:10 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20140819082316.16842.85085.stgit@potku.adurom.net> References: <20140819082038.16842.46876.stgit@potku.adurom.net> <20140819082316.16842.85085.stgit@potku.adurom.net> Date: Tue, 19 Aug 2014 11:38:10 +0200 Message-ID: (sfid-20140819_113815_317224_729D109C) Subject: Re: [PATCH v7 5/8] ath10k: dump exception stack contents on firmware crash From: Michal Kazior To: Kalle Valo Cc: "ath10k@lists.infradead.org" , linux-wireless Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 19 August 2014 10:23, Kalle Valo wrote: > From: Ben Greear > > Firmware developers can decode this and maybe figure out > why the firmware crashed. > > Signed-off-by: Ben Greear > Signed-off-by: Kalle Valo > --- [...] > +/* Save the firmware exception stack */ > +static void ath10k_pci_dump_exc_stack(struct ath10k *ar, > + struct ath10k_fw_crash_data *crash_data) > +{ > + lockdep_assert_held(&ar->data_lock); > + > + BUILD_BUG_ON(ATH10K_FW_STACK_SIZE % 4); > + > + ath10k_pci_diag_read_hi(ar, crash_data->exc_stack_buf, > + hi_err_stack, ATH10K_FW_STACK_SIZE); Current master tree performs an implicit byte swap so the stack read from target will be in host endianess. IOW on big-endian host you'll messed up data and there's no indication of endianess anymore. Michał From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XJfs8-0002uA-PQ for ath10k@lists.infradead.org; Tue, 19 Aug 2014 09:38:33 +0000 Received: by mail-wg0-f45.google.com with SMTP id x12so6059071wgg.28 for ; Tue, 19 Aug 2014 02:38:10 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20140819082316.16842.85085.stgit@potku.adurom.net> References: <20140819082038.16842.46876.stgit@potku.adurom.net> <20140819082316.16842.85085.stgit@potku.adurom.net> Date: Tue, 19 Aug 2014 11:38:10 +0200 Message-ID: Subject: Re: [PATCH v7 5/8] ath10k: dump exception stack contents on firmware crash From: Michal Kazior List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: linux-wireless , "ath10k@lists.infradead.org" T24gMTkgQXVndXN0IDIwMTQgMTA6MjMsIEthbGxlIFZhbG8gPGt2YWxvQHFjYS5xdWFsY29tbS5j b20+IHdyb3RlOgo+IEZyb206IEJlbiBHcmVlYXIgPGdyZWVhcmJAY2FuZGVsYXRlY2guY29tPgo+ Cj4gRmlybXdhcmUgZGV2ZWxvcGVycyBjYW4gZGVjb2RlIHRoaXMgYW5kIG1heWJlIGZpZ3VyZSBv dXQKPiB3aHkgdGhlIGZpcm13YXJlIGNyYXNoZWQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBCZW4gR3Jl ZWFyIDxncmVlYXJiQGNhbmRlbGF0ZWNoLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBLYWxsZSBWYWxv IDxrdmFsb0BxY2EucXVhbGNvbW0uY29tPgo+IC0tLQpbLi4uXQo+ICsvKiBTYXZlIHRoZSBmaXJt d2FyZSBleGNlcHRpb24gc3RhY2sgKi8KPiArc3RhdGljIHZvaWQgYXRoMTBrX3BjaV9kdW1wX2V4 Y19zdGFjayhzdHJ1Y3QgYXRoMTBrICphciwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHN0cnVjdCBhdGgxMGtfZndfY3Jhc2hfZGF0YSAqY3Jhc2hfZGF0YSkKPiArewo+ ICsgICAgICAgbG9ja2RlcF9hc3NlcnRfaGVsZCgmYXItPmRhdGFfbG9jayk7Cj4gKwo+ICsgICAg ICAgQlVJTERfQlVHX09OKEFUSDEwS19GV19TVEFDS19TSVpFICUgNCk7Cj4gKwo+ICsgICAgICAg YXRoMTBrX3BjaV9kaWFnX3JlYWRfaGkoYXIsIGNyYXNoX2RhdGEtPmV4Y19zdGFja19idWYsCj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBoaV9lcnJfc3RhY2ssIEFUSDEwS19GV19T VEFDS19TSVpFKTsKCkN1cnJlbnQgbWFzdGVyIHRyZWUgcGVyZm9ybXMgYW4gaW1wbGljaXQgYnl0 ZSBzd2FwIHNvIHRoZSBzdGFjayByZWFkCmZyb20gdGFyZ2V0IHdpbGwgYmUgaW4gaG9zdCBlbmRp YW5lc3MuIElPVyBvbiBiaWctZW5kaWFuIGhvc3QgeW91J2xsCm1lc3NlZCB1cCBkYXRhIGFuZCB0 aGVyZSdzIG5vIGluZGljYXRpb24gb2YgZW5kaWFuZXNzIGFueW1vcmUuCgoKTWljaGHFggoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxp bmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo=