From: Michal Kazior <michal.kazior@tieto.com>
To: Marty Faltesek <mfaltesek@google.com>
Cc: "Valo, Kalle" <kvalo@qca.qualcomm.com>,
Adrian Chadd <adrian@freebsd.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: accessing ath10k calibration data
Date: Thu, 15 Sep 2016 13:24:01 +0200 [thread overview]
Message-ID: <CA+BoTQk6tjSemQjipc9QtTm8eLSnjiNGE8er0t-OjsmVikd7ZA@mail.gmail.com> (raw)
In-Reply-To: <CAOiWkA9xXSc2t9WGTXSvh9KNPDBd1M2ZwEcm-rTMvRVWr0C82Q@mail.gmail.com>
On 15 September 2016 at 01:54, Marty Faltesek <mfaltesek@google.com> wrote:
> I sent out the patch.
>
> I ran into another related issue. Let me explain what we are trying to do:
>
> We want to examine cal_data for a possibly mis-calibrated OTP, and if
> so, patch it and store
> the result in /tmp (creating a symlink from
> /ilb/firmware/ath10k/cal-pci-0001:01:00.0.bin to /tmp).
>
> But ath10k_fetch_cal_file() is only read once at load time, so I've
> modified the code to call this function from
> ath10k_download_cal_file()
> so that the driver catches the modified cal_data. This seems to work
> based on the read back of the patched cal_data, but is it the right
> approach, or is there a better or cleaner way?
The reason why firmware files (including cal, et al) in memory is to
guarantee firmware reloads result in the same set of hw capabilities
which can be advertised during mac80211 register time. Changing them
in runtime is not really clean.
I don't really have a clean answer for you.
Do you really need to keep given driver instance running without
interruption? At what point do you verify caldata? If it's before
upping interfaces you could either unload/load the driver or
unbind/bind the device itself to force it to read firmware files anew.
Michał
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-09-15 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 17:35 accessing ath10k calibration data Marty Faltesek
2016-09-09 17:39 ` Adrian Chadd
2016-09-09 17:42 ` Marty Faltesek
2016-09-12 8:50 ` Michal Kazior
2016-09-12 19:47 ` Marty Faltesek
2016-09-13 10:46 ` Valo, Kalle
2016-09-13 20:49 ` Marty Faltesek
2016-09-13 20:50 ` Adrian Chadd
2016-09-14 5:01 ` Valo, Kalle
2016-09-14 23:54 ` Marty Faltesek
2016-09-15 11:24 ` Michal Kazior [this message]
2016-09-12 22:20 ` Marty Faltesek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+BoTQk6tjSemQjipc9QtTm8eLSnjiNGE8er0t-OjsmVikd7ZA@mail.gmail.com \
--to=michal.kazior@tieto.com \
--cc=adrian@freebsd.org \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=mfaltesek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.