From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from mail-wm0-f46.google.com ([74.125.82.46]:37700 "EHLO
        mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S941613AbcKOKNT (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Tue, 15 Nov 2016 05:13:19 -0500
Received: by mail-wm0-f46.google.com with SMTP id t79so157827812wmt.0
        for <linux-wireless@vger.kernel.org>; Tue, 15 Nov 2016 02:13:18 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1479141222-8493-4-git-send-email-erik.stromdahl@gmail.com>
References: <1479141222-8493-1-git-send-email-erik.stromdahl@gmail.com> <1479141222-8493-4-git-send-email-erik.stromdahl@gmail.com>
From: Michal Kazior <michal.kazior@tieto.com>
Date: Tue, 15 Nov 2016 11:13:15 +0100
Message-ID: <CA+BoTQmA0E+N46E3XkpqVPXSVkQNyZj2Qzrizk8iLdYzVthNQg@mail.gmail.com> (sfid-20161115_111332_994421_892E948D)
Subject: Re: [RFC 03/12] ath10k: htc: Changed order of wait target and ep connect
To: Erik Stromdahl <erik.stromdahl@gmail.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

On 14 November 2016 at 17:33, Erik Stromdahl <erik.stromdahl@gmail.com> wro=
te:
> This patch changes the order in which the driver waits for the
> target to become ready and the service connect of the HTC
> control service.
>
> The HTC control service is connected before the driver starts
> waiting for the HTC ready control message.
>
> The reason for this is that the HTC ready control message is
> transmitted on EP 0 and that sdio/mbox based systems will ignore
> messages received on unconnected endpoints.
>
> Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com>
> ---
>  drivers/net/wireless/ath/ath10k/htc.c |   32 ++++++++++++++++-----------=
-----
>  1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless=
/ath/ath10k/htc.c
> index e3f7bf4..7257366 100644
> --- a/drivers/net/wireless/ath/ath10k/htc.c
> +++ b/drivers/net/wireless/ath/ath10k/htc.c
> @@ -606,6 +606,22 @@ int ath10k_htc_wait_target(struct ath10k_htc *htc)
>         u16 credit_count;
>         u16 credit_size;
>
> +       /* setup our pseudo HTC control endpoint connection */
> +       memset(&conn_req, 0, sizeof(conn_req));
> +       memset(&conn_resp, 0, sizeof(conn_resp));
> +       conn_req.ep_ops.ep_tx_complete =3D ath10k_htc_control_tx_complete=
;
> +       conn_req.ep_ops.ep_rx_complete =3D ath10k_htc_control_rx_complete=
;
> +       conn_req.max_send_queue_depth =3D ATH10K_NUM_CONTROL_TX_BUFFERS;
> +       conn_req.service_id =3D ATH10K_HTC_SVC_ID_RSVD_CTRL;
> +
> +       /* connect fake service */
> +       status =3D ath10k_htc_connect_service(htc, &conn_req, &conn_resp)=
;
> +       if (status) {
> +               ath10k_err(ar, "could not connect to htc service (%d)\n",
> +                          status);
> +               return status;
> +       }
> +

How is this supposed to work? ath10k_htc_connect_service() requires
htc->target_credit_size to compute tx_credits_per_max_message. Or am I
missing something? Applying this patch alone results in:

[    6.680101] divide error: 0000 [#1] SMP
[    6.681342] Modules linked in: ath10k_pci(O) ath10k_core(O) ath
mac80211 cfg80211
[    6.684876] CPU: 3 PID: 823 Comm: kworker/u8:2 Tainted: G        W
O    4.9.0-rc4-wt-ath+ #79
[    6.688051] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
BIOS 1.7.5-20140531_083030-gandalf 04/01/2014
[    6.691644] Workqueue: ath10k_wq ath10k_core_register_work [ath10k_core]
[    6.694309] task: ffff88000a190000 task.stack: ffffc900006d4000
[    6.695458] RIP: 0010:[<ffffffffa01ae46b>]  [<ffffffffa01ae46b>]
ath10k_htc_connect_service+0x21b/0x420 [ath10k_core]


Micha=C5=82

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ath10k-bounces+kvalo=adurom.com@lists.infradead.org>
Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f])
 by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux))
 id 1c6akE-0000gw-LU
 for ath10k@lists.infradead.org; Tue, 15 Nov 2016 10:13:42 +0000
Received: by mail-wm0-x22f.google.com with SMTP id c184so21515763wmd.0
 for <ath10k@lists.infradead.org>; Tue, 15 Nov 2016 02:13:18 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1479141222-8493-4-git-send-email-erik.stromdahl@gmail.com>
References: <1479141222-8493-1-git-send-email-erik.stromdahl@gmail.com>
 <1479141222-8493-4-git-send-email-erik.stromdahl@gmail.com>
From: Michal Kazior <michal.kazior@tieto.com>
Date: Tue, 15 Nov 2016 11:13:15 +0100
Message-ID: <CA+BoTQmA0E+N46E3XkpqVPXSVkQNyZj2Qzrizk8iLdYzVthNQg@mail.gmail.com>
Subject: Re: [RFC 03/12] ath10k: htc: Changed order of wait target and ep
 connect
List-Id: <ath10k.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/ath10k>,
 <mailto:ath10k-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/ath10k/>
List-Post: <mailto:ath10k@lists.infradead.org>
List-Help: <mailto:ath10k-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/ath10k>,
 <mailto:ath10k-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Sender: "ath10k" <ath10k-bounces@lists.infradead.org>
Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org
To: Erik Stromdahl <erik.stromdahl@gmail.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>, linux-wireless <linux-wireless@vger.kernel.org>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>

T24gMTQgTm92ZW1iZXIgMjAxNiBhdCAxNzozMywgRXJpayBTdHJvbWRhaGwgPGVyaWsuc3Ryb21k
YWhsQGdtYWlsLmNvbT4gd3JvdGU6Cj4gVGhpcyBwYXRjaCBjaGFuZ2VzIHRoZSBvcmRlciBpbiB3
aGljaCB0aGUgZHJpdmVyIHdhaXRzIGZvciB0aGUKPiB0YXJnZXQgdG8gYmVjb21lIHJlYWR5IGFu
ZCB0aGUgc2VydmljZSBjb25uZWN0IG9mIHRoZSBIVEMKPiBjb250cm9sIHNlcnZpY2UuCj4KPiBU
aGUgSFRDIGNvbnRyb2wgc2VydmljZSBpcyBjb25uZWN0ZWQgYmVmb3JlIHRoZSBkcml2ZXIgc3Rh
cnRzCj4gd2FpdGluZyBmb3IgdGhlIEhUQyByZWFkeSBjb250cm9sIG1lc3NhZ2UuCj4KPiBUaGUg
cmVhc29uIGZvciB0aGlzIGlzIHRoYXQgdGhlIEhUQyByZWFkeSBjb250cm9sIG1lc3NhZ2UgaXMK
PiB0cmFuc21pdHRlZCBvbiBFUCAwIGFuZCB0aGF0IHNkaW8vbWJveCBiYXNlZCBzeXN0ZW1zIHdp
bGwgaWdub3JlCj4gbWVzc2FnZXMgcmVjZWl2ZWQgb24gdW5jb25uZWN0ZWQgZW5kcG9pbnRzLgo+
Cj4gU2lnbmVkLW9mZi1ieTogRXJpayBTdHJvbWRhaGwgPGVyaWsuc3Ryb21kYWhsQGdtYWlsLmNv
bT4KPiAtLS0KPiAgZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9odGMuYyB8ICAgMzIg
KysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE2IGlu
c2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0
L3dpcmVsZXNzL2F0aC9hdGgxMGsvaHRjLmMgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRo
MTBrL2h0Yy5jCj4gaW5kZXggZTNmN2JmNC4uNzI1NzM2NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz
L25ldC93aXJlbGVzcy9hdGgvYXRoMTBrL2h0Yy5jCj4gKysrIGIvZHJpdmVycy9uZXQvd2lyZWxl
c3MvYXRoL2F0aDEway9odGMuYwo+IEBAIC02MDYsNiArNjA2LDIyIEBAIGludCBhdGgxMGtfaHRj
X3dhaXRfdGFyZ2V0KHN0cnVjdCBhdGgxMGtfaHRjICpodGMpCj4gICAgICAgICB1MTYgY3JlZGl0
X2NvdW50Owo+ICAgICAgICAgdTE2IGNyZWRpdF9zaXplOwo+Cj4gKyAgICAgICAvKiBzZXR1cCBv
dXIgcHNldWRvIEhUQyBjb250cm9sIGVuZHBvaW50IGNvbm5lY3Rpb24gKi8KPiArICAgICAgIG1l
bXNldCgmY29ubl9yZXEsIDAsIHNpemVvZihjb25uX3JlcSkpOwo+ICsgICAgICAgbWVtc2V0KCZj
b25uX3Jlc3AsIDAsIHNpemVvZihjb25uX3Jlc3ApKTsKPiArICAgICAgIGNvbm5fcmVxLmVwX29w
cy5lcF90eF9jb21wbGV0ZSA9IGF0aDEwa19odGNfY29udHJvbF90eF9jb21wbGV0ZTsKPiArICAg
ICAgIGNvbm5fcmVxLmVwX29wcy5lcF9yeF9jb21wbGV0ZSA9IGF0aDEwa19odGNfY29udHJvbF9y
eF9jb21wbGV0ZTsKPiArICAgICAgIGNvbm5fcmVxLm1heF9zZW5kX3F1ZXVlX2RlcHRoID0gQVRI
MTBLX05VTV9DT05UUk9MX1RYX0JVRkZFUlM7Cj4gKyAgICAgICBjb25uX3JlcS5zZXJ2aWNlX2lk
ID0gQVRIMTBLX0hUQ19TVkNfSURfUlNWRF9DVFJMOwo+ICsKPiArICAgICAgIC8qIGNvbm5lY3Qg
ZmFrZSBzZXJ2aWNlICovCj4gKyAgICAgICBzdGF0dXMgPSBhdGgxMGtfaHRjX2Nvbm5lY3Rfc2Vy
dmljZShodGMsICZjb25uX3JlcSwgJmNvbm5fcmVzcCk7Cj4gKyAgICAgICBpZiAoc3RhdHVzKSB7
Cj4gKyAgICAgICAgICAgICAgIGF0aDEwa19lcnIoYXIsICJjb3VsZCBub3QgY29ubmVjdCB0byBo
dGMgc2VydmljZSAoJWQpXG4iLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXR1cyk7
Cj4gKyAgICAgICAgICAgICAgIHJldHVybiBzdGF0dXM7Cj4gKyAgICAgICB9Cj4gKwoKSG93IGlz
IHRoaXMgc3VwcG9zZWQgdG8gd29yaz8gYXRoMTBrX2h0Y19jb25uZWN0X3NlcnZpY2UoKSByZXF1
aXJlcwpodGMtPnRhcmdldF9jcmVkaXRfc2l6ZSB0byBjb21wdXRlIHR4X2NyZWRpdHNfcGVyX21h
eF9tZXNzYWdlLiBPciBhbSBJCm1pc3Npbmcgc29tZXRoaW5nPyBBcHBseWluZyB0aGlzIHBhdGNo
IGFsb25lIHJlc3VsdHMgaW46CgpbICAgIDYuNjgwMTAxXSBkaXZpZGUgZXJyb3I6IDAwMDAgWyMx
XSBTTVAKWyAgICA2LjY4MTM0Ml0gTW9kdWxlcyBsaW5rZWQgaW46IGF0aDEwa19wY2koTykgYXRo
MTBrX2NvcmUoTykgYXRoCm1hYzgwMjExIGNmZzgwMjExClsgICAgNi42ODQ4NzZdIENQVTogMyBQ
SUQ6IDgyMyBDb21tOiBrd29ya2VyL3U4OjIgVGFpbnRlZDogRyAgICAgICAgVwpPICAgIDQuOS4w
LXJjNC13dC1hdGgrICM3OQpbICAgIDYuNjg4MDUxXSBIYXJkd2FyZSBuYW1lOiBRRU1VIFN0YW5k
YXJkIFBDIChpNDQwRlggKyBQSUlYLCAxOTk2KSwKQklPUyAxLjcuNS0yMDE0MDUzMV8wODMwMzAt
Z2FuZGFsZiAwNC8wMS8yMDE0ClsgICAgNi42OTE2NDRdIFdvcmtxdWV1ZTogYXRoMTBrX3dxIGF0
aDEwa19jb3JlX3JlZ2lzdGVyX3dvcmsgW2F0aDEwa19jb3JlXQpbICAgIDYuNjk0MzA5XSB0YXNr
OiBmZmZmODgwMDBhMTkwMDAwIHRhc2suc3RhY2s6IGZmZmZjOTAwMDA2ZDQwMDAKWyAgICA2LjY5
NTQ1OF0gUklQOiAwMDEwOls8ZmZmZmZmZmZhMDFhZTQ2Yj5dICBbPGZmZmZmZmZmYTAxYWU0NmI+
XQphdGgxMGtfaHRjX2Nvbm5lY3Rfc2VydmljZSsweDIxYi8weDQyMCBbYXRoMTBrX2NvcmVdCgoK
TWljaGHFggoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K
YXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz
dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo=