From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wg0-f45.google.com ([74.125.82.45]:33298 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972AbaHSJhM convert rfc822-to-8bit (ORCPT ); Tue, 19 Aug 2014 05:37:12 -0400 Received: by mail-wg0-f45.google.com with SMTP id x12so6250729wgg.16 for ; Tue, 19 Aug 2014 02:37:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20140819082307.16842.21519.stgit@potku.adurom.net> References: <20140819082038.16842.46876.stgit@potku.adurom.net> <20140819082307.16842.21519.stgit@potku.adurom.net> Date: Tue, 19 Aug 2014 11:37:10 +0200 Message-ID: (sfid-20140819_113718_232408_F7438EFC) Subject: Re: [PATCH v7 4/8] ath10k: save firmware stack upon firmware crash From: Michal Kazior To: Kalle Valo Cc: "ath10k@lists.infradead.org" , linux-wireless Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 19 August 2014 10:23, Kalle Valo wrote: > From: Ben Greear > > Should help debug firmware crashes, and give users a way > to provide some useful debug reports to firmware developers. > > Signed-off-by: Ben Greear > Signed-off-by: Kalle Valo > --- [...] > +/* Save the main firmware stack */ > +static void ath10k_pci_dump_stack(struct ath10k *ar, > + struct ath10k_fw_crash_data *crash_data) > +{ > + lockdep_assert_held(&ar->data_lock); > + > + BUILD_BUG_ON(ATH10K_FW_STACK_SIZE % 4); > + > + ath10k_pci_diag_read_hi(ar, crash_data->stack_buf, > + hi_stack, ATH10K_FW_STACK_SIZE); Current master tree performs an implicit byte swap so the stack read from target will be in host endianess. IOW on big-endian host you'll messed up data and there's no indication of endianess anymore. Michał From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XJfrB-0002cw-OT for ath10k@lists.infradead.org; Tue, 19 Aug 2014 09:37:34 +0000 Received: by mail-wi0-f182.google.com with SMTP id d1so4969641wiv.9 for ; Tue, 19 Aug 2014 02:37:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20140819082307.16842.21519.stgit@potku.adurom.net> References: <20140819082038.16842.46876.stgit@potku.adurom.net> <20140819082307.16842.21519.stgit@potku.adurom.net> Date: Tue, 19 Aug 2014 11:37:10 +0200 Message-ID: Subject: Re: [PATCH v7 4/8] ath10k: save firmware stack upon firmware crash From: Michal Kazior List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: linux-wireless , "ath10k@lists.infradead.org" T24gMTkgQXVndXN0IDIwMTQgMTA6MjMsIEthbGxlIFZhbG8gPGt2YWxvQHFjYS5xdWFsY29tbS5j b20+IHdyb3RlOgo+IEZyb206IEJlbiBHcmVlYXIgPGdyZWVhcmJAY2FuZGVsYXRlY2guY29tPgo+ Cj4gU2hvdWxkIGhlbHAgZGVidWcgZmlybXdhcmUgY3Jhc2hlcywgYW5kIGdpdmUgdXNlcnMgYSB3 YXkKPiB0byBwcm92aWRlIHNvbWUgdXNlZnVsIGRlYnVnIHJlcG9ydHMgdG8gZmlybXdhcmUgZGV2 ZWxvcGVycy4KPgo+IFNpZ25lZC1vZmYtYnk6IEJlbiBHcmVlYXIgPGdyZWVhcmJAY2FuZGVsYXRl Y2guY29tPgo+IFNpZ25lZC1vZmYtYnk6IEthbGxlIFZhbG8gPGt2YWxvQHFjYS5xdWFsY29tbS5j b20+Cj4gLS0tClsuLi5dCj4gKy8qIFNhdmUgdGhlIG1haW4gZmlybXdhcmUgc3RhY2sgKi8KPiAr c3RhdGljIHZvaWQgYXRoMTBrX3BjaV9kdW1wX3N0YWNrKHN0cnVjdCBhdGgxMGsgKmFyLAo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgYXRoMTBrX2Z3X2NyYXNoX2Rh dGEgKmNyYXNoX2RhdGEpCj4gK3sKPiArICAgICAgIGxvY2tkZXBfYXNzZXJ0X2hlbGQoJmFyLT5k YXRhX2xvY2spOwo+ICsKPiArICAgICAgIEJVSUxEX0JVR19PTihBVEgxMEtfRldfU1RBQ0tfU0la RSAlIDQpOwo+ICsKPiArICAgICAgIGF0aDEwa19wY2lfZGlhZ19yZWFkX2hpKGFyLCBjcmFzaF9k YXRhLT5zdGFja19idWYsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBoaV9zdGFj aywgQVRIMTBLX0ZXX1NUQUNLX1NJWkUpOwoKQ3VycmVudCBtYXN0ZXIgdHJlZSBwZXJmb3JtcyBh biBpbXBsaWNpdCBieXRlIHN3YXAgc28gdGhlIHN0YWNrIHJlYWQKZnJvbSB0YXJnZXQgd2lsbCBi ZSBpbiBob3N0IGVuZGlhbmVzcy4gSU9XIG9uIGJpZy1lbmRpYW4gaG9zdCB5b3UnbGwKbWVzc2Vk IHVwIGRhdGEgYW5kIHRoZXJlJ3Mgbm8gaW5kaWNhdGlvbiBvZiBlbmRpYW5lc3MgYW55bW9yZS4K CgpNaWNoYcWCCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg==