From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f43.google.com ([74.125.82.43]:35818 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854AbcC3JWx convert rfc822-to-8bit (ORCPT ); Wed, 30 Mar 2016 05:22:53 -0400 Received: by mail-wm0-f43.google.com with SMTP id 191so81400287wmq.0 for ; Wed, 30 Mar 2016 02:22:52 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <56FAA518.2000805@candelatech.com> References: <1458898743-21118-1-git-send-email-michal.kazior@tieto.com> <56FAA518.2000805@candelatech.com> Date: Wed, 30 Mar 2016 11:22:51 +0200 Message-ID: (sfid-20160330_112257_434853_58AF3996) Subject: Re: [RFC] ath10k: implement dql for htt tx From: Michal Kazior To: Ben Greear Cc: Dave Taht , "ath10k@lists.infradead.org" , linux-wireless , make-wifi-fast@lists.bufferbloat.net, "codel@lists.bufferbloat.net" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 29 March 2016 at 17:54, Ben Greear wrote: > On 03/29/2016 12:49 AM, Michal Kazior wrote: > >>> if you are getting a pure codel result of 160ms, that means the >>> implementation is broken. But I think (after having read your >>> description twice), the baseline result today of 160ms of queuing was >>> with a fq_codel *qdisc* doing the work on top of huge buffers, >> >> >> Yes. The 160ms is with fq_codel qdisc with ath10k doing DQL at 6mbps. >> Without DQL ath10k would clog up all tx slots (1424 of them) with >> frames. At 6mbps you typically want/need a handful (5-10) of frames to >> be queued. > > > Have you actually verified you can use all tx slots? It works in most cases. I guess you're suspecting some of your tx(flushing?) problems might be induced by overcommiting? > The way the > firmware uses it's tx buffers I think you may not be able to actually > do that...and in practice, you will get a lot fewer usable tx-buffers > than configured.... Could be, e.g. I'm aware management frames are kind of a special case in recent firmware revisions. What would/do you expect firmware would/will do when we overcommit? The driver does advertise number of HTT tx slots so I would expect it to work fine if it didn't crash during boot. Michał From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1alCLK-0005Za-IH for ath10k@lists.infradead.org; Wed, 30 Mar 2016 09:23:15 +0000 Received: by mail-wm0-x232.google.com with SMTP id r72so90496072wmg.0 for ; Wed, 30 Mar 2016 02:22:53 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <56FAA518.2000805@candelatech.com> References: <1458898743-21118-1-git-send-email-michal.kazior@tieto.com> <56FAA518.2000805@candelatech.com> Date: Wed, 30 Mar 2016 11:22:51 +0200 Message-ID: Subject: Re: [RFC] ath10k: implement dql for htt tx From: Michal Kazior List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Ben Greear Cc: make-wifi-fast@lists.bufferbloat.net, "codel@lists.bufferbloat.net" , linux-wireless , Dave Taht , "ath10k@lists.infradead.org" T24gMjkgTWFyY2ggMjAxNiBhdCAxNzo1NCwgQmVuIEdyZWVhciA8Z3JlZWFyYkBjYW5kZWxhdGVj aC5jb20+IHdyb3RlOgo+IE9uIDAzLzI5LzIwMTYgMTI6NDkgQU0sIE1pY2hhbCBLYXppb3Igd3Jv dGU6Cj4KPj4+IGlmIHlvdSBhcmUgZ2V0dGluZyBhIHB1cmUgY29kZWwgcmVzdWx0IG9mIDE2MG1z LCB0aGF0IG1lYW5zIHRoZQo+Pj4gaW1wbGVtZW50YXRpb24gaXMgYnJva2VuLiBCdXQgSSB0aGlu ayAoYWZ0ZXIgaGF2aW5nIHJlYWQgeW91cgo+Pj4gZGVzY3JpcHRpb24gdHdpY2UpLCB0aGUgYmFz ZWxpbmUgcmVzdWx0IHRvZGF5IG9mIDE2MG1zIG9mIHF1ZXVpbmcgd2FzCj4+PiB3aXRoIGEgZnFf Y29kZWwgKnFkaXNjKiBkb2luZyB0aGUgd29yayBvbiB0b3Agb2YgaHVnZSBidWZmZXJzLAo+Pgo+ Pgo+PiBZZXMuIFRoZSAxNjBtcyBpcyB3aXRoIGZxX2NvZGVsIHFkaXNjIHdpdGggYXRoMTBrIGRv aW5nIERRTCBhdCA2bWJwcy4KPj4gV2l0aG91dCBEUUwgYXRoMTBrIHdvdWxkIGNsb2cgdXAgYWxs IHR4IHNsb3RzICgxNDI0IG9mIHRoZW0pIHdpdGgKPj4gZnJhbWVzLiBBdCA2bWJwcyB5b3UgdHlw aWNhbGx5IHdhbnQvbmVlZCBhIGhhbmRmdWwgKDUtMTApIG9mIGZyYW1lcyB0bwo+PiBiZSBxdWV1 ZWQuCj4KPgo+IEhhdmUgeW91IGFjdHVhbGx5IHZlcmlmaWVkIHlvdSBjYW4gdXNlIGFsbCB0eCBz bG90cz8KCkl0IHdvcmtzIGluIG1vc3QgY2FzZXMuIEkgZ3Vlc3MgeW91J3JlIHN1c3BlY3Rpbmcg c29tZSBvZiB5b3VyCnR4KGZsdXNoaW5nPykgcHJvYmxlbXMgbWlnaHQgYmUgaW5kdWNlZCBieSBv dmVyY29tbWl0aW5nPwoKPiBUaGUgd2F5IHRoZQo+IGZpcm13YXJlIHVzZXMgaXQncyB0eCBidWZm ZXJzIEkgdGhpbmsgeW91IG1heSBub3QgYmUgYWJsZSB0byBhY3R1YWxseQo+IGRvIHRoYXQuLi5h bmQgaW4gcHJhY3RpY2UsIHlvdSB3aWxsIGdldCBhIGxvdCBmZXdlciB1c2FibGUgdHgtYnVmZmVy cwo+IHRoYW4gY29uZmlndXJlZC4uLi4KCkNvdWxkIGJlLCBlLmcuIEknbSBhd2FyZSBtYW5hZ2Vt ZW50IGZyYW1lcyBhcmUga2luZCBvZiBhIHNwZWNpYWwgY2FzZQppbiByZWNlbnQgZmlybXdhcmUg cmV2aXNpb25zLgoKV2hhdCB3b3VsZC9kbyB5b3UgZXhwZWN0IGZpcm13YXJlIHdvdWxkL3dpbGwg ZG8gd2hlbiB3ZSBvdmVyY29tbWl0PwpUaGUgZHJpdmVyIGRvZXMgYWR2ZXJ0aXNlIG51bWJlciBv ZiBIVFQgdHggc2xvdHMgc28gSSB3b3VsZCBleHBlY3QgaXQKdG8gd29yayBmaW5lIGlmIGl0IGRp ZG4ndCBjcmFzaCBkdXJpbmcgYm9vdC4KCgpNaWNoYcWCCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vYXRoMTBrCg==