From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f49.google.com ([74.125.82.49]:35701 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966504AbcKOKTW (ORCPT ); Tue, 15 Nov 2016 05:19:22 -0500 Received: by mail-wm0-f49.google.com with SMTP id a197so156779985wmd.0 for ; Tue, 15 Nov 2016 02:19:22 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1479141222-8493-5-git-send-email-erik.stromdahl@gmail.com> References: <1479141222-8493-1-git-send-email-erik.stromdahl@gmail.com> <1479141222-8493-5-git-send-email-erik.stromdahl@gmail.com> From: Michal Kazior Date: Tue, 15 Nov 2016 11:19:20 +0100 Message-ID: (sfid-20161115_111932_665747_ECC4B5B6) Subject: Re: [RFC 04/12] ath10k: htc: refactorization To: Erik Stromdahl Cc: Kalle Valo , linux-wireless , "ath10k@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 14 November 2016 at 17:33, Erik Stromdahl wro= te: > Code refactorization: > > Moved the code for ep 0 in ath10k_htc_rx_completion_handler > to ath10k_htc_control_rx_complete. > > This eases the implementation of SDIO/mbox significantly since > the ep_rx_complete cb is invoked directly from the SDIO/mbox > hif layer. > > Since the ath10k_htc_control_rx_complete already is present > (only containing a warning message) there is no reason for not > using it (instead of having a special case for ep 0 in > ath10k_htc_rx_completion_handler). This should be squashed with Patch 3 since it's inseparable part of the same refactorization. Micha=C5=82 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c6aq7-0004Z6-63 for ath10k@lists.infradead.org; Tue, 15 Nov 2016 10:19:44 +0000 Received: by mail-wm0-x22b.google.com with SMTP id g23so156922016wme.1 for ; Tue, 15 Nov 2016 02:19:22 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1479141222-8493-5-git-send-email-erik.stromdahl@gmail.com> References: <1479141222-8493-1-git-send-email-erik.stromdahl@gmail.com> <1479141222-8493-5-git-send-email-erik.stromdahl@gmail.com> From: Michal Kazior Date: Tue, 15 Nov 2016 11:19:20 +0100 Message-ID: Subject: Re: [RFC 04/12] ath10k: htc: refactorization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Erik Stromdahl Cc: Kalle Valo , linux-wireless , "ath10k@lists.infradead.org" T24gMTQgTm92ZW1iZXIgMjAxNiBhdCAxNzozMywgRXJpayBTdHJvbWRhaGwgPGVyaWsuc3Ryb21k YWhsQGdtYWlsLmNvbT4gd3JvdGU6Cj4gQ29kZSByZWZhY3Rvcml6YXRpb246Cj4KPiBNb3ZlZCB0 aGUgY29kZSBmb3IgZXAgMCBpbiBhdGgxMGtfaHRjX3J4X2NvbXBsZXRpb25faGFuZGxlcgo+IHRv IGF0aDEwa19odGNfY29udHJvbF9yeF9jb21wbGV0ZS4KPgo+IFRoaXMgZWFzZXMgdGhlIGltcGxl bWVudGF0aW9uIG9mIFNESU8vbWJveCBzaWduaWZpY2FudGx5IHNpbmNlCj4gdGhlIGVwX3J4X2Nv bXBsZXRlIGNiIGlzIGludm9rZWQgZGlyZWN0bHkgZnJvbSB0aGUgU0RJTy9tYm94Cj4gaGlmIGxh eWVyLgo+Cj4gU2luY2UgdGhlIGF0aDEwa19odGNfY29udHJvbF9yeF9jb21wbGV0ZSBhbHJlYWR5 IGlzIHByZXNlbnQKPiAob25seSBjb250YWluaW5nIGEgd2FybmluZyBtZXNzYWdlKSB0aGVyZSBp cyBubyByZWFzb24gZm9yIG5vdAo+IHVzaW5nIGl0IChpbnN0ZWFkIG9mIGhhdmluZyBhIHNwZWNp YWwgY2FzZSBmb3IgZXAgMCBpbgo+IGF0aDEwa19odGNfcnhfY29tcGxldGlvbl9oYW5kbGVyKS4K ClRoaXMgc2hvdWxkIGJlIHNxdWFzaGVkIHdpdGggUGF0Y2ggMyBzaW5jZSBpdCdzIGluc2VwYXJh YmxlIHBhcnQgb2YKdGhlIHNhbWUgcmVmYWN0b3JpemF0aW9uLgoKCk1pY2hhxYIKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxp c3QKYXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9hdGgxMGsK