From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34053C4320E for ; Wed, 4 Aug 2021 01:54:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09D1760F8F for ; Wed, 4 Aug 2021 01:54:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234118AbhHDBzD (ORCPT ); Tue, 3 Aug 2021 21:55:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232506AbhHDBzC (ORCPT ); Tue, 3 Aug 2021 21:55:02 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D30DC061764 for ; Tue, 3 Aug 2021 18:54:50 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id g21so1505227edb.4 for ; Tue, 03 Aug 2021 18:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MwYC/1Gaei+t62tNQY4YFdCc3ENCGWe2M7gmqksCaew=; b=KHb4cAohmBF1wfyoLs/rl9cOV9WjJt9nG6P38g00AdqrxqLV5mua3SEFz/TSWaLCqs oH4d8ZTRnjv+7LOQHJ2pBW+uZuSvZRByXOwXRnPc39/EERKz9KXuz/K174nu9vFg+ZQK TL4g2fX+oge1hfeOB9BCHoi7Dvgl96FMp4AA8b4V4JkQBwmGssIOwB+yjnSeH+vR/6gn Damiwu22iVbNL+LuUSuyUQC30j3SUFER1qnBQwYcVsALj8ngBP3vTKh06LJnT+y+3Z3H eSnmKh09Cm7+6J2sRBuYoIyG4hnKb9KMoVUQ+7zdC2w7KL4BPXZAxUHb++++iemZVIJm MIWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MwYC/1Gaei+t62tNQY4YFdCc3ENCGWe2M7gmqksCaew=; b=II5KIpPNG7Dc/pBlqd5SgoNgd1itDivhhLoHRTwR1Vm1eAuoQnm1Or17QmLRALL1C5 krX0xZlwtvxXHFCyCd/KiVaY87SiNx18YEF+Iicv/CIW0Rp8KNeTiahDgaK0AFcemQWr sJxf2AKg6Iqd5ZQduoD1tW1xqQ3Yx+LMzK69tnF95xfWfT3Fq7FtzN4jFhW4w1UeN/iB ZT62f4sb6vU7rBCbg8WSeFzne5RDdIhcFc+Wd+xkjIR7Gp/UWeZyaaIOX/05TMoiVKq6 Ko17ls9gLXAVo4yzWnW1AMWagpwUp1ouRLFLGwC2BZPefpZuhdpS4cYL0tatQl7c6x25 JopA== X-Gm-Message-State: AOAM530fHfDvsSZpVMnpxCPxXO9LPxY1H1p7MTXEa17i8yEOkUIz0lg+ BHvujXC0oW3jGym4nQ5Mlf7rtXNIi9+mP6SRB4WIAw== X-Google-Smtp-Source: ABdhPJyDcdBun5ArBBclPVQ3zL16nLtGBhsP9+jwmxqLDtzBCI+VKFyx/007H8oKIjwZRLdTTG+gAaRt9+6z8JS0H20= X-Received: by 2002:a05:6402:2043:: with SMTP id bc3mr29167190edb.62.1628042089213; Tue, 03 Aug 2021 18:54:49 -0700 (PDT) MIME-Version: 1.0 References: <90287685c13300972ea84de93d1f3f900373f9fe.1626252248.git.zhansayabagdaulet@gmail.com> In-Reply-To: <90287685c13300972ea84de93d1f3f900373f9fe.1626252248.git.zhansayabagdaulet@gmail.com> From: Pavel Tatashin Date: Tue, 3 Aug 2021 21:54:13 -0400 Message-ID: Subject: Re: [PATCH v2 1/4] selftests: vm: add KSM merge test To: Zhansaya Bagdauletkyzy Cc: shuah@kernel.org, Andrew Morton , LKML , linux-kselftest@vger.kernel.org, linux-mm , Tyler Hicks Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 14, 2021 at 4:56 AM Zhansaya Bagdauletkyzy wrote: > > Add check_ksm_merge() function to check the basic merging feature of > KSM. First, some number of identical pages are allocated and the > MADV_MERGEABLE advice is given to merge these pages. Then, pages_shared > and pages_sharing values are compared with the expected numbers using > assert_ksm_pages_count() function. The number of pages can be changed > using -p option. > > Signed-off-by: Zhansaya Bagdauletkyzy No comments, because I have already reviewed this series for Zhansaya as part of the Outreachy internship, so: Reviewed-by: Pavel Tatashin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BA6BC4338F for ; Wed, 4 Aug 2021 01:54:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E514560F8F for ; Wed, 4 Aug 2021 01:54:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E514560F8F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 862F58D0016; Tue, 3 Aug 2021 21:54:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ECDC8D000F; Tue, 3 Aug 2021 21:54:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B4CE8D0016; Tue, 3 Aug 2021 21:54:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 4CBE38D000F for ; Tue, 3 Aug 2021 21:54:51 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E07302042C for ; Wed, 4 Aug 2021 01:54:50 +0000 (UTC) X-FDA: 78435729540.20.99A91D9 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf18.hostedemail.com (Postfix) with ESMTP id 8B19A400A5B2 for ; Wed, 4 Aug 2021 01:54:50 +0000 (UTC) Received: by mail-ed1-f49.google.com with SMTP id x14so1448119edr.12 for ; Tue, 03 Aug 2021 18:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MwYC/1Gaei+t62tNQY4YFdCc3ENCGWe2M7gmqksCaew=; b=KHb4cAohmBF1wfyoLs/rl9cOV9WjJt9nG6P38g00AdqrxqLV5mua3SEFz/TSWaLCqs oH4d8ZTRnjv+7LOQHJ2pBW+uZuSvZRByXOwXRnPc39/EERKz9KXuz/K174nu9vFg+ZQK TL4g2fX+oge1hfeOB9BCHoi7Dvgl96FMp4AA8b4V4JkQBwmGssIOwB+yjnSeH+vR/6gn Damiwu22iVbNL+LuUSuyUQC30j3SUFER1qnBQwYcVsALj8ngBP3vTKh06LJnT+y+3Z3H eSnmKh09Cm7+6J2sRBuYoIyG4hnKb9KMoVUQ+7zdC2w7KL4BPXZAxUHb++++iemZVIJm MIWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MwYC/1Gaei+t62tNQY4YFdCc3ENCGWe2M7gmqksCaew=; b=UiuwOhIHy466Yb27GaasQJZdXHn7io9oJhp3s5Az+3p/sDuuIVlggpxEuYsQgudiVt hv+Yc08F90Xbu7eR64IasCTIDx5zGM7ijDdYCIaBYkI7pEdutG9jT/qTYDGAa5K8lDcy lxEAq/qGV1Nlm8NmqrnopfYW692Irdam6IA758AGkeZGmXT/wSmMI1mwVPnTV6IgPt5V S5Fq2T5N6eLSu34l8fKM1g5L+tb0BNhMN5TQiBmtqLieYDa8xJ+nBZIkKfSqlzR0NbCR l6MyhlOjZ7QhSwAnAZhpBk3PSMBnyxswnqovfYyYX+B1AlTJGtaIojMxUfh0GE288a/A AcJQ== X-Gm-Message-State: AOAM5300D6JRu8/bOQqilu3ds+cnXC/JZvm+tIuPxfA/gcs9GMWqc0Bx PT5ClcuBhiITiU4yUG4fjevZl2/adL1PybBjL9AynQ== X-Google-Smtp-Source: ABdhPJyDcdBun5ArBBclPVQ3zL16nLtGBhsP9+jwmxqLDtzBCI+VKFyx/007H8oKIjwZRLdTTG+gAaRt9+6z8JS0H20= X-Received: by 2002:a05:6402:2043:: with SMTP id bc3mr29167190edb.62.1628042089213; Tue, 03 Aug 2021 18:54:49 -0700 (PDT) MIME-Version: 1.0 References: <90287685c13300972ea84de93d1f3f900373f9fe.1626252248.git.zhansayabagdaulet@gmail.com> In-Reply-To: <90287685c13300972ea84de93d1f3f900373f9fe.1626252248.git.zhansayabagdaulet@gmail.com> From: Pavel Tatashin Date: Tue, 3 Aug 2021 21:54:13 -0400 Message-ID: Subject: Re: [PATCH v2 1/4] selftests: vm: add KSM merge test To: Zhansaya Bagdauletkyzy Cc: shuah@kernel.org, Andrew Morton , LKML , linux-kselftest@vger.kernel.org, linux-mm , Tyler Hicks Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8B19A400A5B2 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=KHb4cAoh; dmarc=none; spf=pass (imf18.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com X-Stat-Signature: akii4c39rcf3zoniowhzyiq4extr9ar5 X-HE-Tag: 1628042090-860843 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 14, 2021 at 4:56 AM Zhansaya Bagdauletkyzy wrote: > > Add check_ksm_merge() function to check the basic merging feature of > KSM. First, some number of identical pages are allocated and the > MADV_MERGEABLE advice is given to merge these pages. Then, pages_shared > and pages_sharing values are compared with the expected numbers using > assert_ksm_pages_count() function. The number of pages can be changed > using -p option. > > Signed-off-by: Zhansaya Bagdauletkyzy No comments, because I have already reviewed this series for Zhansaya as part of the Outreachy internship, so: Reviewed-by: Pavel Tatashin