From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 500A8C433E4 for ; Fri, 15 May 2020 19:40:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B21E20709 for ; Fri, 15 May 2020 19:40:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="EQXfVFJ4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726646AbgEOTkx (ORCPT ); Fri, 15 May 2020 15:40:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726610AbgEOTkw (ORCPT ); Fri, 15 May 2020 15:40:52 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4B4CC05BD0B for ; Fri, 15 May 2020 12:40:51 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id h15so3190704edv.2 for ; Fri, 15 May 2020 12:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HHca1qoV7do/YHj6VhiHa0wv0gL1FKGrqV5m6xaYOco=; b=EQXfVFJ4yz515JshhnvlO7USDVNFwG69NR5tuhWjf7zaSGV2LSZOG/FpNAtUosLSnU 9ts0wbGytpuSheRP3ZoyHaJVy+JsQ1Z1Cvaptopb1n0wqaABjBwhlg6Tv1gRZWEWU5N7 Xf1NHtzI2/d6wc9/JoXFFotJC6AdETHGlu7ZPHF46mQb5LSagZDXg01u6m6RSJHqGCsX G8zguFhZtGVf+wbDNstxQsF4RSs6m0HY3WenqGd6CGw5+MyM67ss838sKv8JWxkfdLV5 BSMpNrRreffqc91pQEzZgU61/CDkmb2Sw9K1pJvrh01opTu3O/0yWLHR5K/QMsJImlTO jHLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HHca1qoV7do/YHj6VhiHa0wv0gL1FKGrqV5m6xaYOco=; b=SQylckxI4kW3Ipy+yLm+4xgb1GpEUvvE6kXS2HOVdVAUzv8RjEBr0prqe1aKX9S5FP mqYI3zI0grFUjZoyMMpDeMu54exWnCi66r5o+sE2ixwRItVC+kxVQKnojEnlt3r+v/XG IBA7+eO15XtOWksaXc1cQ924H0E2XDsYT8AM4lFfvdJCLXhgUGfSvfYdj9U/Ob4emafc Srib83/eC7p5uBjKw07eF7lhCJX1o9gh7NcAJqud9a/F2PWH6GXN4I+ze09Edpgh2arF rY/d2WvrrtoCNMZCHqiV1sMli+FtUKUHB4cHfvKIY2ecXWg3PJLhqCWLitdbJaZeobPl bXLg== X-Gm-Message-State: AOAM533hWrRvwoPAvyjg0JIQxO9hlW1zBTx4fSGKh+Xu/ntDgr1PNACm ea28CMS/i3YoAeubvA3efxYcD7wClBlnlRahGX7p8w== X-Google-Smtp-Source: ABdhPJy3hW9KN8C+0k3e1QtNg/q5jcxANsOo4JOf1UIs/QMiOLnU+PzMoJv7/O4icSIDCXxitbkF0rZPLnkBSitoNmc= X-Received: by 2002:a05:6402:31b1:: with SMTP id dj17mr4543330edb.142.1589571650510; Fri, 15 May 2020 12:40:50 -0700 (PDT) MIME-Version: 1.0 References: <20200515184434.8470-1-keescook@chromium.org> <20200515184434.8470-6-keescook@chromium.org> In-Reply-To: <20200515184434.8470-6-keescook@chromium.org> From: Pavel Tatashin Date: Fri, 15 May 2020 15:40:14 -0400 Message-ID: Subject: Re: [PATCH v4 5/6] pstore/ram: Introduce max_reason and convert dump_oops To: Kees Cook Cc: Petr Mladek , Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Benson Leung , Rob Herring , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Enric Balletbo i Serra , Sergey Senozhatsky , Steven Rostedt , Linux Doc Mailing List , LKML , devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pdata.dump_oops = dump_oops; > + /* If "max_reason" is set, its value has priority over "dump_oops". */ > + if (ramoops_max_reason != -1) > + pdata.max_reason = ramoops_max_reason; (ramoops_max_reason >= 0) might make more sense here, we do not want negative max_reason even if it was provided by the user. Otherwise the series looks good. Thank you, Pasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC2F3C433DF for ; Fri, 15 May 2020 19:43:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C35020728 for ; Fri, 15 May 2020 19:43:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="EQXfVFJ4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C35020728 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49NzN520NgzDr6W for ; Sat, 16 May 2020 05:43:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=soleen.com (client-ip=2a00:1450:4864:20::543; helo=mail-ed1-x543.google.com; envelope-from=pasha.tatashin@soleen.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=EQXfVFJ4; dkim-atps=neutral Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49NzKd5690zDr1Q for ; Sat, 16 May 2020 05:40:53 +1000 (AEST) Received: by mail-ed1-x543.google.com with SMTP id bs4so3174272edb.6 for ; Fri, 15 May 2020 12:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HHca1qoV7do/YHj6VhiHa0wv0gL1FKGrqV5m6xaYOco=; b=EQXfVFJ4yz515JshhnvlO7USDVNFwG69NR5tuhWjf7zaSGV2LSZOG/FpNAtUosLSnU 9ts0wbGytpuSheRP3ZoyHaJVy+JsQ1Z1Cvaptopb1n0wqaABjBwhlg6Tv1gRZWEWU5N7 Xf1NHtzI2/d6wc9/JoXFFotJC6AdETHGlu7ZPHF46mQb5LSagZDXg01u6m6RSJHqGCsX G8zguFhZtGVf+wbDNstxQsF4RSs6m0HY3WenqGd6CGw5+MyM67ss838sKv8JWxkfdLV5 BSMpNrRreffqc91pQEzZgU61/CDkmb2Sw9K1pJvrh01opTu3O/0yWLHR5K/QMsJImlTO jHLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HHca1qoV7do/YHj6VhiHa0wv0gL1FKGrqV5m6xaYOco=; b=MRjvqznpiB91eeB14/9RtZDbW9o5q7I/w/aBVD9HI+IxcuN6LmWxA/uFAxMcLKn/ba EN3mOQKDre8WUX4053n0d5yLdm7sdUkDDaa8xglFKIPGZr2YW9qqduxUVPPuGhAHMMYQ 8y73Ys+E98h/PvPN1/VHeFIrvPTrJkiYNTtPNCwxu5UXOWnqZmzeTjDX9bjAb7K41Iky aBoAv+prK2AbIuAL2eOkoZ0HLKVdSeRWMDxhlWAaRInVPzCj9VkZQT4rj8Yp08SiBDZN 2tcW+JkMHg1NAHwjszW6Xzsj7wBB8TZaZaGpSoMKDl5Gqf0a8MSY7trTEU2TBWUjm1dr MvbQ== X-Gm-Message-State: AOAM530nyDGJiwGQzFQ3hpP3l4fCwOjEjzbn8++np3SPbkpi6NW4MHOV gjBmTuhNUbjw+52TiCIRsZLqVqdKG7+HNoBjyzV35w== X-Google-Smtp-Source: ABdhPJy3hW9KN8C+0k3e1QtNg/q5jcxANsOo4JOf1UIs/QMiOLnU+PzMoJv7/O4icSIDCXxitbkF0rZPLnkBSitoNmc= X-Received: by 2002:a05:6402:31b1:: with SMTP id dj17mr4543330edb.142.1589571650510; Fri, 15 May 2020 12:40:50 -0700 (PDT) MIME-Version: 1.0 References: <20200515184434.8470-1-keescook@chromium.org> <20200515184434.8470-6-keescook@chromium.org> In-Reply-To: <20200515184434.8470-6-keescook@chromium.org> From: Pavel Tatashin Date: Fri, 15 May 2020 15:40:14 -0400 Message-ID: Subject: Re: [PATCH v4 5/6] pstore/ram: Introduce max_reason and convert dump_oops To: Kees Cook Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , Tony Luck , Jonathan Corbet , Anton Vorontsov , Linux Doc Mailing List , LKML , Steven Rostedt , Sergey Senozhatsky , devicetree@vger.kernel.org, Rob Herring , Paul Mackerras , Colin Cross , Enric Balletbo i Serra , linuxppc-dev@lists.ozlabs.org, Benson Leung Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" pdata.dump_oops = dump_oops; > + /* If "max_reason" is set, its value has priority over "dump_oops". */ > + if (ramoops_max_reason != -1) > + pdata.max_reason = ramoops_max_reason; (ramoops_max_reason >= 0) might make more sense here, we do not want negative max_reason even if it was provided by the user. Otherwise the series looks good. Thank you, Pasha