From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7239C41514 for ; Tue, 20 Aug 2019 11:42:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B5DB22D37 for ; Tue, 20 Aug 2019 11:42:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="YixUBs68" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729761AbfHTLmI (ORCPT ); Tue, 20 Aug 2019 07:42:08 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:40446 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729428AbfHTLmI (ORCPT ); Tue, 20 Aug 2019 07:42:08 -0400 Received: by mail-ed1-f68.google.com with SMTP id h8so5958296edv.7 for ; Tue, 20 Aug 2019 04:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3a3ksvO52CtO/ttkK+4sBJJjCffAnNgMq3ot08D8hTE=; b=YixUBs68BTWBicnObm8UhXLg9oTc2+ORLcfgUd/Du/W1MFNGMBmeO9v0CpCKPNDfOL IOv3P3Sy0KW3Cf/mHqmQhC5dYF048v5l9MKyEPipLYYbjwxD0H59P87oFZcAUxJs8Bpg TZ1aEoxr3qON74esiOLqh6pfyJNutI2zVrynCMtzDWFU5/3lq5/KWMFf5eqyhEf4R0t8 pbWvw0NqWOv3EnLSCIbWXXsihVYEJL1fI+6iT4Zmbmou9OHn04p1+7PzMZzZ7yyKCqyL Kk9JSwipQzT+aeLr8A97jVZmZOhpTYYMCBCuIaYQAxnOVqXF/8pnIkDuPnZxsqpfAfZv fUjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3a3ksvO52CtO/ttkK+4sBJJjCffAnNgMq3ot08D8hTE=; b=cZ+jtoZnPOZmCLIYyN3buUmD2e9l8uAnnYrFxURCt+jKeYf4JHSrCEcHyQ0rE3uzHE jfQgRf+2z/hcPa0/nw1VvmDr/pLeSdxtxlxdl+bY1uglRWeONmVq4440eaG4fZ18jkzl ZVsxMpmlZPN8KW+ZELGHkzLWqMgxKDxoCCNHi/RLlRjZCcmZ03DMSJRFmPev+ROSpv/b qZoKNy1aru21NekaZ2bfh0cYdPPd2UFnRRFC6blAcdt2juxU5+71CyxCwVtJ8tFhr9Gx w8X7llG0EIqrOSHotw26VLe7stzu1oAgk+E58Pkwxe57pOg3m5JX5lpqnIvKM6K44+Wc VaMQ== X-Gm-Message-State: APjAAAWTNGV99A+pQEOVqpbqDkfqSQlMpdb1G0z4UJeP9yxVBM3k1qva bXJaO7IFAmx7k4zoRyzfHPt7uZe3Q4lARTUccNN4hw== X-Google-Smtp-Source: APXvYqys5DbTiUd9mTqbI3sEh4h1TdEgJjNdpUHqISVmYQkhBiZ+C1YQY1SvjKZBeVx8+M4TD3mTf8Wtu+RfofBl0sA= X-Received: by 2002:a17:906:1112:: with SMTP id h18mr26088394eja.165.1566301326474; Tue, 20 Aug 2019 04:42:06 -0700 (PDT) MIME-Version: 1.0 References: <20190817024629.26611-1-pasha.tatashin@soleen.com> <20190817024629.26611-4-pasha.tatashin@soleen.com> <20190819155824.GE9927@lakrids.cambridge.arm.com> <20190820113000.GA49252@lakrids.cambridge.arm.com> In-Reply-To: <20190820113000.GA49252@lakrids.cambridge.arm.com> From: Pavel Tatashin Date: Tue, 20 Aug 2019 07:41:55 -0400 Message-ID: Subject: Re: [PATCH v2 03/14] arm64, hibernate: add trans_table public functions To: Mark Rutland Cc: James Morris , Sasha Levin , "Eric W. Biederman" , kexec mailing list , LKML , Jonathan Corbet , Catalin Marinas , will@kernel.org, Linux ARM , Marc Zyngier , James Morse , Vladimir Murzin , Matthias Brugger , Bhupesh Sharma , linux-mm Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > While the architecture uses the term 'translation table', in the kernel > > > we generally use 'pgdir' or 'pgd' to refer to the tables, so please keep > > > to that naming scheme. > > > > The idea is to have a unique name space for new subsystem of page > > tables that are used between kernels: > > between stage 1 and stage 2 kexec kernel, and similarly between > > kernels during hibernate boot process. > > > > I picked: "trans_table" that stands for transitional page table: > > meaning they are used only during transition between worlds. > > > > All public functions in this subsystem will have trans_table_* prefix, > > and page directory will be named: "trans_table". If this is confusing, > > I can either use a different prefix, or describe what "trans_table" > > stand for in trans_table.h/.c > > Ok. > > I think that "trans_table" is unfortunately confusing, as it clashes > with the architecture terminology, and differs from what we have > elsewhere. > > I think that "trans_pgd" would be better, as that better aligns with > what we have elsewhere, and avoids the ambiguity. > Sounds good. I will rename trans_table* with trans_pgd*, and will also add a note to the comments explaining what it stands for. Thank you, Pasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD3C0C3A589 for ; Tue, 20 Aug 2019 11:42:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E44F214DA for ; Tue, 20 Aug 2019 11:42:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="YixUBs68" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E44F214DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 03CED6B0007; Tue, 20 Aug 2019 07:42:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F09006B0008; Tue, 20 Aug 2019 07:42:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF6CF6B000A; Tue, 20 Aug 2019 07:42:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id B905A6B0007 for ; Tue, 20 Aug 2019 07:42:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 648DF500F for ; Tue, 20 Aug 2019 11:42:08 +0000 (UTC) X-FDA: 75842617536.13.toes72_2fb65fc207917 X-HE-Tag: toes72_2fb65fc207917 X-Filterd-Recvd-Size: 4619 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Tue, 20 Aug 2019 11:42:07 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id s15so5958411edx.0 for ; Tue, 20 Aug 2019 04:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3a3ksvO52CtO/ttkK+4sBJJjCffAnNgMq3ot08D8hTE=; b=YixUBs68BTWBicnObm8UhXLg9oTc2+ORLcfgUd/Du/W1MFNGMBmeO9v0CpCKPNDfOL IOv3P3Sy0KW3Cf/mHqmQhC5dYF048v5l9MKyEPipLYYbjwxD0H59P87oFZcAUxJs8Bpg TZ1aEoxr3qON74esiOLqh6pfyJNutI2zVrynCMtzDWFU5/3lq5/KWMFf5eqyhEf4R0t8 pbWvw0NqWOv3EnLSCIbWXXsihVYEJL1fI+6iT4Zmbmou9OHn04p1+7PzMZzZ7yyKCqyL Kk9JSwipQzT+aeLr8A97jVZmZOhpTYYMCBCuIaYQAxnOVqXF/8pnIkDuPnZxsqpfAfZv fUjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3a3ksvO52CtO/ttkK+4sBJJjCffAnNgMq3ot08D8hTE=; b=Uy8bZ9ooxjDNKuy4di44fLxzsnNmq2sEoE1MKI9hRLivtFCWVoyDD4QL4XrLcndNib 9hjFE9v6ENbWLfrrcwwTK1gAa/Udkn8v01BTy7Enrdtwqs1ibnHCsafRDf6Ex0nL9AlI 5tqO0+qmC2c48qSKBFoC4MTNBu94T32ZeUJqL25tIyW9NrUDG+iGy2zV9Z/kcBe2CHL0 3YwRp+LFAifpFMRA1sTY0HrbHge9ZtiLxj0Zah47RSMoIk36tRIkiB/NOXF0lw88uDaP aR/+jHbkKNlmcn2YVh1ro0qkSoQctWRBRpK7wdzk3k6jGTEK4JF06KZTlOWv4mettBBL oPOA== X-Gm-Message-State: APjAAAV3ZhJSFIDX+tf83o3prF99he1mDYa78zJC9bgbkTHer9SqkOnM hdlGpldWfgCWWWVvHcg94YvH7Dlw85gU3dPgcfoUgQ== X-Google-Smtp-Source: APXvYqys5DbTiUd9mTqbI3sEh4h1TdEgJjNdpUHqISVmYQkhBiZ+C1YQY1SvjKZBeVx8+M4TD3mTf8Wtu+RfofBl0sA= X-Received: by 2002:a17:906:1112:: with SMTP id h18mr26088394eja.165.1566301326474; Tue, 20 Aug 2019 04:42:06 -0700 (PDT) MIME-Version: 1.0 References: <20190817024629.26611-1-pasha.tatashin@soleen.com> <20190817024629.26611-4-pasha.tatashin@soleen.com> <20190819155824.GE9927@lakrids.cambridge.arm.com> <20190820113000.GA49252@lakrids.cambridge.arm.com> In-Reply-To: <20190820113000.GA49252@lakrids.cambridge.arm.com> From: Pavel Tatashin Date: Tue, 20 Aug 2019 07:41:55 -0400 Message-ID: Subject: Re: [PATCH v2 03/14] arm64, hibernate: add trans_table public functions To: Mark Rutland Cc: James Morris , Sasha Levin , "Eric W. Biederman" , kexec mailing list , LKML , Jonathan Corbet , Catalin Marinas , will@kernel.org, Linux ARM , Marc Zyngier , James Morse , Vladimir Murzin , Matthias Brugger , Bhupesh Sharma , linux-mm Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > > While the architecture uses the term 'translation table', in the kernel > > > we generally use 'pgdir' or 'pgd' to refer to the tables, so please keep > > > to that naming scheme. > > > > The idea is to have a unique name space for new subsystem of page > > tables that are used between kernels: > > between stage 1 and stage 2 kexec kernel, and similarly between > > kernels during hibernate boot process. > > > > I picked: "trans_table" that stands for transitional page table: > > meaning they are used only during transition between worlds. > > > > All public functions in this subsystem will have trans_table_* prefix, > > and page directory will be named: "trans_table". If this is confusing, > > I can either use a different prefix, or describe what "trans_table" > > stand for in trans_table.h/.c > > Ok. > > I think that "trans_table" is unfortunately confusing, as it clashes > with the architecture terminology, and differs from what we have > elsewhere. > > I think that "trans_pgd" would be better, as that better aligns with > what we have elsewhere, and avoids the ambiguity. > Sounds good. I will rename trans_table* with trans_pgd*, and will also add a note to the comments explaining what it stands for. Thank you, Pasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD09C3A589 for ; Tue, 20 Aug 2019 11:42:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E63D214DA for ; Tue, 20 Aug 2019 11:42:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G2nrd/ck"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="YixUBs68" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E63D214DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ddlsSUzNvT9j7t6IYWNHpj4iGeYCyPC82++8YBKXquM=; b=G2nrd/ckkYg6Bh gGcbAG1Yn3409u8zt2Do/cv5vaa6CvqRQc5FBR0av31wSjWJUaBTuu1OuQxb1Y1TzPUYOs3DBxK4n onwpX6qrv2XujK4hoB+1B67aTKZ67LvccPoJTlkk0KaTeTbc9TAENyo4IliAaeSb1Vspuky6AKcF4 bZNbc95YCcwipJ1cMky4xTP+1mtIRML9M3L+kRuNcl23tCfwT6JmvwFv9GWdr5fY/TT7I6+loWnjx 2n3F7/9N+aNz4S+PcsPjoMJvyvvw0wVkrgNfJlCm1uQEtES7+9p+Yx9r+U8K+lBOUlLOLtjLKYot8 JGHUV/9IIshlFqgxWrTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i02Wj-0000wd-Sj; Tue, 20 Aug 2019 11:42:14 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i02We-0000uP-1s for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2019 11:42:11 +0000 Received: by mail-ed1-x541.google.com with SMTP id s15so5958410edx.0 for ; Tue, 20 Aug 2019 04:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3a3ksvO52CtO/ttkK+4sBJJjCffAnNgMq3ot08D8hTE=; b=YixUBs68BTWBicnObm8UhXLg9oTc2+ORLcfgUd/Du/W1MFNGMBmeO9v0CpCKPNDfOL IOv3P3Sy0KW3Cf/mHqmQhC5dYF048v5l9MKyEPipLYYbjwxD0H59P87oFZcAUxJs8Bpg TZ1aEoxr3qON74esiOLqh6pfyJNutI2zVrynCMtzDWFU5/3lq5/KWMFf5eqyhEf4R0t8 pbWvw0NqWOv3EnLSCIbWXXsihVYEJL1fI+6iT4Zmbmou9OHn04p1+7PzMZzZ7yyKCqyL Kk9JSwipQzT+aeLr8A97jVZmZOhpTYYMCBCuIaYQAxnOVqXF/8pnIkDuPnZxsqpfAfZv fUjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3a3ksvO52CtO/ttkK+4sBJJjCffAnNgMq3ot08D8hTE=; b=IcrlpgtzewybU+OynQfbaDNBKV0fAfWcaUlgBSIIgZYU+RGpx8m4YFjN30ZlBBDJt7 Jp2gaaM/etsb/ZJWmLOkdMsCQKSRY/RLAnGJfQVMxk6vjJp72vPOLqE49lMKvwyM89ma pcdEYBxBlJI6825V0Jfs4Ay3NOt2TeP1lZzsUsY5wizVhJwGvOCbC0vxM1ECzAvGjou+ yKH8Eff/H8N8P8k8hfBV01/hBny5b6tv5LEye5LnRxYsfxPxY2GCjVRN2XK3DvE3RSuh j+Cuj5AzBvJq4xaz/s9Elxqd2OuYpQxRfFgSjcQKyzicx5fVraG/iMOKDg24JS1PRVMa FUWQ== X-Gm-Message-State: APjAAAUp0Vrd5GNwTS0ZVSkmRJHZ3fGD/r+yy9PeMJ5JblVveptCIgrb uYfZqpLdwrJmbPhh9sGOAARs/OhKh35eDE4j9EMcog== X-Google-Smtp-Source: APXvYqys5DbTiUd9mTqbI3sEh4h1TdEgJjNdpUHqISVmYQkhBiZ+C1YQY1SvjKZBeVx8+M4TD3mTf8Wtu+RfofBl0sA= X-Received: by 2002:a17:906:1112:: with SMTP id h18mr26088394eja.165.1566301326474; Tue, 20 Aug 2019 04:42:06 -0700 (PDT) MIME-Version: 1.0 References: <20190817024629.26611-1-pasha.tatashin@soleen.com> <20190817024629.26611-4-pasha.tatashin@soleen.com> <20190819155824.GE9927@lakrids.cambridge.arm.com> <20190820113000.GA49252@lakrids.cambridge.arm.com> In-Reply-To: <20190820113000.GA49252@lakrids.cambridge.arm.com> From: Pavel Tatashin Date: Tue, 20 Aug 2019 07:41:55 -0400 Message-ID: Subject: Re: [PATCH v2 03/14] arm64, hibernate: add trans_table public functions To: Mark Rutland X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190820_044208_509282_782D7946 X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Vladimir Murzin , Jonathan Corbet , Marc Zyngier , Catalin Marinas , Bhupesh Sharma , kexec mailing list , LKML , James Morris , linux-mm , James Morse , "Eric W. Biederman" , Matthias Brugger , will@kernel.org, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > > While the architecture uses the term 'translation table', in the kernel > > > we generally use 'pgdir' or 'pgd' to refer to the tables, so please keep > > > to that naming scheme. > > > > The idea is to have a unique name space for new subsystem of page > > tables that are used between kernels: > > between stage 1 and stage 2 kexec kernel, and similarly between > > kernels during hibernate boot process. > > > > I picked: "trans_table" that stands for transitional page table: > > meaning they are used only during transition between worlds. > > > > All public functions in this subsystem will have trans_table_* prefix, > > and page directory will be named: "trans_table". If this is confusing, > > I can either use a different prefix, or describe what "trans_table" > > stand for in trans_table.h/.c > > Ok. > > I think that "trans_table" is unfortunately confusing, as it clashes > with the architecture terminology, and differs from what we have > elsewhere. > > I think that "trans_pgd" would be better, as that better aligns with > what we have elsewhere, and avoids the ambiguity. > Sounds good. I will rename trans_table* with trans_pgd*, and will also add a note to the comments explaining what it stands for. Thank you, Pasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i02We-0000uO-1s for kexec@lists.infradead.org; Tue, 20 Aug 2019 11:42:09 +0000 Received: by mail-ed1-x544.google.com with SMTP id f22so5944500edt.4 for ; Tue, 20 Aug 2019 04:42:07 -0700 (PDT) MIME-Version: 1.0 References: <20190817024629.26611-1-pasha.tatashin@soleen.com> <20190817024629.26611-4-pasha.tatashin@soleen.com> <20190819155824.GE9927@lakrids.cambridge.arm.com> <20190820113000.GA49252@lakrids.cambridge.arm.com> In-Reply-To: <20190820113000.GA49252@lakrids.cambridge.arm.com> From: Pavel Tatashin Date: Tue, 20 Aug 2019 07:41:55 -0400 Message-ID: Subject: Re: [PATCH v2 03/14] arm64, hibernate: add trans_table public functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Mark Rutland Cc: Sasha Levin , Vladimir Murzin , Jonathan Corbet , Marc Zyngier , Catalin Marinas , Bhupesh Sharma , kexec mailing list , LKML , James Morris , linux-mm , James Morse , "Eric W. Biederman" , Matthias Brugger , will@kernel.org, Linux ARM > > > While the architecture uses the term 'translation table', in the kernel > > > we generally use 'pgdir' or 'pgd' to refer to the tables, so please keep > > > to that naming scheme. > > > > The idea is to have a unique name space for new subsystem of page > > tables that are used between kernels: > > between stage 1 and stage 2 kexec kernel, and similarly between > > kernels during hibernate boot process. > > > > I picked: "trans_table" that stands for transitional page table: > > meaning they are used only during transition between worlds. > > > > All public functions in this subsystem will have trans_table_* prefix, > > and page directory will be named: "trans_table". If this is confusing, > > I can either use a different prefix, or describe what "trans_table" > > stand for in trans_table.h/.c > > Ok. > > I think that "trans_table" is unfortunately confusing, as it clashes > with the architecture terminology, and differs from what we have > elsewhere. > > I think that "trans_pgd" would be better, as that better aligns with > what we have elsewhere, and avoids the ambiguity. > Sounds good. I will rename trans_table* with trans_pgd*, and will also add a note to the comments explaining what it stands for. Thank you, Pasha _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec