Re: [PATCH v2 0/9] [GSoC] Improvements to ref-filter

[Hariom verma <hariom18599@gmail.com>]

Hi,

On Thu, Aug 6, 2020 at 3:34 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> "Hariom Verma via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> >      -@@ ref-filter.c: static struct ref_to_worktree_map {
> >      -        struct worktree **worktrees;
> >      - } ref_to_worktree_map;
> >      +@@ ref-filter.c: static struct used_atom {
> >      +                        enum { O_FULL, O_LENGTH, O_SHORT } option;
> >      +                        unsigned int length;
> >      +                } objectname;
> >      ++               struct email_option {
> >      ++                       enum { EO_RAW, EO_TRIM, EO_LOCALPART } option;
> >      ++               } email_option;
> >      +                struct refname_atom refname;
> >      +                char *head;
> >      +        } u;
>
> I'll try to find enough time to read the body of the series sometime
> later this week, but this interdiff alone smells that this is much
> closer to being correct (no, I am not saying I spotted a bug, but it
> certainly looks liek it is on the right track, relative to what I
> saw the last time, to be right).

Thanks. I'll wait for your review.

> A good test for this new feature may be to try using
>
>         "<%(authoremail:localpart)> <%(committeremail:trim)>"
>
> as a format to make sure e-mail options are done per-atom.

Yeah. This test will surely make its way to t6300 in the next version
of this patch series.

Thanks,
Hariom