All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yehezkel Bernat <yehezkelshb@gmail.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org,
	Michael Jamet <michael.jamet@intel.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Andreas Noever <andreas.noever@gmail.com>,
	Lukas Wunner <lukas@wunner.de>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround
Date: Mon, 15 Jun 2020 22:54:52 +0300	[thread overview]
Message-ID: <CA+CmpXtOAUnSdhjwi5HXaJhPzbUUsZZsitFifyhyPk+X2c=wYw@mail.gmail.com> (raw)
In-Reply-To: <20200615155512.GS247495@lahna.fi.intel.com>

On Mon, Jun 15, 2020 at 6:55 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> On Mon, Jun 15, 2020 at 06:41:32PM +0300, Yehezkel Bernat wrote:
> > > I think you are talking about the "prtstns" property in the network
> > > driver. There we only set TBNET_MATCH_FRAGS_ID (bit 1). This is the
> > > thing that get exposed to the other side of the connection and we never
> > > announced support for full E2E.
> >
> >
> > Ah, yes, this one, Thanks!
> > As Windows driver uses it for flagging full-E2E, and we completely drop E2E
> > support here, it may worth to mention there that this is what bit 2 is used in
> > Windows so any reuse should consider the possible compatibility issue.
>
> Note we only drop dead code in this patch. It is that workaround for
> Falcon Ridge controller we actually never used.
>
> I can add a comment to the network driver about the full E2E support
> flag as a separate patch if you think it is useful.
>
> The network protocol will be public soon I guess because USB4 spec
> refers to "USB4 Inter-Domain Specification, Revision 1.0, [to be
> published] – (USB4 Inter-Domain Specification)" so I would expect it to
> be explained there as well.

I see. I leave it for your decision, then.
Thanks for bearing with me.

  reply	other threads:[~2020-06-15 19:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 13:01 [PATCH 0/4] thunderbolt: XDomain and NHI improvements Mika Westerberg
2020-06-15 13:01 ` [PATCH 1/4] thunderbolt: Build initial XDomain property block upon first connect Mika Westerberg
2020-06-15 13:01 ` [PATCH 2/4] thunderbolt: No need to warn if NHI hop_count != 12 or hop_count != 32 Mika Westerberg
2020-06-15 13:01 ` [PATCH 3/4] thunderbolt: NHI can use HopIDs 1-7 Mika Westerberg
2020-06-15 13:01 ` [PATCH 4/4] thunderbolt: Get rid of E2E workaround Mika Westerberg
2020-06-15 13:45   ` Yehezkel Bernat
2020-06-15 13:51     ` Greg Kroah-Hartman
2020-06-15 14:18       ` Yehezkel Bernat
2020-06-15 14:22         ` Mika Westerberg
2020-06-15 15:15           ` Yehezkel Bernat
2020-06-15 15:32             ` Mika Westerberg
2020-06-15 15:41               ` Yehezkel Bernat
2020-06-15 15:55                 ` Mika Westerberg
2020-06-15 19:54                   ` Yehezkel Bernat [this message]
2020-06-16 11:55                     ` Mika Westerberg
2020-06-22 16:33                       ` Mika Westerberg
2020-06-29 15:37 ` [PATCH 0/4] thunderbolt: XDomain and NHI improvements Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+CmpXtOAUnSdhjwi5HXaJhPzbUUsZZsitFifyhyPk+X2c=wYw@mail.gmail.com' \
    --to=yehezkelshb@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.