From: Wenchao Chen <wenchao.chen666@gmail.com>
To: Sarthak Garg <quic_sartgarg@quicinc.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
"Kamasali Satyanarayan (Consultant) (QUIC)"
<quic_kamasali@quicinc.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"shawn.lin@rock-chips.com" <shawn.lin@rock-chips.com>,
"merez@codeaurora.org" <merez@codeaurora.org>,
"s.shtylyov@omp.ru" <s.shtylyov@omp.ru>,
"huijin.park@samsung.com" <huijin.park@samsung.com>,
"briannorris@chromium.org" <briannorris@chromium.org>,
"digetx@gmail.com" <digetx@gmail.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Veerabhadrarao Badiganti <vbadigan@codeaurora.org>,
Shaik Sajida Bhanu <sbhanu@codeaurora.org>
Subject: Re: [PATCH V1] mmc: core: Add partial initialization support
Date: Thu, 28 Sep 2023 11:20:26 +0800 [thread overview]
Message-ID: <CA+Da2qz2dSUKa9t4gBaDg=kAE=CjRrx2Sz_Je+nFsrM5xr_+5w@mail.gmail.com> (raw)
In-Reply-To: <c06480b1-95e3-49cd-9498-5c7c5f1deabe@quicinc.com>
On Tue, 26 Sept 2023 at 18:41, Sarthak Garg <quic_sartgarg@quicinc.com> wrote:
>
>
> On 6/16/2022 4:18 AM, Ulf Hansson wrote:
> > On Tue, 24 May 2022 at 07:37, Sarthak Garg (QUIC)
> > <quic_sartgarg@quicinc.com> wrote:
> >> Hi Ulf,
> >>
> >> Please find the gains seen on micron and kingston eMMC parts below with partial initialization feature (These are the averaged numbers) :
> >>
> >> 1) Micron eMMC (ManfID 0x13)
> >>
> >> Partial init Full Init
> >>
> >> a) _mmc_resume: _mmc_resume :
> >>
> >> Total time : 62ms Total time : 84ms
> >> (Decrease % from full init = ~26%)
> > Alright, so we gained around 22ms. Not too bad.
> >
> >> Breakup :
> >> mmc_claim_host_time: 0.2ms mmc_claim_host_time: 0.1ms
> >> mmc_power_up_time: 33ms mmc_power_up_time: 33ms
> >> mmc_sleepawake_time: 28ms mmc_init_card_time: 50ms
> >> mmc_partial_init_time: 1ms
> >>
> >> b) _mmc_suspend: _mmc_suspend:
> >>
> >> Total time: 5ms Total time: 7.5ms
> >> mmc_claim_host_time: 0.5ms mmc_claim_host_time: 1ms
> >> mmc_flush_cache_time : 1.5 ms mmc_flush_cache_time : 2.5 ms
> >> mmc_sleep_time: 1.5ms mmc_sleep_time: 2ms
> >> mmc_power_off_time: 1.5ms mmc_power_off_time: 1.5ms
> > The suspend time shouldn't really differ. Or is there a reason for this?
>
>
> I think this could be due to run to run variation as we can see
> mmc_claim_host and mmc_flush_cache itself taking some extra 1ms.
>
>
Hi Sarthak
I have a question.
1.What is the difference between Partial init and Full Init on SOC
power consumption?
2.Partial init and Full init improve IO performance?
3.Could you share the test methods if you want?
> >
> >>
> >> 2) Kingston eMMC (ManfID 0x70)
> >>
> >> Partial init Full Init
> >>
> >> a) _mmc_resume: _mmc_resume :
> >> Total time : 46ms Total time : 62ms
> >> (Decrease % from full init = ~25%)
> >>
> >> Breakup :
> >> mmc_claim_host_time: 0.2ms mmc_claim_host_time: 0.2ms
> >> mmc_power_up_time: 30ms mmc_power_up_time: 30ms
> >> mmc_sleepawake_time: 14ms mmc_init_card_time: 31ms
> >> mmc_partial_init_time: 2ms
> >>
> >>
> >> b) _mmc_suspend: _mmc_suspend:
> >> Total time : 5ms Total: 5ms
> >>
> >> Breakup :
> >> mmc_claim_host_time: 0.5ms mmc_claim_host_time: 0.5ms
> >> mmc_flush_cache_time : 1.5 ms mmc_flush_cache_time : 1.5 ms
> >> mmc_sleep_time: 1.5ms mmc_sleep_time: 1ms
> >> mmc_power_off_time: 1.5ms mmc_power_off_time: 1.5ms
> >>
> >> Did some minor modifications as well to this patchset as per avri's comment which I'll post as V2.
> >> Please let me know your inputs about these numbers.
> > Thanks for posting these numbers, much appreciated! Please try to
> > include some of the data as part of the commit message as I think it's
> > valuable information.
> >
> > When it comes to reviewing the code, I am awaiting your v2 then.
> >
> > [...]
> >
> > Kind regards
> > Uffe
>
> Sure will add this data to the commit text in V2.
>
>
next prev parent reply other threads:[~2023-09-28 3:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 9:04 [PATCH V1] mmc: core: Add partial initialization support Srinivasarao Pathipati
2022-04-26 18:33 ` Avri Altman
2022-04-26 20:07 ` kernel test robot
2022-04-27 7:35 ` Ulf Hansson
2022-05-24 11:58 ` Kamasali Satyanarayan (Consultant) (QUIC)
2022-05-24 14:37 ` Sarthak Garg (QUIC)
2022-05-31 9:23 ` Sarthak Garg (QUIC)
2022-06-15 22:48 ` Ulf Hansson
2023-09-26 6:39 ` Sarthak Garg
2023-09-28 3:20 ` Wenchao Chen [this message]
2023-10-04 10:45 ` Sarthak Garg
2022-06-02 7:56 ` Ben Chuang
2023-09-26 6:31 ` Sarthak Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+Da2qz2dSUKa9t4gBaDg=kAE=CjRrx2Sz_Je+nFsrM5xr_+5w@mail.gmail.com' \
--to=wenchao.chen666@gmail.com \
--cc=avri.altman@wdc.com \
--cc=briannorris@chromium.org \
--cc=digetx@gmail.com \
--cc=huijin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=quic_kamasali@quicinc.com \
--cc=quic_sartgarg@quicinc.com \
--cc=s.shtylyov@omp.ru \
--cc=sbhanu@codeaurora.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.