From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7EE0C433DB for ; Tue, 9 Mar 2021 19:53:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EA056523D for ; Tue, 9 Mar 2021 19:53:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EA056523D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=getutm.app Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJiQ8-0004oF-L8 for qemu-devel@archiver.kernel.org; Tue, 09 Mar 2021 14:53:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJgpe-0005xJ-0U for qemu-devel@nongnu.org; Tue, 09 Mar 2021 13:11:46 -0500 Received: from mail-io1-f44.google.com ([209.85.166.44]:43098) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJgpc-0003Cx-Ev for qemu-devel@nongnu.org; Tue, 09 Mar 2021 13:11:45 -0500 Received: by mail-io1-f44.google.com with SMTP id f20so14912454ioo.10 for ; Tue, 09 Mar 2021 10:11:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5CakexBoo6FKy/3SWG7urTGYA76flnV07TYSWfCOtAo=; b=ZVKZmnaYB0srxQye4I5kFYU2jyX/k7dZBIRb3yyDZ3WRIOnE1BTk553PtWJFvwWlU5 4nYbQEACmWYWqrYUa0ytIQSaKO7SZ5tJW8xyTvYDluNzhgsJT4GO7jNr3Ji369+I7EE5 uxJMk3q3LDMXeDExdAKiDxAaET38heq04wh1s5Hpb7c2/9hQVZLBQ6T4bxeM2HsGNFwm 58qbITuV0l1nyRgg7VLpA3i+HeVjDvr0nlSyNo2wL6+21QPnN7AW4Sx437R5kU/bxZTj 62khiA+32+v6ZiRFhS4fvV83OSmSZZqo8bIL8V5YLSeZIRhasLjJjSqh/EcPlpP/GpWw kf3g== X-Gm-Message-State: AOAM530uEAMnvBuTiqen+/S5D8U2LfxspebP0+Sb6FGVbPDF4rLrKPLr oKpd/E7Zf+Y/1S6nBF+92Cz/nxiDXb4= X-Google-Smtp-Source: ABdhPJySPyurozzuCt5EDpazYjbCMtrmcJ6iaKJtYFeJiWqj3mosbchcOhzLLNBt1Fvj6qPzEoKWwQ== X-Received: by 2002:a02:971a:: with SMTP id x26mr29461035jai.61.1615313503197; Tue, 09 Mar 2021 10:11:43 -0800 (PST) Received: from mail-il1-f181.google.com (mail-il1-f181.google.com. [209.85.166.181]) by smtp.gmail.com with ESMTPSA id b9sm7973583iob.4.2021.03.09.10.11.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 10:11:42 -0800 (PST) Received: by mail-il1-f181.google.com with SMTP id e2so13068052ilu.0 for ; Tue, 09 Mar 2021 10:11:42 -0800 (PST) X-Received: by 2002:a92:d2c6:: with SMTP id w6mr25451589ilg.273.1615313502729; Tue, 09 Mar 2021 10:11:42 -0800 (PST) MIME-Version: 1.0 References: <20210309002741.85057-1-j@getutm.app> <20210309002741.85057-5-j@getutm.app> In-Reply-To: From: Joelle van Dyne Date: Tue, 9 Mar 2021 10:11:31 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/4] slirp: feature detection for smbd To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=209.85.166.44; envelope-from=osy86dev@gmail.com; helo=mail-io1-f44.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Thibault , Jason Wang , Joelle van Dyne , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Mar 9, 2021 at 6:09 AM Philippe Mathieu-Daud=C3=A9 wrote: > > Hi Joelle, > > On 3/9/21 1:27 AM, Joelle van Dyne wrote: > > Replace Windows specific macro with a more generic feature detection > > macro. Allows slirp smb feature to be disabled manually as well. > > > > Signed-off-by: Joelle van Dyne > > --- > > configure | 26 +++++++++++++++++++++++--- > > meson.build | 2 +- > > net/slirp.c | 16 ++++++++-------- > > 3 files changed, 32 insertions(+), 12 deletions(-) > > Hmm v1 had: Acked-by: Samuel Thibault > did you change something to not include Samuel A-b tag? > Sorry, I must have missed it! -j