All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joelle van Dyne <j@getutm.app>
To: Roman Bolshakov <r.bolshakov@yadro.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Joelle van Dyne <j@getutm.app>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] util/osdep: Avoid mprotect() RWX->NONE on Big Sur 11.2
Date: Tue, 9 Mar 2021 10:06:57 -0800	[thread overview]
Message-ID: <CA+E+eSDozGbT4iJQekjPhKfW-=VFoBYW=+TpArEf8FT3x5qYXw@mail.gmail.com> (raw)
In-Reply-To: <YEd4wAwfts0Oma+W@SPB-NB-133.local>

On Tue, Mar 9, 2021 at 5:31 AM Roman Bolshakov <r.bolshakov@yadro.com> wrote:
>
> On Sun, Mar 07, 2021 at 10:47:06PM -0800, Joelle van Dyne wrote:
> > On Wed, Feb 10, 2021 at 2:55 AM Roman Bolshakov <r.bolshakov@yadro.com> wrote:
> > >
> > > There's a change in mprotect() behaviour [1] in the latest macOS on M1
> > > and it's not yet clear if it's going to be fixed by Apple. For now we
> > > can avoid unsupported mprotect() calls. QEMU and qtests work fine
> > > without it.
> > >
> > > 1. https://gist.github.com/hikalium/75ae822466ee4da13cbbe486498a191f
> > >
> > > Buglink: https://bugs.launchpad.net/qemu/+bug/1914849
> > > Apple-Feedback: FB8994773
> > > Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> >
> > Reviewed-by: Joelle van Dyne <j@getutm.app>
> >
>
> Thanks!
>
> > FYI the "macOS 11.2, *" means it applies to all versions of iOS. I
> > think it only broke in iOS 14.2 but making it return on other versions
> > seems to be fine from my tests.
> >
>
> Hm... do you know how to say "for macOS 11.2 and above only"?
>
> Regards,
> Roman

What you have is fine for "macOS 11.2 and above" but the "*" means "OR
any version of any platform not macOS". If you have
"__builtin_available(macOS 11.2, iOS 14.4, *)" would mean macOS 11.2
and above OR iOS 14.4 and above (which is the release aligned with
macOS 11.2, not iOS 14.2 as I originally mistyped) OR any version of
any platform not macOS. However, I think it's fine here as making this
change doesn't break anything on older versions of iOS (or macOS as
well). Btw, there's also tvOS and watchOS which I'm not sure if this
bug applies (I assume yes) but QEMU doesn't run on those platforms
(yet).

-j


  reply	other threads:[~2021-03-09 19:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 10:55 [PATCH] util/osdep: Avoid mprotect() RWX->NONE on Big Sur 11.2 Roman Bolshakov
2021-03-08  6:47 ` Joelle van Dyne
2021-03-09 13:31   ` Roman Bolshakov
2021-03-09 18:06     ` Joelle van Dyne [this message]
2021-03-09 14:03 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+E+eSDozGbT4iJQekjPhKfW-=VFoBYW=+TpArEf8FT3x5qYXw@mail.gmail.com' \
    --to=j@getutm.app \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=r.bolshakov@yadro.com \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.