From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55864C43215 for ; Thu, 28 Nov 2019 16:24:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 27BDB217D7 for ; Thu, 28 Nov 2019 16:24:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pCfa8I1b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726648AbfK1QYm (ORCPT ); Thu, 28 Nov 2019 11:24:42 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:45559 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbfK1QYm (ORCPT ); Thu, 28 Nov 2019 11:24:42 -0500 Received: by mail-oi1-f196.google.com with SMTP id 14so23688309oir.12; Thu, 28 Nov 2019 08:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z3VqpjrZB5dVKBqJG+mBiDtnZ2Bu7fCXo2j8f/VRZBE=; b=pCfa8I1bGBJviToPnlI7I96+AvxXirWhqa1wUa20TPpvOfSet/Jbt0Lpoo+Nzqt4fE LSz+mJ7sp9C3DNk2hs5CjRxI4FKiTSXqK3sBqj7cIALppBwCdLCmePe6GKkIy3QTYzEW j8/WF9jIePBnNm9A5VK2yPfms5BHVw8K6ktYULdc3yBai4cXaxERnoUIQW/67pRftz+6 Ks9X6RGtaA/GLOUc8FFploAP1oPdB5RucTmtRXbp074EwSC2k5fpNywfVlN79xQDPutd M0OjD4rctuwzHm+XTBODgvxhP7SoqKSRaXIY+5ShWrs96D+zE/kQ3fA+xPEeP76rZRV2 FQbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z3VqpjrZB5dVKBqJG+mBiDtnZ2Bu7fCXo2j8f/VRZBE=; b=HaAMER7raYDjdqijVx3kSO06nXug+h85psJwilpguj2R2g0BmlhegGZ/TAQlKL2gsL rkx5f4W8UBrcr5IHzky7AiNrHhvuQnBwl3xFHUGr1hUzcy+n2KgmI+CvvOuZ0KmjE/n8 QC+8bELHb5GEwGDAli+szzYZSgWG5IXcVmxb7gaGPHNxlyldJyd7Xz7MmznjfPfh2iGO XXr+vrRtNA9zE8Oty77q1g+gAq0ttWGeKnR6d2ipPxq+i1ctPoxT34FJ7SJYMHfWgHvG n4858OSsojkDbEqzRSkRTXMav6yF1OS0+yNPcvwsIM+HxB8U3ljC9Hz1I11zrZWBKwCw wiDw== X-Gm-Message-State: APjAAAVv84HkpNLuw13pCQQRalTueebCS6j7Hry3aFm/5T5mTRjPl7IE yaqBlZdT1i8huIWOSVknGFSS+WMygbgczfiLFXr8GbdN1ro= X-Google-Smtp-Source: APXvYqzz7ps6eXoUhwDQKMUk7cAIqzYXyKKS19x5F5J/c1WL4oGQ5D0Zg836VRhZZOC0G9Xb+Fho4S0eFMAeGSAZ8J4= X-Received: by 2002:aca:edd5:: with SMTP id l204mr6637720oih.98.1574958280574; Thu, 28 Nov 2019 08:24:40 -0800 (PST) MIME-Version: 1.0 References: <20191127052935.1719897-1-anarsoul@gmail.com> <20191127052935.1719897-3-anarsoul@gmail.com> <20191127174434.wousbqosmm5vxcsu@gilmour.lan> <20191128074325.q47rpzhufwog6mbb@gilmour.lan> In-Reply-To: From: Vasily Khoruzhick Date: Thu, 28 Nov 2019 08:24:14 -0800 Message-ID: Subject: Re: [PATCH v6 2/7] dt-bindings: thermal: add YAML schema for sun8i-thermal driver bindings To: Frank Lee Cc: Maxime Ripard , Zhang Rui , Eduardo Valentin , Daniel Lezcano , Amit Kucheria , Rob Herring , Mark Rutland , Chen-Yu Tsai , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Linux PM , devicetree , arm-linux , =?UTF-8?Q?Ond=C5=99ej_Jirman?= , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 28, 2019 at 6:45 AM Frank Lee wrote: Hey Yangtao, I've already addressed all the comments and fixed patchset is sitting in https://github.com/anarsoul/linux-2.6/tree/ths-5.4 I'll rebase and submit new version after merge window is closed (in ~1.5 weeks?) Regards, Vasily > diff --git a/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > new file mode 100644 > index 000000000000..1be32f09fcc8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > @@ -0,0 +1,160 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/sun8i-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner SUN8I Thermal Controller Device Tree Bindings > + > +maintainers: > + - Yangtao Li > + > +description: |- > + This describes the device tree binding for the Allwinner thermal > + controller which measures the on-SoC temperatures. > + > +properties: > + compatible: > + enum: > + - allwinner,sun8i-a83t-ths > + - allwinner,sun8i-h3-ths > + - allwinner,sun8i-r40-ths > + - allwinner,sun50i-a64-ths > + - allwinner,sun50i-h5-ths > + - allwinner,sun50i-h6-ths > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + maxItems: 2 > + items: > + - description: ths bus clock > + - description: ths mod clock > + > + clock-names: > + minItems: 1 > + maxItems: 2 > + items: > + - const: bus > + - const: mod > + > + "#thermal-sensor-cells": > + enum: [ 0, 1 ] > + > + nvmem-cells: > + description: ths calibrate data > + > + nvmem-cell-names: > + const: calibration > + > +required: > + - compatible > + - reg > + - interrupts > + - "#thermal-sensor-cells" > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - allwinner,sun8i-h3-ths > + - allwinner,sun8i-r40-ths > + - allwinner,sun50i-a64-ths > + - allwinner,sun50i-h5-ths > + - allwinner,sun50i-h6-ths > + > + then: > + properties: > + resets: > + minItems: 1 > + maxItems: 1 > + > + - if: > + properties: > + compatible: > + contains: > + const: allwinner,sun50i-h6-ths > + > + then: > + properties: > + clocks: > + minItems: 1 > + maxItems: 1 > + > + clock-names: > + minItems: 1 > + maxItems: 1 > + > + else: > + if: > + properties: > + compatible: > + contains: > + enum: > + - allwinner,sun8i-h3-ths > + - allwinner,sun8i-r40-ths > + - allwinner,sun50i-a64-ths > + - allwinner,sun50i-h5-ths > + > + then: > + properties: > + clocks: > + minItems: 2 > + maxItems: 2 > + > + clock-names: > + minItems: 2 > + maxItems: 2 > + > + - if: > + properties: > + compatible: > + contains: > + const: allwinner,sun8i-h3-ths > + > + then: > + properties: > + "#thermal-sensor-cells": > + const: 0 > + > + else: > + properties: > + "#thermal-sensor-cells": > + const: 1 > + > +additionalProperties: false > + > +examples: > + - | > + ths: ths@5070400 { > + compatible = "allwinner,sun50i-h6-ths"; > + reg = <0x05070400 0x100>; > + clocks = <&ccu 89>; > + clock-names = "bus"; > + resets = <&ccu 36>; > + interrupts = <0 15 4>; > + nvmem-cells = <&tsen_calib>; > + nvmem-cell-names = "calibration"; > + #thermal-sensor-cells = <1>; > + }; > + > + sid: sid@3006000 { > + compatible = "allwinner,sun50i-h6-sid"; > + reg = <0x03006000 0x400>; > + #address-cells = <1>; > + #size-cells = <1>; > + tsen_calib: calib@14 { > + reg = <0x14 6>; > + }; > + }; > +... > > On Thu, Nov 28, 2019 at 10:35 PM Frank Lee wrote: > > > > Hi, > > > > How about this? > > > > Best regards, > > Yangtao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0AEEC432C0 for ; Thu, 28 Nov 2019 16:24:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C75C5217BA for ; Thu, 28 Nov 2019 16:24:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tA9rlqFM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pCfa8I1b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C75C5217BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f+4qzlF51VcsFRpg5jcPE6JEOTVwS7F8eC333Qwg0uY=; b=tA9rlqFMZ4aCKO /6g0RHUfOsuCbv6T5MTeNqTw2mMvVNup55+PS9lIAKp/pCMEMSw3bISrl0fBUtQc82IE9Xk7qOqf4 Z4xoe2WM4JmprlQIcQKHoHe5UzgRh0ayP5kw62Er4rlmR2fmaGKMHm0PWZuHaEI2X+zif9VUdj4tj Y6j8Ib8fb236oaUo9PrKhGKbqxZIaXZ/+he0EhKl6BBXx+BLv6/78EZgz3QepWeIH9uhNhvZbX2gj tFnWuThHkSWfwDrQu8LO+/9u2FPE80BHtxM7ZIlIQZ57YaIVkhSV8Ag55xSS1IVk9qJPe1Q38QIaP KyXH9W1LiDSZ8QpX202Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iaMaz-0002J7-0A; Thu, 28 Nov 2019 16:24:45 +0000 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iaMav-0002Ih-I1 for linux-arm-kernel@lists.infradead.org; Thu, 28 Nov 2019 16:24:43 +0000 Received: by mail-oi1-x243.google.com with SMTP id e9so23752222oif.8 for ; Thu, 28 Nov 2019 08:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z3VqpjrZB5dVKBqJG+mBiDtnZ2Bu7fCXo2j8f/VRZBE=; b=pCfa8I1bGBJviToPnlI7I96+AvxXirWhqa1wUa20TPpvOfSet/Jbt0Lpoo+Nzqt4fE LSz+mJ7sp9C3DNk2hs5CjRxI4FKiTSXqK3sBqj7cIALppBwCdLCmePe6GKkIy3QTYzEW j8/WF9jIePBnNm9A5VK2yPfms5BHVw8K6ktYULdc3yBai4cXaxERnoUIQW/67pRftz+6 Ks9X6RGtaA/GLOUc8FFploAP1oPdB5RucTmtRXbp074EwSC2k5fpNywfVlN79xQDPutd M0OjD4rctuwzHm+XTBODgvxhP7SoqKSRaXIY+5ShWrs96D+zE/kQ3fA+xPEeP76rZRV2 FQbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z3VqpjrZB5dVKBqJG+mBiDtnZ2Bu7fCXo2j8f/VRZBE=; b=YYldAvgaKuvvE8hv6jLF8LXAYcauzq44Y4wFlSk8JIUASkwbMKkLgjw0Bw+kZZp1dn Y8ioI3maEotLgcs+Jjoz7WEJ9V8VoezVE3P7+v+NzRMk1lUK0waFEZeLPjTpSw4ro44e pEtPzL7pbe++HwnazTZz9SWhtDbrjqCPR4yoN6Scv6y3IjKRH2cq3P8Sw3MCnLiaRA4P NtVmFXPTpy+z2WnGi5qXyCILsb/1IEhzqioo9aFeALaZ4L1+i+oLAHOKhnrTNLemYnBH 3uDg22VaYgWMd998wT3eVw4nP4nl6JaBTUXXqCQIeOYhKVo/23+symsxNz8frC/teY2N KgGQ== X-Gm-Message-State: APjAAAXmBAH8mk5eFfZw41Dr+Fd+bjYsCdjo3SQqG7I6ddcBVE7ak6K7 8pJQ/itSvFJFC2V82KZIk6kaVuBlcAlEICWrM7o= X-Google-Smtp-Source: APXvYqzz7ps6eXoUhwDQKMUk7cAIqzYXyKKS19x5F5J/c1WL4oGQ5D0Zg836VRhZZOC0G9Xb+Fho4S0eFMAeGSAZ8J4= X-Received: by 2002:aca:edd5:: with SMTP id l204mr6637720oih.98.1574958280574; Thu, 28 Nov 2019 08:24:40 -0800 (PST) MIME-Version: 1.0 References: <20191127052935.1719897-1-anarsoul@gmail.com> <20191127052935.1719897-3-anarsoul@gmail.com> <20191127174434.wousbqosmm5vxcsu@gilmour.lan> <20191128074325.q47rpzhufwog6mbb@gilmour.lan> In-Reply-To: From: Vasily Khoruzhick Date: Thu, 28 Nov 2019 08:24:14 -0800 Message-ID: Subject: Re: [PATCH v6 2/7] dt-bindings: thermal: add YAML schema for sun8i-thermal driver bindings To: Frank Lee X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191128_082441_625767_EEEB4EFA X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Amit Kucheria , Linux PM , =?UTF-8?Q?Ond=C5=99ej_Jirman?= , Greg Kroah-Hartman , Daniel Lezcano , linux-kernel , Maxime Ripard , Eduardo Valentin , Chen-Yu Tsai , Rob Herring , Mauro Carvalho Chehab , Zhang Rui , "David S. Miller" , arm-linux Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 28, 2019 at 6:45 AM Frank Lee wrote: Hey Yangtao, I've already addressed all the comments and fixed patchset is sitting in https://github.com/anarsoul/linux-2.6/tree/ths-5.4 I'll rebase and submit new version after merge window is closed (in ~1.5 weeks?) Regards, Vasily > diff --git a/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > new file mode 100644 > index 000000000000..1be32f09fcc8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > @@ -0,0 +1,160 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/sun8i-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner SUN8I Thermal Controller Device Tree Bindings > + > +maintainers: > + - Yangtao Li > + > +description: |- > + This describes the device tree binding for the Allwinner thermal > + controller which measures the on-SoC temperatures. > + > +properties: > + compatible: > + enum: > + - allwinner,sun8i-a83t-ths > + - allwinner,sun8i-h3-ths > + - allwinner,sun8i-r40-ths > + - allwinner,sun50i-a64-ths > + - allwinner,sun50i-h5-ths > + - allwinner,sun50i-h6-ths > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + maxItems: 2 > + items: > + - description: ths bus clock > + - description: ths mod clock > + > + clock-names: > + minItems: 1 > + maxItems: 2 > + items: > + - const: bus > + - const: mod > + > + "#thermal-sensor-cells": > + enum: [ 0, 1 ] > + > + nvmem-cells: > + description: ths calibrate data > + > + nvmem-cell-names: > + const: calibration > + > +required: > + - compatible > + - reg > + - interrupts > + - "#thermal-sensor-cells" > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - allwinner,sun8i-h3-ths > + - allwinner,sun8i-r40-ths > + - allwinner,sun50i-a64-ths > + - allwinner,sun50i-h5-ths > + - allwinner,sun50i-h6-ths > + > + then: > + properties: > + resets: > + minItems: 1 > + maxItems: 1 > + > + - if: > + properties: > + compatible: > + contains: > + const: allwinner,sun50i-h6-ths > + > + then: > + properties: > + clocks: > + minItems: 1 > + maxItems: 1 > + > + clock-names: > + minItems: 1 > + maxItems: 1 > + > + else: > + if: > + properties: > + compatible: > + contains: > + enum: > + - allwinner,sun8i-h3-ths > + - allwinner,sun8i-r40-ths > + - allwinner,sun50i-a64-ths > + - allwinner,sun50i-h5-ths > + > + then: > + properties: > + clocks: > + minItems: 2 > + maxItems: 2 > + > + clock-names: > + minItems: 2 > + maxItems: 2 > + > + - if: > + properties: > + compatible: > + contains: > + const: allwinner,sun8i-h3-ths > + > + then: > + properties: > + "#thermal-sensor-cells": > + const: 0 > + > + else: > + properties: > + "#thermal-sensor-cells": > + const: 1 > + > +additionalProperties: false > + > +examples: > + - | > + ths: ths@5070400 { > + compatible = "allwinner,sun50i-h6-ths"; > + reg = <0x05070400 0x100>; > + clocks = <&ccu 89>; > + clock-names = "bus"; > + resets = <&ccu 36>; > + interrupts = <0 15 4>; > + nvmem-cells = <&tsen_calib>; > + nvmem-cell-names = "calibration"; > + #thermal-sensor-cells = <1>; > + }; > + > + sid: sid@3006000 { > + compatible = "allwinner,sun50i-h6-sid"; > + reg = <0x03006000 0x400>; > + #address-cells = <1>; > + #size-cells = <1>; > + tsen_calib: calib@14 { > + reg = <0x14 6>; > + }; > + }; > +... > > On Thu, Nov 28, 2019 at 10:35 PM Frank Lee wrote: > > > > Hi, > > > > How about this? > > > > Best regards, > > Yangtao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel