From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA944C2D0BF for ; Wed, 18 Dec 2019 23:18:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFAFB2176D for ; Wed, 18 Dec 2019 23:18:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QEJ84Ho9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726705AbfLRXSu (ORCPT ); Wed, 18 Dec 2019 18:18:50 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:40853 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbfLRXSt (ORCPT ); Wed, 18 Dec 2019 18:18:49 -0500 Received: by mail-qk1-f195.google.com with SMTP id c17so3083507qkg.7; Wed, 18 Dec 2019 15:18:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nuyhYd8ECto87m9FuniOXYcBUixqQrUKuyD3AyEWA+A=; b=QEJ84Ho9x2u+RDV0L3fVLJ/07KGc8v4ji6189tqfgBzY4T9Zch4GF0ICOVmQiedFkK gO4tHFmI5AKY1yHkS5HmwQYH5w099hrSeCmDSLxdHK49ZwJao7LsADt7eFeAk/l3l3Lx vhmh1Z55xZ84AoRvPI0kPvYKhWj8/DEvynF8GDGjLZ28A7MxDzE5QZqE8bB348T9Imec VnKMOX6inmmxlz1s98+0hVZIcvQEJGNBImQ2V453cN632C6Nk8Vlvesscm4QA8Qmo1aG s935HuQHKFwUR6y/qra3A6ib1CF+reB133B+j1W732GGg527pTNwiD0EPZtT4A/ENTwb HI4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nuyhYd8ECto87m9FuniOXYcBUixqQrUKuyD3AyEWA+A=; b=AdbTIV/My4gq9e6F6I+H3/AK4Ibxnw9ITKL/pBYe+shdJV5b4/8GqWvVp90vRgNXHi RZ5A5oZ77y6Kkk2o71jos+SJhomS89dMPyKt6LJMET2S0l3eqcLuQZXauVRdplrKgKPq a1llnLSM5Sts8KgfKzb+vWBV5tAZ5Jc2k9bN+aa4BM/pgykzP+AqotlRXWvfklnBGRNB 7tB9ebXgcVorsNOIFWhC0LVRqLFjNwwcOzSUwDLjSLBov10Jd+rIE/Y1kswxVqG4QVX3 w9D4wslkO5QnJwfMsBL//PfFBM48XaWW+o+sJOFdzPLmYs+vcjnUpJp0Mmm9HqSgJVD+ epdg== X-Gm-Message-State: APjAAAXb+m//97Z1QyMra/nVsovHQNu91tak3TeMs4obMPoEf1pMJ2PS iYeCQd3nNWRChlunPDpgHch34WklXSjHc8kXX38= X-Google-Smtp-Source: APXvYqxmCgCcV71Y46Kd1h7x1kMPtfJ8a/HJjus1Y1SOXueUfBb+NFUsWJq8OEdBjSxCnnR0qVG1fuTHKRUTczc2+cE= X-Received: by 2002:a37:5d0:: with SMTP id 199mr5281279qkf.131.1576711128403; Wed, 18 Dec 2019 15:18:48 -0800 (PST) MIME-Version: 1.0 References: <20191218042121.1471954-1-anarsoul@gmail.com> <20191218042121.1471954-7-anarsoul@gmail.com> In-Reply-To: From: Vasily Khoruzhick Date: Wed, 18 Dec 2019 15:18:51 -0800 Message-ID: Subject: Re: [PATCH v7 6/7] arm64: dts: allwinner: h6: Add thermal sensor and thermal zones To: Chen-Yu Tsai Cc: Yangtao Li , Zhang Rui , Daniel Lezcano , Amit Kucheria , Rob Herring , Mark Rutland , Maxime Ripard , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , "open list:THERMAL" , devicetree , linux-arm-kernel , =?UTF-8?Q?Ond=C5=99ej_Jirman?= , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 17, 2019 at 8:32 PM Chen-Yu Tsai wrote: > > On Wed, Dec 18, 2019 at 12:22 PM Vasily Khoruzhick wrote: > > > > From: Ondrej Jirman > > > > There are two sensors, one for CPU, one for GPU. > > > > Signed-off-by: Ondrej Jirman > > Signed-off-by: Vasily Khoruzhick > > --- > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 ++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > index 29824081b43b..cdcb1a36301a 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -11,6 +11,7 @@ > > #include > > #include > > #include > > +#include > > > > / { > > interrupt-parent = <&gic>; > > @@ -233,6 +234,12 @@ dma: dma-controller@3002000 { > > sid: efuse@3006000 { > > compatible = "allwinner,sun50i-h6-sid"; > > reg = <0x03006000 0x400>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + ths_calibration: thermal-sensor-calibration@14 { > > + reg = <0x14 0x6>; > > Nit: my preference is to use words as the smallest increment, so this > would have a size of 8 instead of 6. Same goes for the A64 dts. > > AFAICT this doesn't impact the driver in any way. H6 has only 2 sensors, so it should be 4. That's my overlook, I'll change it to 4 for H6 and to 8 for A64. > > ChenYu > > > > + }; > > }; > > > > watchdog: watchdog@30090a0 { > > @@ -856,5 +863,31 @@ r_i2c: i2c@7081400 { > > #address-cells = <1>; > > #size-cells = <0>; > > }; > > + > > + ths: thermal-sensor@5070400 { > > + compatible = "allwinner,sun50i-h6-ths"; > > + reg = <0x05070400 0x100>; > > + interrupts = ; > > + clocks = <&ccu CLK_BUS_THS>; > > + clock-names = "bus"; > > + resets = <&ccu RST_BUS_THS>; > > + nvmem-cells = <&ths_calibration>; > > + nvmem-cell-names = "calibration"; > > + #thermal-sensor-cells = <1>; > > + }; > > + }; > > + > > + thermal-zones { > > + cpu-thermal { > > + polling-delay-passive = <0>; > > + polling-delay = <0>; > > + thermal-sensors = <&ths 0>; > > + }; > > + > > + gpu-thermal { > > + polling-delay-passive = <0>; > > + polling-delay = <0>; > > + thermal-sensors = <&ths 1>; > > + }; > > }; > > }; > > -- > > 2.24.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B434C43603 for ; Wed, 18 Dec 2019 23:19:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C839D2176D for ; Wed, 18 Dec 2019 23:19:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RtlPuliF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QEJ84Ho9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C839D2176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G1NzUkaEKTnjz31wKLKmZ2L4voA4DZ6vZcvipw8fid0=; b=RtlPuliFuvZLz2 HIK4q5DY4ebYsCdtOjiYkSWnSfBXQ+/+/5SYiZVCybEoNzhelR37RJ7aLAWdF2+Uc9I5H5nIhSq+J n1D4vHoQtOzfTWOAJPDWmFkWpixF4lawyJu26sLy3nP10PHiSZM5ZgPrApSzpHfmbM1vKsJ79mMD8 EgdmMSlSxpAszRMVYmkirwWt0fG1hahe/sy6oLHnpf4QnvjqtKIKyFGa3F8UKCMCS8Bu8cisBa+Lu 4iQvaF4pRs8JCbR5RNWJvYb0RziH8g4PmtSFqhI6ADvztYl3M+ZM+Xc4UIL6/M6sIb5IjLDkiwcuL mIjoRgvqPWofRRakGWwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihiai-00074A-GW; Wed, 18 Dec 2019 23:18:52 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihiaf-00072u-F9 for linux-arm-kernel@lists.infradead.org; Wed, 18 Dec 2019 23:18:50 +0000 Received: by mail-qk1-x741.google.com with SMTP id x1so3062057qkl.12 for ; Wed, 18 Dec 2019 15:18:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nuyhYd8ECto87m9FuniOXYcBUixqQrUKuyD3AyEWA+A=; b=QEJ84Ho9x2u+RDV0L3fVLJ/07KGc8v4ji6189tqfgBzY4T9Zch4GF0ICOVmQiedFkK gO4tHFmI5AKY1yHkS5HmwQYH5w099hrSeCmDSLxdHK49ZwJao7LsADt7eFeAk/l3l3Lx vhmh1Z55xZ84AoRvPI0kPvYKhWj8/DEvynF8GDGjLZ28A7MxDzE5QZqE8bB348T9Imec VnKMOX6inmmxlz1s98+0hVZIcvQEJGNBImQ2V453cN632C6Nk8Vlvesscm4QA8Qmo1aG s935HuQHKFwUR6y/qra3A6ib1CF+reB133B+j1W732GGg527pTNwiD0EPZtT4A/ENTwb HI4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nuyhYd8ECto87m9FuniOXYcBUixqQrUKuyD3AyEWA+A=; b=kEVvSGOROgwHo1+xPwI9q+Z0Ho9dtGDa0L25wIvD+nAFU++qBuT3gdF9VXdgZYAD+i 3kyNwi308xfFm3sVzUrjf55T9TIYFFSAWbzWnCvthAxNWtfpD1oykycr9MUtuGU7zSn4 ZXy+Ti9DLAuYuNmBNY32ZH+Q1Op/SKPFEWwE83+YH1GhmdaCe9Wn5JRyFyFlrHY6lgvc ot4vBKjLsa0rbsp7jw/l7dBSpN8ItuU21GNvGv2puVu33+4LfHxkYO3rRoRCXdgsndTR cp+IpkwZj2O+KuPtvWQnsd6s+rWRdZKdpNNiaOHr544VDN1oDFhTusaa7ptUTZ2iCw+K I+Zw== X-Gm-Message-State: APjAAAWKKWhZ1TRHwK7285F+iAipo7Vme3B6Uz+h4ptnGP3lDL2Nusr0 7o5YhxnYhd44ZXG3GRH5IeczdB0S8kwPJkWlcB8= X-Google-Smtp-Source: APXvYqxmCgCcV71Y46Kd1h7x1kMPtfJ8a/HJjus1Y1SOXueUfBb+NFUsWJq8OEdBjSxCnnR0qVG1fuTHKRUTczc2+cE= X-Received: by 2002:a37:5d0:: with SMTP id 199mr5281279qkf.131.1576711128403; Wed, 18 Dec 2019 15:18:48 -0800 (PST) MIME-Version: 1.0 References: <20191218042121.1471954-1-anarsoul@gmail.com> <20191218042121.1471954-7-anarsoul@gmail.com> In-Reply-To: From: Vasily Khoruzhick Date: Wed, 18 Dec 2019 15:18:51 -0800 Message-ID: Subject: Re: [PATCH v7 6/7] arm64: dts: allwinner: h6: Add thermal sensor and thermal zones To: Chen-Yu Tsai X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191218_151849_506876_BC81FAFC X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Amit Kucheria , "open list:THERMAL" , Yangtao Li , Greg Kroah-Hartman , Daniel Lezcano , linux-kernel , Maxime Ripard , Rob Herring , Mauro Carvalho Chehab , Zhang Rui , =?UTF-8?Q?Ond=C5=99ej_Jirman?= , "David S. Miller" , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 17, 2019 at 8:32 PM Chen-Yu Tsai wrote: > > On Wed, Dec 18, 2019 at 12:22 PM Vasily Khoruzhick wrote: > > > > From: Ondrej Jirman > > > > There are two sensors, one for CPU, one for GPU. > > > > Signed-off-by: Ondrej Jirman > > Signed-off-by: Vasily Khoruzhick > > --- > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 ++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > index 29824081b43b..cdcb1a36301a 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -11,6 +11,7 @@ > > #include > > #include > > #include > > +#include > > > > / { > > interrupt-parent = <&gic>; > > @@ -233,6 +234,12 @@ dma: dma-controller@3002000 { > > sid: efuse@3006000 { > > compatible = "allwinner,sun50i-h6-sid"; > > reg = <0x03006000 0x400>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + ths_calibration: thermal-sensor-calibration@14 { > > + reg = <0x14 0x6>; > > Nit: my preference is to use words as the smallest increment, so this > would have a size of 8 instead of 6. Same goes for the A64 dts. > > AFAICT this doesn't impact the driver in any way. H6 has only 2 sensors, so it should be 4. That's my overlook, I'll change it to 4 for H6 and to 8 for A64. > > ChenYu > > > > + }; > > }; > > > > watchdog: watchdog@30090a0 { > > @@ -856,5 +863,31 @@ r_i2c: i2c@7081400 { > > #address-cells = <1>; > > #size-cells = <0>; > > }; > > + > > + ths: thermal-sensor@5070400 { > > + compatible = "allwinner,sun50i-h6-ths"; > > + reg = <0x05070400 0x100>; > > + interrupts = ; > > + clocks = <&ccu CLK_BUS_THS>; > > + clock-names = "bus"; > > + resets = <&ccu RST_BUS_THS>; > > + nvmem-cells = <&ths_calibration>; > > + nvmem-cell-names = "calibration"; > > + #thermal-sensor-cells = <1>; > > + }; > > + }; > > + > > + thermal-zones { > > + cpu-thermal { > > + polling-delay-passive = <0>; > > + polling-delay = <0>; > > + thermal-sensors = <&ths 0>; > > + }; > > + > > + gpu-thermal { > > + polling-delay-passive = <0>; > > + polling-delay = <0>; > > + thermal-sensors = <&ths 1>; > > + }; > > }; > > }; > > -- > > 2.24.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel