From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E186EC636C9 for ; Wed, 21 Jul 2021 08:32:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C903760725 for ; Wed, 21 Jul 2021 08:32:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237121AbhGUHuA (ORCPT ); Wed, 21 Jul 2021 03:50:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235919AbhGUHlB (ORCPT ); Wed, 21 Jul 2021 03:41:01 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18BEAC061574 for ; Wed, 21 Jul 2021 01:21:17 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id f12-20020a056830204cb029048bcf4c6bd9so1338640otp.8 for ; Wed, 21 Jul 2021 01:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4ljbr/BjAQXHoSjfnU/poMdQSYUhBIQOTVvbtplVbjY=; b=maSbKwVEYZFFrT24oXzJTzTOFffLltJ2yi6OgUCQHiqvRT85jX60r2L6xt7dT0MY5R /fGwK9XK8BJcx5IsZrxvnVhoXBjAAz5SG2EfRDTEMXvDD28Z6wGxqmQS4hDMZnRGrmkN bl/nkg4ZmCQEAg87r9gh994HwjiJdxV17bIpUWA9vyfq119CW6Sa0ePvxWqdHa8SGAJX P25ELNgH8iHrF1XL/XmGI5I/04pPt1Ro4pb/xyUVMtmmrPFmuLWE6p2CasMElZueQDRD iQ10xmDmbi+QaWVpgQ2bzpEKjMk93cEH11VC1GjuehVWtk3pbPKhydBEhZw2TYUIgh4L tJBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4ljbr/BjAQXHoSjfnU/poMdQSYUhBIQOTVvbtplVbjY=; b=uhWK9L5dNmn5z4s597SKOOHV4YPf5W0vdfxssUIm5M39xtlaP8kbHOOzdjgkufWTZv DwuURrTyBv6+gTqQvgE4tPzeg9chGh0WGBO8cskhXbABbS6vqflulxCZyXz4G+qjPh4S ryN4xZQArmZ+s1Cmu/bjHHWT26ULjyPvuHyysdSNpOmv+U52yzXbkd9YwQ0eiuF16b74 oIXkiIahXVEE5k11XgnsyXm51DLGqW8YMx24/ue9uzv+/RK7+Uvuu6DuiAd2B0azzsse a5NKQC5P5IsoIq55cTFkORgHfE4DG4x1yWrObWxLLyv/ZrGHhT0dwFe/UU58qCIlret2 JgBQ== X-Gm-Message-State: AOAM531XBZEQ06K6IsFLgTvE4JLVlzXTUXzHRUz9KyG8CJYpNhuuHZV7 2lfUaPYfjsfQNgYrNv7DGcEz9Sg0wYQeFtUNU9dRDQ== X-Google-Smtp-Source: ABdhPJyyehspCNVbLKAckLKJrrmnVHUkrdP6T8Euhhbd/dhCTqA37omyVRmpregC0z9MvGHlZQwyoWvs7UCHgaemIh8= X-Received: by 2002:a9d:4b02:: with SMTP id q2mr14525860otf.52.1626855676138; Wed, 21 Jul 2021 01:21:16 -0700 (PDT) MIME-Version: 1.0 References: <20210719104735.3681732-1-qperret@google.com> <20210719104735.3681732-12-qperret@google.com> In-Reply-To: <20210719104735.3681732-12-qperret@google.com> From: Fuad Tabba Date: Wed, 21 Jul 2021 09:20:39 +0100 Message-ID: Subject: Re: [PATCH 11/14] KVM: arm64: Expose kvm_pte_valid() helper To: Quentin Perret Cc: maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, ardb@kernel.org, qwandor@google.com, dbrazdil@google.com, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Quentin, On Mon, Jul 19, 2021 at 11:48 AM Quentin Perret wrote: > > The KVM pgtable API exposes the kvm_pgtable_walk() function to allow > the definition of walkers outside of pgtable.c. However, it is not easy > to implement any of those walkers without some of the low-level helpers, > such as kvm_pte_valid(). Make it static inline, and move it to the > header file to allow its re-use in other places. > > Signed-off-by: Quentin Perret > --- > arch/arm64/include/asm/kvm_pgtable.h | 7 +++++++ > arch/arm64/kvm/hyp/pgtable.c | 6 ------ > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > index 1aa49d6aabb7..8240c881ae1e 100644 > --- a/arch/arm64/include/asm/kvm_pgtable.h > +++ b/arch/arm64/include/asm/kvm_pgtable.h > @@ -25,6 +25,13 @@ static inline u64 kvm_get_parange(u64 mmfr0) > > typedef u64 kvm_pte_t; > > +#define KVM_PTE_VALID BIT(0) > + I don't know if there's a better solution for this, but having the KVM_PTE_VALID by itself here, with the rest remaining in pgtable.c might be confusing. I see that you probably don't want to move them all here because they are internal to pgtable.c. Thanks, /fuad > +static inline bool kvm_pte_valid(kvm_pte_t pte) > +{ > + return pte & KVM_PTE_VALID; > +} > + > /** > * struct kvm_pgtable_mm_ops - Memory management callbacks. > * @zalloc_page: Allocate a single zeroed memory page. > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index c7120797404a..e0ae57dca827 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -11,7 +11,6 @@ > #include > #include > > -#define KVM_PTE_VALID BIT(0) > > #define KVM_PTE_TYPE BIT(1) > #define KVM_PTE_TYPE_BLOCK 0 > @@ -135,11 +134,6 @@ static u32 kvm_pgd_pages(u32 ia_bits, u32 start_level) > return __kvm_pgd_page_idx(&pgt, -1ULL) + 1; > } > > -static bool kvm_pte_valid(kvm_pte_t pte) > -{ > - return pte & KVM_PTE_VALID; > -} > - > static bool kvm_pte_table(kvm_pte_t pte, u32 level) > { > if (level == KVM_PGTABLE_MAX_LEVELS - 1) > -- > 2.32.0.402.g57bb445576-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A2DFC07E9B for ; Wed, 21 Jul 2021 08:21:21 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 9A60F6120D for ; Wed, 21 Jul 2021 08:21:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A60F6120D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0DDAB4B13B; Wed, 21 Jul 2021 04:21:20 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rOUEIoHz4T5e; Wed, 21 Jul 2021 04:21:19 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id F174F4B12C; Wed, 21 Jul 2021 04:21:18 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 114004B12A for ; Wed, 21 Jul 2021 04:21:18 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8gFFZlrd7Uny for ; Wed, 21 Jul 2021 04:21:17 -0400 (EDT) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 0E3E24B126 for ; Wed, 21 Jul 2021 04:21:16 -0400 (EDT) Received: by mail-ot1-f48.google.com with SMTP id 59-20020a9d0ac10000b0290462f0ab0800so1325021otq.11 for ; Wed, 21 Jul 2021 01:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4ljbr/BjAQXHoSjfnU/poMdQSYUhBIQOTVvbtplVbjY=; b=maSbKwVEYZFFrT24oXzJTzTOFffLltJ2yi6OgUCQHiqvRT85jX60r2L6xt7dT0MY5R /fGwK9XK8BJcx5IsZrxvnVhoXBjAAz5SG2EfRDTEMXvDD28Z6wGxqmQS4hDMZnRGrmkN bl/nkg4ZmCQEAg87r9gh994HwjiJdxV17bIpUWA9vyfq119CW6Sa0ePvxWqdHa8SGAJX P25ELNgH8iHrF1XL/XmGI5I/04pPt1Ro4pb/xyUVMtmmrPFmuLWE6p2CasMElZueQDRD iQ10xmDmbi+QaWVpgQ2bzpEKjMk93cEH11VC1GjuehVWtk3pbPKhydBEhZw2TYUIgh4L tJBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4ljbr/BjAQXHoSjfnU/poMdQSYUhBIQOTVvbtplVbjY=; b=kNC2/dVj3+QMzStP4hxyJBy5LgbEnQWuWTdpFdWYJqQPPTaXA2/5Si0QfyAczajRGB 7AIXiqq+pgBLYwSYYq3xG4MRS0ZQs3GFkfx+6BrNdwVL183Jmk7iCUi9JeW4Fi0QjmuV KJsV1/NyQRitIU2tRxlKQOqTOxUYfbBgROr568qa43r2IC/VuCLycTi0NHpd0wy9bslf 9jHgnGBQ+CFN/avcXNpGMPyOlMvgyECBdtu0xrF/rLZwKUQzYTcBTytyhV0RVo/bRcOa je6fgLHhZ9WCoLWRErIL5w9jwaI0Qb7jC9nIOOSTY+tri9I2d3kTHqABKiPxslDKNIyo SNGQ== X-Gm-Message-State: AOAM53056HXnTgkX+JbIr6pTWV4mg6whwzm5as5AKt3UijiyxgYqAdPd 7LyQlj2djzmgL9U0Gq1x+rwf6FbKrdLYMNkum6PQcg== X-Google-Smtp-Source: ABdhPJyyehspCNVbLKAckLKJrrmnVHUkrdP6T8Euhhbd/dhCTqA37omyVRmpregC0z9MvGHlZQwyoWvs7UCHgaemIh8= X-Received: by 2002:a9d:4b02:: with SMTP id q2mr14525860otf.52.1626855676138; Wed, 21 Jul 2021 01:21:16 -0700 (PDT) MIME-Version: 1.0 References: <20210719104735.3681732-1-qperret@google.com> <20210719104735.3681732-12-qperret@google.com> In-Reply-To: <20210719104735.3681732-12-qperret@google.com> From: Fuad Tabba Date: Wed, 21 Jul 2021 09:20:39 +0100 Message-ID: Subject: Re: [PATCH 11/14] KVM: arm64: Expose kvm_pte_valid() helper To: Quentin Perret Cc: kernel-team@android.com, qwandor@google.com, maz@kernel.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Quentin, On Mon, Jul 19, 2021 at 11:48 AM Quentin Perret wrote: > > The KVM pgtable API exposes the kvm_pgtable_walk() function to allow > the definition of walkers outside of pgtable.c. However, it is not easy > to implement any of those walkers without some of the low-level helpers, > such as kvm_pte_valid(). Make it static inline, and move it to the > header file to allow its re-use in other places. > > Signed-off-by: Quentin Perret > --- > arch/arm64/include/asm/kvm_pgtable.h | 7 +++++++ > arch/arm64/kvm/hyp/pgtable.c | 6 ------ > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > index 1aa49d6aabb7..8240c881ae1e 100644 > --- a/arch/arm64/include/asm/kvm_pgtable.h > +++ b/arch/arm64/include/asm/kvm_pgtable.h > @@ -25,6 +25,13 @@ static inline u64 kvm_get_parange(u64 mmfr0) > > typedef u64 kvm_pte_t; > > +#define KVM_PTE_VALID BIT(0) > + I don't know if there's a better solution for this, but having the KVM_PTE_VALID by itself here, with the rest remaining in pgtable.c might be confusing. I see that you probably don't want to move them all here because they are internal to pgtable.c. Thanks, /fuad > +static inline bool kvm_pte_valid(kvm_pte_t pte) > +{ > + return pte & KVM_PTE_VALID; > +} > + > /** > * struct kvm_pgtable_mm_ops - Memory management callbacks. > * @zalloc_page: Allocate a single zeroed memory page. > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index c7120797404a..e0ae57dca827 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -11,7 +11,6 @@ > #include > #include > > -#define KVM_PTE_VALID BIT(0) > > #define KVM_PTE_TYPE BIT(1) > #define KVM_PTE_TYPE_BLOCK 0 > @@ -135,11 +134,6 @@ static u32 kvm_pgd_pages(u32 ia_bits, u32 start_level) > return __kvm_pgd_page_idx(&pgt, -1ULL) + 1; > } > > -static bool kvm_pte_valid(kvm_pte_t pte) > -{ > - return pte & KVM_PTE_VALID; > -} > - > static bool kvm_pte_table(kvm_pte_t pte, u32 level) > { > if (level == KVM_PGTABLE_MAX_LEVELS - 1) > -- > 2.32.0.402.g57bb445576-goog > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8305FC636C9 for ; Wed, 21 Jul 2021 08:22:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5433C6120D for ; Wed, 21 Jul 2021 08:22:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5433C6120D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2bt5ePcWq8hnSLv1IT9Udp5vGwrRjQlmc451Cnp6o40=; b=3BVhOO2dfLMKWz 0mwxYt1CNNI445LIK4wSq/tG00MNZoOcEGWrooOI6pFe0p3cc24UaxflYSa5FO68Te67G1KA7HFto SWbY88A253HqGBIMi8HlajqrdXSKsPtvjVr4Wetwk5iqB0JlLJDr0xxldeQV3dQLjEbKrrEKL5G7a QJYybZDEfs9+IgIYA3AjlCZgoo9C5JGlXWGlT3ZJdDgi/Pc9OBWI/YON5uxtnwCGBuKKnXpYCm+ZM w6GvD00CxOFdYdUE4fYhTJ1IzO5q0P65Hktj04fUJfdWBAHzwKU5lP0K+cQvd7gKE2RgBcDo3hGnR KiaMDwgLZANJUwVbSa2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m67Tm-00EsfL-2e; Wed, 21 Jul 2021 08:21:22 +0000 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m67Ti-00EseM-9M for linux-arm-kernel@lists.infradead.org; Wed, 21 Jul 2021 08:21:19 +0000 Received: by mail-ot1-x32e.google.com with SMTP id a17-20020a9d3e110000b02904ce97efee36so1339086otd.7 for ; Wed, 21 Jul 2021 01:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4ljbr/BjAQXHoSjfnU/poMdQSYUhBIQOTVvbtplVbjY=; b=maSbKwVEYZFFrT24oXzJTzTOFffLltJ2yi6OgUCQHiqvRT85jX60r2L6xt7dT0MY5R /fGwK9XK8BJcx5IsZrxvnVhoXBjAAz5SG2EfRDTEMXvDD28Z6wGxqmQS4hDMZnRGrmkN bl/nkg4ZmCQEAg87r9gh994HwjiJdxV17bIpUWA9vyfq119CW6Sa0ePvxWqdHa8SGAJX P25ELNgH8iHrF1XL/XmGI5I/04pPt1Ro4pb/xyUVMtmmrPFmuLWE6p2CasMElZueQDRD iQ10xmDmbi+QaWVpgQ2bzpEKjMk93cEH11VC1GjuehVWtk3pbPKhydBEhZw2TYUIgh4L tJBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4ljbr/BjAQXHoSjfnU/poMdQSYUhBIQOTVvbtplVbjY=; b=MOF2FPNPM6bL9B2DTH1WKPfT7huCQxBgA/xapp1hIyesa/9HpQSZrMDwtJv8H/fKEI Dgzp3jUZzWMoQdzEfYSxJSir7T67G5oTfu8W6iGCurq7ksOOMs4W5xmE1T1Xh1447tUR bNF9UW7VxkDDXdXxM6BKDbIheDWsCX56B9ASyXRlb+v4iQOxSbJz9KQqbmulBnaG2Rzq NwrwSTyh1OJpJgKXDiOjX2ckKpIs/MV91J7Bt0AsQQP7bBNYQwkStTmNY5Mt6wfzDj9h srPMEnjRAxGjfGi11OMGFWZjc0tey1jOQHi0f6IYBgFBHlIxYi+tA0tgP+2tnbD0UAKD MaDQ== X-Gm-Message-State: AOAM532E/RazjxYplsUJVOBN3XcJv5/4zVT4ILa9bkRzJHVE+s1vbe6h +oERpiGB8D4urImfQKCpodvjYCGHvvN3ZfEtRpHKFA== X-Google-Smtp-Source: ABdhPJyyehspCNVbLKAckLKJrrmnVHUkrdP6T8Euhhbd/dhCTqA37omyVRmpregC0z9MvGHlZQwyoWvs7UCHgaemIh8= X-Received: by 2002:a9d:4b02:: with SMTP id q2mr14525860otf.52.1626855676138; Wed, 21 Jul 2021 01:21:16 -0700 (PDT) MIME-Version: 1.0 References: <20210719104735.3681732-1-qperret@google.com> <20210719104735.3681732-12-qperret@google.com> In-Reply-To: <20210719104735.3681732-12-qperret@google.com> From: Fuad Tabba Date: Wed, 21 Jul 2021 09:20:39 +0100 Message-ID: Subject: Re: [PATCH 11/14] KVM: arm64: Expose kvm_pte_valid() helper To: Quentin Perret Cc: maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, ardb@kernel.org, qwandor@google.com, dbrazdil@google.com, kernel-team@android.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_012118_393277_44C3C228 X-CRM114-Status: GOOD ( 22.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Quentin, On Mon, Jul 19, 2021 at 11:48 AM Quentin Perret wrote: > > The KVM pgtable API exposes the kvm_pgtable_walk() function to allow > the definition of walkers outside of pgtable.c. However, it is not easy > to implement any of those walkers without some of the low-level helpers, > such as kvm_pte_valid(). Make it static inline, and move it to the > header file to allow its re-use in other places. > > Signed-off-by: Quentin Perret > --- > arch/arm64/include/asm/kvm_pgtable.h | 7 +++++++ > arch/arm64/kvm/hyp/pgtable.c | 6 ------ > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > index 1aa49d6aabb7..8240c881ae1e 100644 > --- a/arch/arm64/include/asm/kvm_pgtable.h > +++ b/arch/arm64/include/asm/kvm_pgtable.h > @@ -25,6 +25,13 @@ static inline u64 kvm_get_parange(u64 mmfr0) > > typedef u64 kvm_pte_t; > > +#define KVM_PTE_VALID BIT(0) > + I don't know if there's a better solution for this, but having the KVM_PTE_VALID by itself here, with the rest remaining in pgtable.c might be confusing. I see that you probably don't want to move them all here because they are internal to pgtable.c. Thanks, /fuad > +static inline bool kvm_pte_valid(kvm_pte_t pte) > +{ > + return pte & KVM_PTE_VALID; > +} > + > /** > * struct kvm_pgtable_mm_ops - Memory management callbacks. > * @zalloc_page: Allocate a single zeroed memory page. > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index c7120797404a..e0ae57dca827 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -11,7 +11,6 @@ > #include > #include > > -#define KVM_PTE_VALID BIT(0) > > #define KVM_PTE_TYPE BIT(1) > #define KVM_PTE_TYPE_BLOCK 0 > @@ -135,11 +134,6 @@ static u32 kvm_pgd_pages(u32 ia_bits, u32 start_level) > return __kvm_pgd_page_idx(&pgt, -1ULL) + 1; > } > > -static bool kvm_pte_valid(kvm_pte_t pte) > -{ > - return pte & KVM_PTE_VALID; > -} > - > static bool kvm_pte_table(kvm_pte_t pte, u32 level) > { > if (level == KVM_PGTABLE_MAX_LEVELS - 1) > -- > 2.32.0.402.g57bb445576-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel