From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24231C43334 for ; Wed, 8 Jun 2022 07:40:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 90FBF49EB2; Wed, 8 Jun 2022 03:40:54 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xLrbB6rEUz28; Wed, 8 Jun 2022 03:40:53 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 659E44B093; Wed, 8 Jun 2022 03:40:53 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7475449ED9 for ; Wed, 8 Jun 2022 03:40:52 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v1axuh9JTd8h for ; Wed, 8 Jun 2022 03:40:51 -0400 (EDT) Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 7ACDE49EB2 for ; Wed, 8 Jun 2022 03:40:51 -0400 (EDT) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-f2cbceefb8so26186461fac.11 for ; Wed, 08 Jun 2022 00:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4C+HR3kdGNMQU0VniOy6D2TLr5OZWg8RJ6oE98/dwoc=; b=lniF6SLwf2sUXG4L0oxq7Wvjkomm8JSVVcdy9UzJDPuqG9mEJpDr1yJXXD8UEn8ubM DP7YyQB0975e/YbQSSGUijeh7xrN31/yqUtCCrcEaxk6ysdAfEnEG42VefCFXo/ua0BH CjN+8JiKVCb0pxnVxMjrz4HvhAu28Lujp3EqMXIp+bS6ugnqNVvRhLBpwUrL4M4P4od0 mow1rtEcXV2IdS5nu9EyuXgjt7u/n2/BqItaCrd9FbYugktvOlRupZv7BJw7MHAv02aS dfsm6fuod9FPKaaXXLOjjoPcHvKi1Pft/nRpXH2+T0MqaqVEoMMoHdcT9vSNZn3+FX4D SvGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4C+HR3kdGNMQU0VniOy6D2TLr5OZWg8RJ6oE98/dwoc=; b=1ZPSo6BL5Y8JPdOgmUHIP2oO/ipHR1Nc5nSIgCbtwaPTlmtswi14TzaRjsbF9xreOr eqRc5BDyQF6il+c3Er+YcgjYrMUGkeHxSLHMpuYvSrQ54kbBlxrVEU30F3ztJGjINXPl wD3Y/k0hJzCamwiq7SA28VXZ2/GtHR+iBfUxxP/NA5qMY5x1ziLJ/DunSlEC4iMuH1rY EvfKhVKK/zdmAdU8wiL2ppJIrgY0dE92NcmxV4RB2J4SPsdcRUq/fP3rvHr6pv8nq9sl udNmb/6aHf1p1S+dzcQRlngWR+AHIXy9CaXpp8lf8jCev8yntmilFNNULLTfx3Z2tmhh Rb2w== X-Gm-Message-State: AOAM533CTCi46O6zXLGu3CyR6rmOBTTOimcZLQP/sICaC0yhP/Ov5IY2 SLH+ulgEycMXRnKFJ8Z8Ejs1lOUHELDBuYdz3xsVJA== X-Google-Smtp-Source: ABdhPJxJU2tr9O9BGDzNE7cjJh/nBawaDlGq2ZFiX9T3Jx1K4j1sILs6YF386g05D+iAgS/6fcxJ3SXP4KDchr+cHKE= X-Received: by 2002:a05:6870:961b:b0:e2:ffb9:f526 with SMTP id d27-20020a056870961b00b000e2ffb9f526mr1662882oaq.146.1654674050672; Wed, 08 Jun 2022 00:40:50 -0700 (PDT) MIME-Version: 1.0 References: <20220519134204.5379-1-will@kernel.org> <20220519134204.5379-60-will@kernel.org> In-Reply-To: From: Fuad Tabba Date: Wed, 8 Jun 2022 08:40:14 +0100 Message-ID: Subject: Re: [PATCH 59/89] KVM: arm64: Do not support MTE for protected VMs To: Peter Collingbourne Cc: Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, Andy Lutomirski , Michael Roth , Catalin Marinas , Chao Peng , Will Deacon , kvmarm@lists.cs.columbia.edu, Linux ARM X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Peter, On Tue, Jun 7, 2022 at 1:42 AM Peter Collingbourne wrote: > > On Thu, May 19, 2022 at 7:40 AM Will Deacon wrote: > > > > From: Fuad Tabba > > > > Return an error (-EINVAL) if trying to enable MTE on a protected > > vm. > > > > Signed-off-by: Fuad Tabba > > --- > > arch/arm64/kvm/arm.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > index 10e036bf06e3..8a1b4ba1dfa7 100644 > > --- a/arch/arm64/kvm/arm.c > > +++ b/arch/arm64/kvm/arm.c > > @@ -90,7 +90,9 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, > > break; > > case KVM_CAP_ARM_MTE: > > mutex_lock(&kvm->lock); > > - if (!system_supports_mte() || kvm->created_vcpus) { > > + if (!system_supports_mte() || > > + kvm_vm_is_protected(kvm) || > > Should this check be added to kvm_vm_ioctl_check_extension() as well? No need. kvm_vm_ioctl_check_extension() calls pkvm_check_extension() for protected vms, which functions as an allow list rather than a block list. Cheers, /fuad > Peter _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98015C433EF for ; Wed, 8 Jun 2022 07:42:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zKLThpzqPo+HPs/tjONR4XUkwpTqKluKUjY++pHYUYw=; b=NyECgHkmSd8Wwr 8JtElyEezaD/8hZ4Trnh0egHUBMn2C35clFpOW4Rj7RcJT7Vf72DupX+BhBpnK0PZhBJcju/uq6+C mFhdKNKJxgfGfbbV0IfUcE4xiUA0OEU9SXul0B0aVNV0JgPAgJDp/VFlIrfn+1jVaOZF8jcB2hxKP FKeV2BWs7OpP+OCLhHpP5ctzBfxuj+MomHgsl6YeD0ppXwxaXB9SiAamsvp7LLeJo4WLZAxU/dyWR xcaVkzSJa03v7aR8b6/8GIs1Xz29KCtcOPr3UHqazySd/hCNjtLWghtwzPwTp3vMZlRw81vEcI/Nl priKbhiqBR6S7sBj1HJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyqJJ-00BfhD-HJ; Wed, 08 Jun 2022 07:41:01 +0000 Received: from mail-oa1-x31.google.com ([2001:4860:4864:20::31]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyqJE-00Bfei-NT for linux-arm-kernel@lists.infradead.org; Wed, 08 Jun 2022 07:40:57 +0000 Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-fdfe64231dso3781687fac.1 for ; Wed, 08 Jun 2022 00:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4C+HR3kdGNMQU0VniOy6D2TLr5OZWg8RJ6oE98/dwoc=; b=lniF6SLwf2sUXG4L0oxq7Wvjkomm8JSVVcdy9UzJDPuqG9mEJpDr1yJXXD8UEn8ubM DP7YyQB0975e/YbQSSGUijeh7xrN31/yqUtCCrcEaxk6ysdAfEnEG42VefCFXo/ua0BH CjN+8JiKVCb0pxnVxMjrz4HvhAu28Lujp3EqMXIp+bS6ugnqNVvRhLBpwUrL4M4P4od0 mow1rtEcXV2IdS5nu9EyuXgjt7u/n2/BqItaCrd9FbYugktvOlRupZv7BJw7MHAv02aS dfsm6fuod9FPKaaXXLOjjoPcHvKi1Pft/nRpXH2+T0MqaqVEoMMoHdcT9vSNZn3+FX4D SvGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4C+HR3kdGNMQU0VniOy6D2TLr5OZWg8RJ6oE98/dwoc=; b=Kksl3782rwU/lS6JPod69W4h3gFrEciXlfpgH6JCYikJWwR5TvZLZr5PSVknlhVxmy 0iQvADutySQwEUHl+HPSikgAOlEB+RLLp823rABFreYlf0162wBkHqA7pNEGLtcAEL5s /gW2siAUQ/lY7fZJZeFGWADJPpTCaPDR+QN/FuFqWtqwkP3rOcf2mbqhmhVX0nKUDUlm tuCW9npdu9IJwQqZYgX4LudyIV7JFNj7oHKGcH7sVI8w7tSTOefYKljoua2QgiZj0xc6 d02+Ck+zl/x2vmp2A4qlTdx19Fy64Lbp+LRV+iaora1lbnwCP3mH9A+/VxvAXcMavsm3 ybMw== X-Gm-Message-State: AOAM531+NDBeNszAU1zRVpnu1ersTiXuOl9PDlLedHN90ec5RgtJtYRZ UAMVfZ14r5P1FVzmXnbYcQvyaPAqU8tbgDWVB8yddQ== X-Google-Smtp-Source: ABdhPJxJU2tr9O9BGDzNE7cjJh/nBawaDlGq2ZFiX9T3Jx1K4j1sILs6YF386g05D+iAgS/6fcxJ3SXP4KDchr+cHKE= X-Received: by 2002:a05:6870:961b:b0:e2:ffb9:f526 with SMTP id d27-20020a056870961b00b000e2ffb9f526mr1662882oaq.146.1654674050672; Wed, 08 Jun 2022 00:40:50 -0700 (PDT) MIME-Version: 1.0 References: <20220519134204.5379-1-will@kernel.org> <20220519134204.5379-60-will@kernel.org> In-Reply-To: From: Fuad Tabba Date: Wed, 8 Jun 2022 08:40:14 +0100 Message-ID: Subject: Re: [PATCH 59/89] KVM: arm64: Do not support MTE for protected VMs To: Peter Collingbourne Cc: Will Deacon , kvmarm@lists.cs.columbia.edu, Ard Biesheuvel , Sean Christopherson , Alexandru Elisei , Andy Lutomirski , Catalin Marinas , James Morse , Chao Peng , Quentin Perret , Suzuki K Poulose , Michael Roth , Mark Rutland , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_004056_806243_17FA8183 X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peter, On Tue, Jun 7, 2022 at 1:42 AM Peter Collingbourne wrote: > > On Thu, May 19, 2022 at 7:40 AM Will Deacon wrote: > > > > From: Fuad Tabba > > > > Return an error (-EINVAL) if trying to enable MTE on a protected > > vm. > > > > Signed-off-by: Fuad Tabba > > --- > > arch/arm64/kvm/arm.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > index 10e036bf06e3..8a1b4ba1dfa7 100644 > > --- a/arch/arm64/kvm/arm.c > > +++ b/arch/arm64/kvm/arm.c > > @@ -90,7 +90,9 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, > > break; > > case KVM_CAP_ARM_MTE: > > mutex_lock(&kvm->lock); > > - if (!system_supports_mte() || kvm->created_vcpus) { > > + if (!system_supports_mte() || > > + kvm_vm_is_protected(kvm) || > > Should this check be added to kvm_vm_ioctl_check_extension() as well? No need. kvm_vm_ioctl_check_extension() calls pkvm_check_extension() for protected vms, which functions as an allow list rather than a block list. Cheers, /fuad > Peter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 784A2C43334 for ; Wed, 8 Jun 2022 08:12:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230183AbiFHIMw (ORCPT ); Wed, 8 Jun 2022 04:12:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230205AbiFHIMG (ORCPT ); Wed, 8 Jun 2022 04:12:06 -0400 Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B2B62132AE for ; Wed, 8 Jun 2022 00:40:51 -0700 (PDT) Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-fe023ab520so2995445fac.10 for ; Wed, 08 Jun 2022 00:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4C+HR3kdGNMQU0VniOy6D2TLr5OZWg8RJ6oE98/dwoc=; b=lniF6SLwf2sUXG4L0oxq7Wvjkomm8JSVVcdy9UzJDPuqG9mEJpDr1yJXXD8UEn8ubM DP7YyQB0975e/YbQSSGUijeh7xrN31/yqUtCCrcEaxk6ysdAfEnEG42VefCFXo/ua0BH CjN+8JiKVCb0pxnVxMjrz4HvhAu28Lujp3EqMXIp+bS6ugnqNVvRhLBpwUrL4M4P4od0 mow1rtEcXV2IdS5nu9EyuXgjt7u/n2/BqItaCrd9FbYugktvOlRupZv7BJw7MHAv02aS dfsm6fuod9FPKaaXXLOjjoPcHvKi1Pft/nRpXH2+T0MqaqVEoMMoHdcT9vSNZn3+FX4D SvGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4C+HR3kdGNMQU0VniOy6D2TLr5OZWg8RJ6oE98/dwoc=; b=XP6IUXvija13hXo64OAg7+yuhMLZZycOmcC2M5/NoJ9Atec5jTrpVAHnseJiXxZ2Fe jgYHNOOxGosPjmFpDmRnYDqLD8oYSEwHEd3o/Az285XuXbwr0F9n3jxNlLO+HsprVSGo 9ar8RAurKxHpIt6BqXX+xHjpzzua92i+5p687PkmkIyUtV4yItCRynnSw97o3T0xlgVJ mneemb6QnJiX2dBFa3froQvAI9Jni4+naiELZ5XSkjebqajtFTy5y+mORUeC5sLvYbJk reV7VMA4L/eo1bnYmfMoSEHGD64718x+zvleFRpAYfxnk5vmrB6YtffOfRlirAP1cpIA tQEQ== X-Gm-Message-State: AOAM530HCqL2CWpaESDmgdrmi6J5h/v9mdGeyFlYgf01zla2O0lkF7Lj sLuEM5ltSFNCoqgTp+Tq46bqXEOm6a2PT9SoRmy1Ww== X-Google-Smtp-Source: ABdhPJxJU2tr9O9BGDzNE7cjJh/nBawaDlGq2ZFiX9T3Jx1K4j1sILs6YF386g05D+iAgS/6fcxJ3SXP4KDchr+cHKE= X-Received: by 2002:a05:6870:961b:b0:e2:ffb9:f526 with SMTP id d27-20020a056870961b00b000e2ffb9f526mr1662882oaq.146.1654674050672; Wed, 08 Jun 2022 00:40:50 -0700 (PDT) MIME-Version: 1.0 References: <20220519134204.5379-1-will@kernel.org> <20220519134204.5379-60-will@kernel.org> In-Reply-To: From: Fuad Tabba Date: Wed, 8 Jun 2022 08:40:14 +0100 Message-ID: Subject: Re: [PATCH 59/89] KVM: arm64: Do not support MTE for protected VMs To: Peter Collingbourne Cc: Will Deacon , kvmarm@lists.cs.columbia.edu, Ard Biesheuvel , Sean Christopherson , Alexandru Elisei , Andy Lutomirski , Catalin Marinas , James Morse , Chao Peng , Quentin Perret , Suzuki K Poulose , Michael Roth , Mark Rutland , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Peter, On Tue, Jun 7, 2022 at 1:42 AM Peter Collingbourne wrote: > > On Thu, May 19, 2022 at 7:40 AM Will Deacon wrote: > > > > From: Fuad Tabba > > > > Return an error (-EINVAL) if trying to enable MTE on a protected > > vm. > > > > Signed-off-by: Fuad Tabba > > --- > > arch/arm64/kvm/arm.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > index 10e036bf06e3..8a1b4ba1dfa7 100644 > > --- a/arch/arm64/kvm/arm.c > > +++ b/arch/arm64/kvm/arm.c > > @@ -90,7 +90,9 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, > > break; > > case KVM_CAP_ARM_MTE: > > mutex_lock(&kvm->lock); > > - if (!system_supports_mte() || kvm->created_vcpus) { > > + if (!system_supports_mte() || > > + kvm_vm_is_protected(kvm) || > > Should this check be added to kvm_vm_ioctl_check_extension() as well? No need. kvm_vm_ioctl_check_extension() calls pkvm_check_extension() for protected vms, which functions as an allow list rather than a block list. Cheers, /fuad > Peter