From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0500EC48BDF for ; Fri, 18 Jun 2021 08:59:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D031F61260 for ; Fri, 18 Jun 2021 08:59:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232442AbhFRJB4 (ORCPT ); Fri, 18 Jun 2021 05:01:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230076AbhFRJBz (ORCPT ); Fri, 18 Jun 2021 05:01:55 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA5FAC06175F for ; Fri, 18 Jun 2021 01:59:45 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id k10-20020a056830168ab029044d922f6a45so641314otr.7 for ; Fri, 18 Jun 2021 01:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kxWq/w4pUVc8HOlAC++EsNgPCdWz4WRSzn6eNlOcpd8=; b=bhaMQb0WGrbDqa+aKHcQIksSIM+zTHdcqFfPBr5BV5rr/Wi8UST4PtBaFBBmWA70/c JeE4Hu4BbtwFqF0c80sjfACvvB1nesUeK9TieyU/oqhdgOex7UgfdkqRux0UxZ5/TcHT DLHvuKVExIhZtgV1fPhYLr/Md+zpFpFjNVpAPjGlXCP+m9MsUwKdcLN7akLZFoz7RcTk 238s+sJ/BuekxpTMYI4dcJE/HjWwxIUM3JYIJt/VdYH2Zb8cmBY3gzekVcESfoAgP54o bIIHlFX/dEToFLWW+5NXkS2fXPFEuRa4egZ9ULCaZiOK2z8px8znd93Nlh17ZN0KkdrP Dwpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kxWq/w4pUVc8HOlAC++EsNgPCdWz4WRSzn6eNlOcpd8=; b=D35BBlpfuihu30kDGLIIslTzw38n7mnMfYnbyfhwM5v9HZx3moiEvbBC4nLPiAH0iu lQMZqEc8Q6/1flHzNTkP8cEv4quhPEgvKiypeEjUbrb/gijzvRU77aUqhcUVSb/neti6 s6ZgPNYWb91gz0V6BmYtfX+2YjKTF8JAHBjcocL/X0TMJkSIYUIjspUqmjTZgUCrZrlL cMoYahTb5VOX3Zd+CGjbRcH9R4dhzMR6vcl7F4Wp8zV/gMqZ9gIeNQI69u1tJn6+9V8n QL2DtYV0Zt2UQnlvlulVrs+rws8ta81AwIFxbJcokVDEg3F6zCTzCc0VNYST44Gas8Y6 DneA== X-Gm-Message-State: AOAM531pI501Q0brx8b1X74FKfWa+/8aD/OkaawLLttGMwR4HOaPfQ3G 4Iljb8fLp9zg5i0cQGUvSxUacq3V3LVbo8GVVakP1A== X-Google-Smtp-Source: ABdhPJwzc7DiWjyKPp58Q0od7P57f5+tDcapLIkUHFsPNVK62ZAuAwBi+XcIKklM8bb9dajJNv9sTtXhTaAbgYqG490= X-Received: by 2002:a05:6830:1598:: with SMTP id i24mr8497546otr.52.1624006785056; Fri, 18 Jun 2021 01:59:45 -0700 (PDT) MIME-Version: 1.0 References: <20210617105824.31752-1-wangyanan55@huawei.com> <20210617105824.31752-2-wangyanan55@huawei.com> <20210617123837.GA24457@willie-the-truck> <87eed0d13p.wl-maz@kernel.org> <2c1b9376-3997-aa7b-d5f3-b04da985c260@huawei.com> In-Reply-To: <2c1b9376-3997-aa7b-d5f3-b04da985c260@huawei.com> From: Fuad Tabba Date: Fri, 18 Jun 2021 09:59:09 +0100 Message-ID: Subject: Re: [PATCH v7 1/4] KVM: arm64: Introduce two cache maintenance callbacks To: "wangyanan (Y)" Cc: Marc Zyngier , Will Deacon , kvm@vger.kernel.org, Catalin Marinas , linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Jun 18, 2021 at 2:52 AM wangyanan (Y) wrote: > > > > On 2021/6/17 22:20, Marc Zyngier wrote: > > On Thu, 17 Jun 2021 13:38:37 +0100, > > Will Deacon wrote: > >> On Thu, Jun 17, 2021 at 06:58:21PM +0800, Yanan Wang wrote: > >>> To prepare for performing CMOs for guest stage-2 in the fault handlers > >>> in pgtable.c, here introduce two cache maintenance callbacks in struct > >>> kvm_pgtable_mm_ops. We also adjust the comment alignment for the > >>> existing part but make no real content change at all. > >>> > >>> Signed-off-by: Yanan Wang > >>> --- > >>> arch/arm64/include/asm/kvm_pgtable.h | 42 +++++++++++++++++----------- > >>> 1 file changed, 25 insertions(+), 17 deletions(-) > >>> > >>> diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > >>> index c3674c47d48c..b6ce34aa44bb 100644 > >>> --- a/arch/arm64/include/asm/kvm_pgtable.h > >>> +++ b/arch/arm64/include/asm/kvm_pgtable.h > >>> @@ -27,23 +27,29 @@ typedef u64 kvm_pte_t; > >>> > >>> /** > >>> * struct kvm_pgtable_mm_ops - Memory management callbacks. > >>> - * @zalloc_page: Allocate a single zeroed memory page. The @arg parameter > >>> - * can be used by the walker to pass a memcache. The > >>> - * initial refcount of the page is 1. > >>> - * @zalloc_pages_exact: Allocate an exact number of zeroed memory pages. The > >>> - * @size parameter is in bytes, and is rounded-up to the > >>> - * next page boundary. The resulting allocation is > >>> - * physically contiguous. > >>> - * @free_pages_exact: Free an exact number of memory pages previously > >>> - * allocated by zalloc_pages_exact. > >>> - * @get_page: Increment the refcount on a page. > >>> - * @put_page: Decrement the refcount on a page. When the refcount > >>> - * reaches 0 the page is automatically freed. > >>> - * @page_count: Return the refcount of a page. > >>> - * @phys_to_virt: Convert a physical address into a virtual address mapped > >>> - * in the current context. > >>> - * @virt_to_phys: Convert a virtual address mapped in the current context > >>> - * into a physical address. > >>> + * @zalloc_page: Allocate a single zeroed memory page. > >>> + * The @arg parameter can be used by the walker > >>> + * to pass a memcache. The initial refcount of > >>> + * the page is 1. > >>> + * @zalloc_pages_exact: Allocate an exact number of zeroed memory pages. > >>> + * The @size parameter is in bytes, and is rounded > >>> + * up to the next page boundary. The resulting > >>> + * allocation is physically contiguous. > >>> + * @free_pages_exact: Free an exact number of memory pages previously > >>> + * allocated by zalloc_pages_exact. > >>> + * @get_page: Increment the refcount on a page. > >>> + * @put_page: Decrement the refcount on a page. When the > >>> + * refcount reaches 0 the page is automatically > >>> + * freed. > >>> + * @page_count: Return the refcount of a page. > >>> + * @phys_to_virt: Convert a physical address into a virtual address > >>> + * mapped in the current context. > >>> + * @virt_to_phys: Convert a virtual address mapped in the current > >>> + * context into a physical address. > >>> + * @clean_invalidate_dcache: Clean and invalidate the data cache for the > >>> + * specified memory address range. > >> This should probably be explicit about whether this to the PoU/PoC/PoP. > > Indeed. I can fix that locally if there is nothing else that requires > > adjusting. > Will be grateful ! Sorry, I missed the v7 update. One comment here is that the naming used in the patch series I mentioned shortens invalidate to inval (if you want it to be less of a mouthful): https://lore.kernel.org/linux-arm-kernel/20210524083001.2586635-19-tabba@google.com/ Otherwise: Reviewed-by: Fuad Tabba Thanks! /fuad > > Thanks, > Yanan > . > > > > M. > > > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C55C48BE8 for ; Fri, 18 Jun 2021 08:59:50 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id EB4BB613D1 for ; Fri, 18 Jun 2021 08:59:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB4BB613D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 70E634A5A0; Fri, 18 Jun 2021 04:59:49 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8SxH03OUvATJ; Fri, 18 Jun 2021 04:59:48 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5A8A74A4A3; Fri, 18 Jun 2021 04:59:48 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2F74340FC7 for ; Fri, 18 Jun 2021 04:59:47 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aMQokLA26lQg for ; Fri, 18 Jun 2021 04:59:45 -0400 (EDT) Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id D7D8B40825 for ; Fri, 18 Jun 2021 04:59:45 -0400 (EDT) Received: by mail-ot1-f53.google.com with SMTP id i12-20020a05683033ecb02903346fa0f74dso8996643otu.10 for ; Fri, 18 Jun 2021 01:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kxWq/w4pUVc8HOlAC++EsNgPCdWz4WRSzn6eNlOcpd8=; b=bhaMQb0WGrbDqa+aKHcQIksSIM+zTHdcqFfPBr5BV5rr/Wi8UST4PtBaFBBmWA70/c JeE4Hu4BbtwFqF0c80sjfACvvB1nesUeK9TieyU/oqhdgOex7UgfdkqRux0UxZ5/TcHT DLHvuKVExIhZtgV1fPhYLr/Md+zpFpFjNVpAPjGlXCP+m9MsUwKdcLN7akLZFoz7RcTk 238s+sJ/BuekxpTMYI4dcJE/HjWwxIUM3JYIJt/VdYH2Zb8cmBY3gzekVcESfoAgP54o bIIHlFX/dEToFLWW+5NXkS2fXPFEuRa4egZ9ULCaZiOK2z8px8znd93Nlh17ZN0KkdrP Dwpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kxWq/w4pUVc8HOlAC++EsNgPCdWz4WRSzn6eNlOcpd8=; b=dO701+lIbC4ZDkNnGB6stF7z02hNdTlIJo2KjhINkD9IB5FA7TGIj2mg78jVdmT3BW orogY4dMoENzrf97+N5kYXfYxEcpRDRcfxChB94OvRVGiZaMELKNpBpv4CeK3RaSGdTy zkS3Eanu1N8hWaff+BnpIZvScSTKZX5FQMt4oq32/LWo61hTsu1/Zc0eQkphxm5zan3c m0s9UMUNR6dywsLUyKRYzeJkapkA+5TdM9Pg7EO7mnjXuXkwDPFwZ8603GyCm08j5MrO 6s+QrsTHn54fKTP8mSIPy1qpXBmT+oACKDIW1FDuhmLcQU0ezsDQPbw2IOdGRZCfZTOx v8+g== X-Gm-Message-State: AOAM5315rYNcoco3i2X/41rZTHb2WG4cx1J/g57d693EfVTcaHa4gXU8 RYGXeiE/t82ZS/1GddJChDqkGBRxBw55/6kwYhaRwA== X-Google-Smtp-Source: ABdhPJwzc7DiWjyKPp58Q0od7P57f5+tDcapLIkUHFsPNVK62ZAuAwBi+XcIKklM8bb9dajJNv9sTtXhTaAbgYqG490= X-Received: by 2002:a05:6830:1598:: with SMTP id i24mr8497546otr.52.1624006785056; Fri, 18 Jun 2021 01:59:45 -0700 (PDT) MIME-Version: 1.0 References: <20210617105824.31752-1-wangyanan55@huawei.com> <20210617105824.31752-2-wangyanan55@huawei.com> <20210617123837.GA24457@willie-the-truck> <87eed0d13p.wl-maz@kernel.org> <2c1b9376-3997-aa7b-d5f3-b04da985c260@huawei.com> In-Reply-To: <2c1b9376-3997-aa7b-d5f3-b04da985c260@huawei.com> From: Fuad Tabba Date: Fri, 18 Jun 2021 09:59:09 +0100 Message-ID: Subject: Re: [PATCH v7 1/4] KVM: arm64: Introduce two cache maintenance callbacks To: "wangyanan (Y)" Cc: kvm@vger.kernel.org, Marc Zyngier , linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi, On Fri, Jun 18, 2021 at 2:52 AM wangyanan (Y) wrote: > > > > On 2021/6/17 22:20, Marc Zyngier wrote: > > On Thu, 17 Jun 2021 13:38:37 +0100, > > Will Deacon wrote: > >> On Thu, Jun 17, 2021 at 06:58:21PM +0800, Yanan Wang wrote: > >>> To prepare for performing CMOs for guest stage-2 in the fault handlers > >>> in pgtable.c, here introduce two cache maintenance callbacks in struct > >>> kvm_pgtable_mm_ops. We also adjust the comment alignment for the > >>> existing part but make no real content change at all. > >>> > >>> Signed-off-by: Yanan Wang > >>> --- > >>> arch/arm64/include/asm/kvm_pgtable.h | 42 +++++++++++++++++----------- > >>> 1 file changed, 25 insertions(+), 17 deletions(-) > >>> > >>> diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > >>> index c3674c47d48c..b6ce34aa44bb 100644 > >>> --- a/arch/arm64/include/asm/kvm_pgtable.h > >>> +++ b/arch/arm64/include/asm/kvm_pgtable.h > >>> @@ -27,23 +27,29 @@ typedef u64 kvm_pte_t; > >>> > >>> /** > >>> * struct kvm_pgtable_mm_ops - Memory management callbacks. > >>> - * @zalloc_page: Allocate a single zeroed memory page. The @arg parameter > >>> - * can be used by the walker to pass a memcache. The > >>> - * initial refcount of the page is 1. > >>> - * @zalloc_pages_exact: Allocate an exact number of zeroed memory pages. The > >>> - * @size parameter is in bytes, and is rounded-up to the > >>> - * next page boundary. The resulting allocation is > >>> - * physically contiguous. > >>> - * @free_pages_exact: Free an exact number of memory pages previously > >>> - * allocated by zalloc_pages_exact. > >>> - * @get_page: Increment the refcount on a page. > >>> - * @put_page: Decrement the refcount on a page. When the refcount > >>> - * reaches 0 the page is automatically freed. > >>> - * @page_count: Return the refcount of a page. > >>> - * @phys_to_virt: Convert a physical address into a virtual address mapped > >>> - * in the current context. > >>> - * @virt_to_phys: Convert a virtual address mapped in the current context > >>> - * into a physical address. > >>> + * @zalloc_page: Allocate a single zeroed memory page. > >>> + * The @arg parameter can be used by the walker > >>> + * to pass a memcache. The initial refcount of > >>> + * the page is 1. > >>> + * @zalloc_pages_exact: Allocate an exact number of zeroed memory pages. > >>> + * The @size parameter is in bytes, and is rounded > >>> + * up to the next page boundary. The resulting > >>> + * allocation is physically contiguous. > >>> + * @free_pages_exact: Free an exact number of memory pages previously > >>> + * allocated by zalloc_pages_exact. > >>> + * @get_page: Increment the refcount on a page. > >>> + * @put_page: Decrement the refcount on a page. When the > >>> + * refcount reaches 0 the page is automatically > >>> + * freed. > >>> + * @page_count: Return the refcount of a page. > >>> + * @phys_to_virt: Convert a physical address into a virtual address > >>> + * mapped in the current context. > >>> + * @virt_to_phys: Convert a virtual address mapped in the current > >>> + * context into a physical address. > >>> + * @clean_invalidate_dcache: Clean and invalidate the data cache for the > >>> + * specified memory address range. > >> This should probably be explicit about whether this to the PoU/PoC/PoP. > > Indeed. I can fix that locally if there is nothing else that requires > > adjusting. > Will be grateful ! Sorry, I missed the v7 update. One comment here is that the naming used in the patch series I mentioned shortens invalidate to inval (if you want it to be less of a mouthful): https://lore.kernel.org/linux-arm-kernel/20210524083001.2586635-19-tabba@google.com/ Otherwise: Reviewed-by: Fuad Tabba Thanks! /fuad > > Thanks, > Yanan > . > > > > M. > > > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F62AC48BDF for ; Fri, 18 Jun 2021 09:01:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB9EF61164 for ; Fri, 18 Jun 2021 09:01:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB9EF61164 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QegIyqk/YqfHmon7/7JFlBMsALbSpKEgvRkMzmt4F3I=; b=Wuhnud5MW6DFGi M9lgRf/vBXxRD8G1Qjwz5GgqUnqb8YN+tSkvbFGhP77RtFz5oNX2QybaeileP7vFe+Rgh0r5TcyQv dg101hS/bl/EOx2SnlWhGUfVfh1tT/7a7z+EGFDiDrVBezJEfHY9dQTajNqzMA2g8DYPYIpx/yHaq I9sx6Q1tQCixeyNYX+i4y6M8DzqLJP6C+0gIZNncHC33t1ZeDAjRziNEBMFX9J117rAMSu4a5JOJY 7jYgIAYYE1G12bLOBby8uAEAv+VX5IifB6C80RykmrpMIvNxda2k3v4Za28hr2ItnYl1y+ooEAyyL hDKSW2/Vmd8yG8UNDOkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1luALu-00DOiS-FN; Fri, 18 Jun 2021 08:59:50 +0000 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1luALq-00DOi1-K9 for linux-arm-kernel@lists.infradead.org; Fri, 18 Jun 2021 08:59:48 +0000 Received: by mail-ot1-x32e.google.com with SMTP id 6-20020a9d07860000b02903e83bf8f8fcso8984867oto.12 for ; Fri, 18 Jun 2021 01:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kxWq/w4pUVc8HOlAC++EsNgPCdWz4WRSzn6eNlOcpd8=; b=bhaMQb0WGrbDqa+aKHcQIksSIM+zTHdcqFfPBr5BV5rr/Wi8UST4PtBaFBBmWA70/c JeE4Hu4BbtwFqF0c80sjfACvvB1nesUeK9TieyU/oqhdgOex7UgfdkqRux0UxZ5/TcHT DLHvuKVExIhZtgV1fPhYLr/Md+zpFpFjNVpAPjGlXCP+m9MsUwKdcLN7akLZFoz7RcTk 238s+sJ/BuekxpTMYI4dcJE/HjWwxIUM3JYIJt/VdYH2Zb8cmBY3gzekVcESfoAgP54o bIIHlFX/dEToFLWW+5NXkS2fXPFEuRa4egZ9ULCaZiOK2z8px8znd93Nlh17ZN0KkdrP Dwpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kxWq/w4pUVc8HOlAC++EsNgPCdWz4WRSzn6eNlOcpd8=; b=W7kF2IzVA8lmB23/iWrj7wXCznEQ+tw1RWthfU/qjIYJBtE8nZAOIpTz5j9y5Cuz1L wEEg7c0IFL1sXnVHEByxN0aoF/lnG/gCHO4tt9yZX4NPeFbVfB7M8mAbBQT57WrpCILs sEZkP2dmZ43bwSWwqtEPkMysOTkkcKj2EDswIb0BnLFpEdy7PB47lglmZsT9Upze1PvG N2NOmgknmGR/grXhsYqG1dGp8Uw3IwocklDI+HVHlO4hWHcUSYRvxDqgJDjfV1zxrmkf 5L6Mp+UaeczYCLvAPjaDW0XgUXwtzy+fpL86naDXGg2x0a3eV5xUFEgaVFO+mZEUEEu4 az6A== X-Gm-Message-State: AOAM5327vUFFP993cl6uLuvP2ILaVy53qtLN8F+h6EQUcUGFo+43Nxm/ eI/7BUbRYjPFSTiHq9YGOq6nd3/srjkw7cORVc31dw== X-Google-Smtp-Source: ABdhPJwzc7DiWjyKPp58Q0od7P57f5+tDcapLIkUHFsPNVK62ZAuAwBi+XcIKklM8bb9dajJNv9sTtXhTaAbgYqG490= X-Received: by 2002:a05:6830:1598:: with SMTP id i24mr8497546otr.52.1624006785056; Fri, 18 Jun 2021 01:59:45 -0700 (PDT) MIME-Version: 1.0 References: <20210617105824.31752-1-wangyanan55@huawei.com> <20210617105824.31752-2-wangyanan55@huawei.com> <20210617123837.GA24457@willie-the-truck> <87eed0d13p.wl-maz@kernel.org> <2c1b9376-3997-aa7b-d5f3-b04da985c260@huawei.com> In-Reply-To: <2c1b9376-3997-aa7b-d5f3-b04da985c260@huawei.com> From: Fuad Tabba Date: Fri, 18 Jun 2021 09:59:09 +0100 Message-ID: Subject: Re: [PATCH v7 1/4] KVM: arm64: Introduce two cache maintenance callbacks To: "wangyanan (Y)" Cc: Marc Zyngier , Will Deacon , kvm@vger.kernel.org, Catalin Marinas , linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210618_015946_711552_E88C735B X-CRM114-Status: GOOD ( 28.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, Jun 18, 2021 at 2:52 AM wangyanan (Y) wrote: > > > > On 2021/6/17 22:20, Marc Zyngier wrote: > > On Thu, 17 Jun 2021 13:38:37 +0100, > > Will Deacon wrote: > >> On Thu, Jun 17, 2021 at 06:58:21PM +0800, Yanan Wang wrote: > >>> To prepare for performing CMOs for guest stage-2 in the fault handlers > >>> in pgtable.c, here introduce two cache maintenance callbacks in struct > >>> kvm_pgtable_mm_ops. We also adjust the comment alignment for the > >>> existing part but make no real content change at all. > >>> > >>> Signed-off-by: Yanan Wang > >>> --- > >>> arch/arm64/include/asm/kvm_pgtable.h | 42 +++++++++++++++++----------- > >>> 1 file changed, 25 insertions(+), 17 deletions(-) > >>> > >>> diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > >>> index c3674c47d48c..b6ce34aa44bb 100644 > >>> --- a/arch/arm64/include/asm/kvm_pgtable.h > >>> +++ b/arch/arm64/include/asm/kvm_pgtable.h > >>> @@ -27,23 +27,29 @@ typedef u64 kvm_pte_t; > >>> > >>> /** > >>> * struct kvm_pgtable_mm_ops - Memory management callbacks. > >>> - * @zalloc_page: Allocate a single zeroed memory page. The @arg parameter > >>> - * can be used by the walker to pass a memcache. The > >>> - * initial refcount of the page is 1. > >>> - * @zalloc_pages_exact: Allocate an exact number of zeroed memory pages. The > >>> - * @size parameter is in bytes, and is rounded-up to the > >>> - * next page boundary. The resulting allocation is > >>> - * physically contiguous. > >>> - * @free_pages_exact: Free an exact number of memory pages previously > >>> - * allocated by zalloc_pages_exact. > >>> - * @get_page: Increment the refcount on a page. > >>> - * @put_page: Decrement the refcount on a page. When the refcount > >>> - * reaches 0 the page is automatically freed. > >>> - * @page_count: Return the refcount of a page. > >>> - * @phys_to_virt: Convert a physical address into a virtual address mapped > >>> - * in the current context. > >>> - * @virt_to_phys: Convert a virtual address mapped in the current context > >>> - * into a physical address. > >>> + * @zalloc_page: Allocate a single zeroed memory page. > >>> + * The @arg parameter can be used by the walker > >>> + * to pass a memcache. The initial refcount of > >>> + * the page is 1. > >>> + * @zalloc_pages_exact: Allocate an exact number of zeroed memory pages. > >>> + * The @size parameter is in bytes, and is rounded > >>> + * up to the next page boundary. The resulting > >>> + * allocation is physically contiguous. > >>> + * @free_pages_exact: Free an exact number of memory pages previously > >>> + * allocated by zalloc_pages_exact. > >>> + * @get_page: Increment the refcount on a page. > >>> + * @put_page: Decrement the refcount on a page. When the > >>> + * refcount reaches 0 the page is automatically > >>> + * freed. > >>> + * @page_count: Return the refcount of a page. > >>> + * @phys_to_virt: Convert a physical address into a virtual address > >>> + * mapped in the current context. > >>> + * @virt_to_phys: Convert a virtual address mapped in the current > >>> + * context into a physical address. > >>> + * @clean_invalidate_dcache: Clean and invalidate the data cache for the > >>> + * specified memory address range. > >> This should probably be explicit about whether this to the PoU/PoC/PoP. > > Indeed. I can fix that locally if there is nothing else that requires > > adjusting. > Will be grateful ! Sorry, I missed the v7 update. One comment here is that the naming used in the patch series I mentioned shortens invalidate to inval (if you want it to be less of a mouthful): https://lore.kernel.org/linux-arm-kernel/20210524083001.2586635-19-tabba@google.com/ Otherwise: Reviewed-by: Fuad Tabba Thanks! /fuad > > Thanks, > Yanan > . > > > > M. > > > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel