From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE466C4338F for ; Mon, 2 Aug 2021 10:31:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE5D86023B for ; Mon, 2 Aug 2021 10:31:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233185AbhHBKbN (ORCPT ); Mon, 2 Aug 2021 06:31:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231357AbhHBKbM (ORCPT ); Mon, 2 Aug 2021 06:31:12 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20616C06175F for ; Mon, 2 Aug 2021 03:31:03 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id nd39so30113667ejc.5 for ; Mon, 02 Aug 2021 03:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yGVEq9B5bByjRAfhMPs/aPNjzWR9vo1LM/IsDeZ/fw4=; b=NhuObWYcT4Ws0XBuXGzohVpUDGBsWLH4oX9MHLm87mGm0eyOzT5PsB+WKSYrCavXnr qPixW7MErBufFuWbaYkRUJLEeTDLjpSj7MFMfR1Xso+L8nRPbtdbfotRZGLumNl7gTJu R0K3BmV36cB5GI09hubxsKpuY4ThUI2+rMpsfE5o64afsQ72esreblTgFkjibXtlmMmC EOTGmpbqO5PirVRv9RmsdqwM9/ewHqzGMXXQIFHScsTHHJch8eRpXGFveDSELD035UZv ly9DrFt1gVzB0onpWLtIl7mzSfGMj9juv9pLca65D6xEx30TGFE6r4dxjouj1wJMNPkd 48lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yGVEq9B5bByjRAfhMPs/aPNjzWR9vo1LM/IsDeZ/fw4=; b=sH7blzMK1JiA3MIZE2VY/zWESxntGejHLs/Baj1u7b2C5A6ijxj5PXu0GUAgJYKRcV cgRBGzYbLyA869O71hMw44ZFg//H6iFr03k1DXZjDgRQ6C9sQzJAjZQMb3Vrd8zzPPBB g5Vg6Dgq4bBwrD1/L4bBSocgyqHxbyBHiteqc2IvgOY6Bt7F/ivyWzez3fN6FUQfp7UY nBzczc0A3KmMZw8oxJtB3QdI7z4fZfoORP3Y/aEBp/4CQgaBiwdaDsDWMUTBIfgk6gFi vG2KOUkS8KqLC06X+RxPNVNKKplzRi3SctlEvDAsX30VVltXsaaLnLP5lDklpWwX0len 0UjA== X-Gm-Message-State: AOAM531DNw8Y5qr6TLZgk9PAovGt2cEX2MMEI3CltRLkorwwJQeDix1q xlNKI8TRliQ4gatpw46eIz3DcyFXhvooTx/iBAtQfA== X-Google-Smtp-Source: ABdhPJwELrHM8KMcxJgMtc2//RdcfHO0BBsraGRqwLVekJXAVvzXhMzTKx/LaOqiF+bS/C2fHPTkVM4G1T50Hhsf+GE= X-Received: by 2002:a17:906:2441:: with SMTP id a1mr13848525ejb.550.1627900261494; Mon, 02 Aug 2021 03:31:01 -0700 (PDT) MIME-Version: 1.0 References: <20210729132818.4091769-1-qperret@google.com> <20210729132818.4091769-13-qperret@google.com> In-Reply-To: <20210729132818.4091769-13-qperret@google.com> From: Fuad Tabba Date: Mon, 2 Aug 2021 12:30:25 +0200 Message-ID: Subject: Re: [PATCH v3 12/21] KVM: arm64: Add helpers to tag shared pages in SW bits To: Quentin Perret Cc: maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, ardb@kernel.org, qwandor@google.com, dbrazdil@google.com, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Quentin, On Thu, Jul 29, 2021 at 3:28 PM Quentin Perret wrote: > > We will soon start annotating shared pages in page-tables in nVHE > protected mode. Define all the states in which a page can be (owned, > shared and owned, shared and borrowed), and provide helpers allowing to > convert this into SW bits annotations using the matching prot > attributes. > > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/hyp/include/nvhe/mem_protect.h | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > index 9c227d87c36d..ae355bfd8c01 100644 > --- a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > +++ b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > @@ -12,6 +12,32 @@ > #include > #include > > +/* > + * SW bits 0-1 are reserved to track the memory ownership state of each page: > + * 00: The page is owned solely by the page-table owner. nit: solely -> exclusively, because "exclusive" is the more common term in context of shared resources > + * 01: The page is owned by the page-table owner, but is shared > + * with another entity. > + * 10: The page is shared with, but not owned by the page-table owner. > + * 11: Reserved for future use (lending). > + */ > +enum pkvm_page_state { > + PKVM_PAGE_OWNED = 0ULL, > + PKVM_PAGE_SHARED_OWNED = KVM_PGTABLE_PROT_SW0, > + PKVM_PAGE_SHARED_BORROWED = KVM_PGTABLE_PROT_SW1, > +}; > + > +#define PKVM_PAGE_STATE_PROT_MASK (KVM_PGTABLE_PROT_SW0 | KVM_PGTABLE_PROT_SW1) > +static inline enum kvm_pgtable_prot pkvm_mkstate(enum kvm_pgtable_prot prot, > + enum pkvm_page_state state) > +{ > + return (prot & ~PKVM_PAGE_STATE_PROT_MASK) | state; > +} > + > +static inline enum pkvm_page_state pkvm_getstate(enum kvm_pgtable_prot prot) > +{ > + return prot & PKVM_PAGE_STATE_PROT_MASK; > +} > + I think that this encoding is pretty neat and easy to follow. Reviewed-by: Fuad Tabba Thanks, /fuad > struct host_kvm { > struct kvm_arch arch; > struct kvm_pgtable pgt; > -- > 2.32.0.432.gabb21c7263-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B2F3C4320A for ; Mon, 2 Aug 2021 10:31:06 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id F05B560F5A for ; Mon, 2 Aug 2021 10:31:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F05B560F5A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7069D4A193; Mon, 2 Aug 2021 06:31:05 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RtAMuyvpdFmS; Mon, 2 Aug 2021 06:31:04 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6ABF34A19B; Mon, 2 Aug 2021 06:31:04 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E23D04A126 for ; Mon, 2 Aug 2021 06:31:03 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VydWCg0ZsrjL for ; Mon, 2 Aug 2021 06:31:02 -0400 (EDT) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id AD2D34099E for ; Mon, 2 Aug 2021 06:31:02 -0400 (EDT) Received: by mail-ej1-f43.google.com with SMTP id oz16so30064763ejc.7 for ; Mon, 02 Aug 2021 03:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yGVEq9B5bByjRAfhMPs/aPNjzWR9vo1LM/IsDeZ/fw4=; b=NhuObWYcT4Ws0XBuXGzohVpUDGBsWLH4oX9MHLm87mGm0eyOzT5PsB+WKSYrCavXnr qPixW7MErBufFuWbaYkRUJLEeTDLjpSj7MFMfR1Xso+L8nRPbtdbfotRZGLumNl7gTJu R0K3BmV36cB5GI09hubxsKpuY4ThUI2+rMpsfE5o64afsQ72esreblTgFkjibXtlmMmC EOTGmpbqO5PirVRv9RmsdqwM9/ewHqzGMXXQIFHScsTHHJch8eRpXGFveDSELD035UZv ly9DrFt1gVzB0onpWLtIl7mzSfGMj9juv9pLca65D6xEx30TGFE6r4dxjouj1wJMNPkd 48lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yGVEq9B5bByjRAfhMPs/aPNjzWR9vo1LM/IsDeZ/fw4=; b=n4FwTBhMC9JhhKFcU6Legpct4eMNl4RLcESXfbrZNJKV/vTtMX7e98lURXlFo1O8hF uoMDozEBIm85wDIlQdbugi2VeOPysMY/JVO1qvGDs6FYgJy835IhHJPjOmPGfRaiIACy /ATId8+ckJgxOZpd/dunHsffl2hz0IqdNXoX8H4Ynb26GOHZCSi2n4/WGoCcnmfyFUKd XOAepd4GZzISvOAqo1xbG5v40YEYoitiocdJkT6xTsdsVrLmzWfE1pnX6yEcfQoCVg6v OO8tddoCLuJ2SF6+H/CeN1UxS34XgIKB5WlA2Ga3IfUWJaAZbphGYkT3JOHlIEk/eTE/ c8Qw== X-Gm-Message-State: AOAM5300iBlATzNLJCux7/f8ISA+GPGbuPzmM6GrB8owG3rrQm8fh3FO XugLjejMwSMmaHfvqL+ymIgsqUihcMpqrJOXd/ESPw== X-Google-Smtp-Source: ABdhPJwELrHM8KMcxJgMtc2//RdcfHO0BBsraGRqwLVekJXAVvzXhMzTKx/LaOqiF+bS/C2fHPTkVM4G1T50Hhsf+GE= X-Received: by 2002:a17:906:2441:: with SMTP id a1mr13848525ejb.550.1627900261494; Mon, 02 Aug 2021 03:31:01 -0700 (PDT) MIME-Version: 1.0 References: <20210729132818.4091769-1-qperret@google.com> <20210729132818.4091769-13-qperret@google.com> In-Reply-To: <20210729132818.4091769-13-qperret@google.com> From: Fuad Tabba Date: Mon, 2 Aug 2021 12:30:25 +0200 Message-ID: Subject: Re: [PATCH v3 12/21] KVM: arm64: Add helpers to tag shared pages in SW bits To: Quentin Perret Cc: kernel-team@android.com, qwandor@google.com, maz@kernel.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Quentin, On Thu, Jul 29, 2021 at 3:28 PM Quentin Perret wrote: > > We will soon start annotating shared pages in page-tables in nVHE > protected mode. Define all the states in which a page can be (owned, > shared and owned, shared and borrowed), and provide helpers allowing to > convert this into SW bits annotations using the matching prot > attributes. > > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/hyp/include/nvhe/mem_protect.h | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > index 9c227d87c36d..ae355bfd8c01 100644 > --- a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > +++ b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > @@ -12,6 +12,32 @@ > #include > #include > > +/* > + * SW bits 0-1 are reserved to track the memory ownership state of each page: > + * 00: The page is owned solely by the page-table owner. nit: solely -> exclusively, because "exclusive" is the more common term in context of shared resources > + * 01: The page is owned by the page-table owner, but is shared > + * with another entity. > + * 10: The page is shared with, but not owned by the page-table owner. > + * 11: Reserved for future use (lending). > + */ > +enum pkvm_page_state { > + PKVM_PAGE_OWNED = 0ULL, > + PKVM_PAGE_SHARED_OWNED = KVM_PGTABLE_PROT_SW0, > + PKVM_PAGE_SHARED_BORROWED = KVM_PGTABLE_PROT_SW1, > +}; > + > +#define PKVM_PAGE_STATE_PROT_MASK (KVM_PGTABLE_PROT_SW0 | KVM_PGTABLE_PROT_SW1) > +static inline enum kvm_pgtable_prot pkvm_mkstate(enum kvm_pgtable_prot prot, > + enum pkvm_page_state state) > +{ > + return (prot & ~PKVM_PAGE_STATE_PROT_MASK) | state; > +} > + > +static inline enum pkvm_page_state pkvm_getstate(enum kvm_pgtable_prot prot) > +{ > + return prot & PKVM_PAGE_STATE_PROT_MASK; > +} > + I think that this encoding is pretty neat and easy to follow. Reviewed-by: Fuad Tabba Thanks, /fuad > struct host_kvm { > struct kvm_arch arch; > struct kvm_pgtable pgt; > -- > 2.32.0.432.gabb21c7263-goog > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8844FC4338F for ; Mon, 2 Aug 2021 10:32:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 460A560F70 for ; Mon, 2 Aug 2021 10:32:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 460A560F70 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8oqDU/9yl7kEl5dYvwuBEjW8UT9KXfp1aF5Hlu3WKFg=; b=icd+USX6CfiZg2 +6/x9jyQYIqj16gXcoAPGGOlBnyJYrQh6b7FSFe8fOqu1XtSlYrFKBk0t+eQDpydu+H4eItYLygQp R0jPc7VJjUdsnmbSiT3fZWjtGjxE2ysEg4GoF4AdtHF+HOnuU28E6O0h+6QvPd3bhSt2AtoRU/huJ xyM993pY6g+kpSRMpLMvcEevXyqcbMlyUs2BhZijgBhAwh/k11gXsNcB1lJjO49FS4gfyCbhpaBwv EO4orxWfR0mQbZEHJWhTe7ZzbxIL6wO35D98XdOP7T615/SRmyzTTCWqRCog8wd9vvMR2C1HbnBW8 EtlZnj2PgaWawUJVlE/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAVDz-00FkS9-31; Mon, 02 Aug 2021 10:31:11 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAVDr-00FkQK-Ma for linux-arm-kernel@lists.infradead.org; Mon, 02 Aug 2021 10:31:08 +0000 Received: by mail-ej1-x62a.google.com with SMTP id hs10so21441749ejc.0 for ; Mon, 02 Aug 2021 03:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yGVEq9B5bByjRAfhMPs/aPNjzWR9vo1LM/IsDeZ/fw4=; b=NhuObWYcT4Ws0XBuXGzohVpUDGBsWLH4oX9MHLm87mGm0eyOzT5PsB+WKSYrCavXnr qPixW7MErBufFuWbaYkRUJLEeTDLjpSj7MFMfR1Xso+L8nRPbtdbfotRZGLumNl7gTJu R0K3BmV36cB5GI09hubxsKpuY4ThUI2+rMpsfE5o64afsQ72esreblTgFkjibXtlmMmC EOTGmpbqO5PirVRv9RmsdqwM9/ewHqzGMXXQIFHScsTHHJch8eRpXGFveDSELD035UZv ly9DrFt1gVzB0onpWLtIl7mzSfGMj9juv9pLca65D6xEx30TGFE6r4dxjouj1wJMNPkd 48lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yGVEq9B5bByjRAfhMPs/aPNjzWR9vo1LM/IsDeZ/fw4=; b=qhie6is3Z0N2UfSHK2Ufx+p14prnIa4r9MsBWS6DPVFo8T2tZCxUucaEONBM+4xdaA 7WavJuHWIoL4uZHL/4yhqylaip2iwbE1NXMHqMaGvTHYEcJXcNwaXVh3U43sqjOb3La5 4QwxCjCgka/sTKMnvHjcYxk2JmkwaYl/rg4HFxznAQ1C8pIBSbbVITDrlPWgNNYIrlOa mlrHPsiZ9fSH0iewEsWLapJc6zhCurP3EjTqXyp51NXqUfyUiLAoqnjfI1PXfIIAPlUx oyuj3HRd4wKTZhbj3A0Rryl2MWkA6Z250X34nZpdDAQDA44Ge1c+Dnp2lWgF06MiE5W9 g7kA== X-Gm-Message-State: AOAM5307Lfy+J4sElPEojoSbVwoE1hvtg9a6FtKtv6CEVQF7rFtMJCVP eIhNgxElSz3//ifkOFkuj2Jpje3qYZypoatcTtfOxA== X-Google-Smtp-Source: ABdhPJwELrHM8KMcxJgMtc2//RdcfHO0BBsraGRqwLVekJXAVvzXhMzTKx/LaOqiF+bS/C2fHPTkVM4G1T50Hhsf+GE= X-Received: by 2002:a17:906:2441:: with SMTP id a1mr13848525ejb.550.1627900261494; Mon, 02 Aug 2021 03:31:01 -0700 (PDT) MIME-Version: 1.0 References: <20210729132818.4091769-1-qperret@google.com> <20210729132818.4091769-13-qperret@google.com> In-Reply-To: <20210729132818.4091769-13-qperret@google.com> From: Fuad Tabba Date: Mon, 2 Aug 2021 12:30:25 +0200 Message-ID: Subject: Re: [PATCH v3 12/21] KVM: arm64: Add helpers to tag shared pages in SW bits To: Quentin Perret Cc: maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, ardb@kernel.org, qwandor@google.com, dbrazdil@google.com, kernel-team@android.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_033103_802378_5641847B X-CRM114-Status: GOOD ( 21.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Quentin, On Thu, Jul 29, 2021 at 3:28 PM Quentin Perret wrote: > > We will soon start annotating shared pages in page-tables in nVHE > protected mode. Define all the states in which a page can be (owned, > shared and owned, shared and borrowed), and provide helpers allowing to > convert this into SW bits annotations using the matching prot > attributes. > > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/hyp/include/nvhe/mem_protect.h | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > index 9c227d87c36d..ae355bfd8c01 100644 > --- a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > +++ b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > @@ -12,6 +12,32 @@ > #include > #include > > +/* > + * SW bits 0-1 are reserved to track the memory ownership state of each page: > + * 00: The page is owned solely by the page-table owner. nit: solely -> exclusively, because "exclusive" is the more common term in context of shared resources > + * 01: The page is owned by the page-table owner, but is shared > + * with another entity. > + * 10: The page is shared with, but not owned by the page-table owner. > + * 11: Reserved for future use (lending). > + */ > +enum pkvm_page_state { > + PKVM_PAGE_OWNED = 0ULL, > + PKVM_PAGE_SHARED_OWNED = KVM_PGTABLE_PROT_SW0, > + PKVM_PAGE_SHARED_BORROWED = KVM_PGTABLE_PROT_SW1, > +}; > + > +#define PKVM_PAGE_STATE_PROT_MASK (KVM_PGTABLE_PROT_SW0 | KVM_PGTABLE_PROT_SW1) > +static inline enum kvm_pgtable_prot pkvm_mkstate(enum kvm_pgtable_prot prot, > + enum pkvm_page_state state) > +{ > + return (prot & ~PKVM_PAGE_STATE_PROT_MASK) | state; > +} > + > +static inline enum pkvm_page_state pkvm_getstate(enum kvm_pgtable_prot prot) > +{ > + return prot & PKVM_PAGE_STATE_PROT_MASK; > +} > + I think that this encoding is pretty neat and easy to follow. Reviewed-by: Fuad Tabba Thanks, /fuad > struct host_kvm { > struct kvm_arch arch; > struct kvm_pgtable pgt; > -- > 2.32.0.432.gabb21c7263-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel