From: Han Xu <xhnjupt@gmail.com>
To: Esben Haabendal <esben@geanix.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
Sascha Hauer <s.hauer@pengutronix.de>,
sean@geanix.com, martin@geanix.com,
Boris Brezillon <boris.brezillon@collabora.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Han Xu <han.xu@nxp.com>
Subject: Re: [PATCH 2/2] mtd: rawnand: gpmi: Restore nfc timing setup after suspend/resume
Date: Mon, 13 Jan 2020 11:34:06 -0600 [thread overview]
Message-ID: <CA+EcR21ZMa85XY8hBJ2c5pV5rEbKazP7AmouYcLpyhzuVSDL6A@mail.gmail.com> (raw)
In-Reply-To: <20200102130826.170647-2-esben@geanix.com>
On Thu, Jan 2, 2020 at 7:08 AM Esben Haabendal <esben@geanix.com> wrote:
>
> As we reset the GPMI block at resume, the timing parameters setup by a
> previous exec_op is lost. Rewriting GPMI timing registers on first exec_op
> after resume fixes the problem.
>
> Signed-off-by: Esben Haabendal <esben@geanix.com>
> ---
> drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> index 7ac8c8b95afc..fcc7325f2a10 100644
> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> @@ -2728,6 +2728,10 @@ static int gpmi_pm_resume(struct device *dev)
> return ret;
> }
>
> + /* Set flag to get timing setup restored for next exec_op */
> + if (this->hw.clk_rate)
> + this->hw.must_apply_timings = true;
> +
Acked-by: Han Xu <han.xu@nxp.com>
> /* re-init the BCH registers */
> ret = bch_set_geometry(this);
> if (ret) {
> --
> 2.24.1
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
--
Sincerely,
Han XU
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-13 17:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 13:08 [PATCH 1/2] mtd: rawnand: gpmi: Fix suspend/resume problem Esben Haabendal
2020-01-02 13:08 ` [PATCH 2/2] mtd: rawnand: gpmi: Restore nfc timing setup after suspend/resume Esben Haabendal
2020-01-13 17:34 ` Han Xu [this message]
2020-01-14 17:03 ` Miquel Raynal
2020-01-07 19:31 ` [PATCH 1/2] mtd: rawnand: gpmi: Fix suspend/resume problem Han Xu
2020-01-09 15:15 ` Miquel Raynal
2020-01-09 17:11 ` Han Xu
2020-01-13 17:32 ` Han Xu
2020-01-14 17:03 ` Miquel Raynal
2020-01-14 17:09 ` Fabio Estevam
2020-01-14 17:25 ` Miquel Raynal
2020-01-14 17:29 ` Fabio Estevam
2020-01-15 7:46 ` Sascha Hauer
2020-01-15 8:46 ` Miquel Raynal
2020-01-17 19:48 ` Esben Haabendal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+EcR21ZMa85XY8hBJ2c5pV5rEbKazP7AmouYcLpyhzuVSDL6A@mail.gmail.com \
--to=xhnjupt@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=esben@geanix.com \
--cc=han.xu@nxp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=martin@geanix.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=sean@geanix.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.