From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D72C2B9F8 for ; Tue, 25 May 2021 18:01:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9306D613CC for ; Tue, 25 May 2021 18:01:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9306D613CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llbMV-0004si-HK for qemu-devel@archiver.kernel.org; Tue, 25 May 2021 14:01:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llbLY-00046I-SH for qemu-devel@nongnu.org; Tue, 25 May 2021 14:00:05 -0400 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]:36478) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llbLX-00058z-31 for qemu-devel@nongnu.org; Tue, 25 May 2021 14:00:04 -0400 Received: by mail-qt1-x833.google.com with SMTP id s12so14542767qta.3 for ; Tue, 25 May 2021 11:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=eOXD7o6wLctvgeL+nt1q6iawYp3GBBhYkdBfGkA3PnQ=; b=iu++9V5/dkmR2c7VFUcpwkwFBHJTNZdQCa9sf1B2DaLTM3z5RKcRCeYQv8s2CWWSyD I3mrfH9LpcVN+mYlCRkO5A/JUgztOjAxCpI9YUZ15pSHdBOc716bzYhvA8fWQrIO1cvd tZmeL2QXYY/cW/tmojlECd/dxhSKXWkePc795QGOFcbYTZhLBrQ2RzJSUKLfrivG41nE niPsb73Wv5wyna91ksBtmQiSvn4M4cNIe32hYUuOL5P6l6iAMfzxpuImWZJ1HcgDB563 ixh8q/TLbWwxIw+LOmq0nRYe8PcutKMT+qJu1yundL5p7FQC66oFpeB5M9iIaalWexJW k23A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=eOXD7o6wLctvgeL+nt1q6iawYp3GBBhYkdBfGkA3PnQ=; b=YR03GCnQkkzdQAoJl9aY/oGyA7tQ7WLog4TIpiH+xyfG2NGX7xTcKeuYBxDj9hxgS6 rstnVeIn/Tcinuaon+88cUZ5jCnpL2T6E1JzH2uBHFnwfmNeGPSj8YbG5fLvkU57WpNa ClJCI54ckga8LBh7cNVlX6nNkXcmy7ZXECm/VZEkjw7HL+J62R4KRd3qQzwSO+P3G4wD +i1UFUmrtH+dvbMpNiRXHfqWWH65d543Q2Lj/avlR53zFmt2/9IP+5ZCpxH+38/vH3sA gT9sV7T5/B79ngVaoF8JJPNHlasNDL87KqjkQWnTnvw4DlISmHIVi9YH5aFXgRuIsOEk Py1A== X-Gm-Message-State: AOAM531paWZe0kJty5BQvG5aE2xKVRmw9ougAsz6PIr06HZKbHdH7CS/ CfNxcrkYJwKv4mHtuS0Yx3vIAvKoWdMLspX7ExA= X-Google-Smtp-Source: ABdhPJxsYO1ipP2byx2sALyAHhGTxYbA9+Im6TDk4Sm/Nndk6YW74tna6SM9aLE/eqX3A8KxtOBxjiS9Ug+osG67zvU= X-Received: by 2002:ac8:5402:: with SMTP id b2mr14241301qtq.259.1621965601915; Tue, 25 May 2021 11:00:01 -0700 (PDT) MIME-Version: 1.0 References: <20210525124753.528516-1-kit.westneat@gmail.com> <20210525124753.528516-2-kit.westneat@gmail.com> <20210525144604.vcbujj6tlpjp3qr2@redhat.com> In-Reply-To: <20210525144604.vcbujj6tlpjp3qr2@redhat.com> From: Kit Westneat Date: Tue, 25 May 2021 13:59:49 -0400 Message-ID: Subject: Re: [PATCH 1/3] block/blkdebug: add blocksize parameter To: Kit Westneat , qemu-devel@nongnu.org, pbonzini@redhat.com Content-Type: multipart/alternative; boundary="0000000000008a495105c32b4b57" Received-SPF: pass client-ip=2607:f8b0:4864:20::833; envelope-from=kit.westneat@gmail.com; helo=mail-qt1-x833.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000008a495105c32b4b57 Content-Type: text/plain; charset="UTF-8" Makes sense. Sorry for the basic question, but is that just a matter of adding it to qapi/block-core.json? Thanks, Kit On Tue, May 25, 2021 at 10:46 AM Eric Blake wrote: > On Tue, May 25, 2021 at 12:47:51PM +0000, Kit Westneat wrote: > > Allow users to specify the block size of the qdev for testing purposes. > > > > Signed-off-by: Kit Westneat > > --- > > block/blkdebug.c | 27 +++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > Should this also be selectable when using QAPI to create a blkdebug > device over QMP? > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org > > --0000000000008a495105c32b4b57 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Makes sense. Sorry for the basic question, but is tha= t just a matter of adding it to qapi/block-core.json?

<= div>Thanks,
Kit

On Tue, May 25, 2021 at 10:46 AM Eric Bl= ake <eblake@redhat.com> wrot= e:
On Tue, May 2= 5, 2021 at 12:47:51PM +0000, Kit Westneat wrote:
> Allow users to specify the block size of the qdev for testing purposes= .
>
> Signed-off-by: Kit Westneat <kit.westneat@gmail.com>
> ---
>=C2=A0 block/blkdebug.c | 27 +++++++++++++++++++++++++++
>=C2=A0 1 file changed, 27 insertions(+)

Should this also be selectable when using QAPI to create a blkdebug
device over QMP?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0+1-919-301-3266
Virtualization:=C2=A0 qemu.org | libvirt.org

--0000000000008a495105c32b4b57--